From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 265F377B3E; Wed, 13 Dec 2023 23:31:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="I30m7AyQ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 90793C433C7; Wed, 13 Dec 2023 23:31:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702510310; bh=CYk4Vn37Odwag4wylcBdb225KIeTYI7q2wSlTu85hdc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=I30m7AyQlDx9+eOJ4Grr7Cv4oJvb1XEse2Ae6Rg+wgwpdflFFnXbtpzRA+jaQ5VvR 2ROuq0RDMTIuiTSa3osxLKzMHhiWM2Wi99JJcG2aWJtNZo0gXns09T7WjGbqoHfnJq OM88ed89CqaBkm9FRod8k8VnDKCKUnyD/7yf5pdFqgMq7biGqQV3ZEYpPuLEcZZq8F qCeRvmsV4ifBZo4kEYT0umqWRunSZ7zcZ5qc2lfHEULA3qF7ozNHEOGyw94ZQ4L0M/ 9rUnrFoXYRrvZlaUhEof+jK1Ul/4IcY4YAtXhiU259z+Tf8EYW4JptZzAcgo0IkMfI HzapnnNbI4mIg== Date: Wed, 13 Dec 2023 15:31:49 -0800 From: Saeed Mahameed To: Dan Carpenter Cc: Paul Blakey , Saeed Mahameed , Leon Romanovsky , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Oz Sholmo , Roi Dayan , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH net 1/2] net/mlx5e: Fix error code in mlx5e_tc_action_miss_mapping_get() Message-ID: References: <133f4081-6f34-4e3b-b4b5-bacd76961376@moroto.mountain> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <133f4081-6f34-4e3b-b4b5-bacd76961376@moroto.mountain> On 13 Dec 17:08, Dan Carpenter wrote: >Preserve the error code if esw_add_restore_rule() fails. Don't return >success. > >Fixes: 6702782845a5 ("net/mlx5e: TC, Set CT miss to the specific ct action instance") >Signed-off-by: Dan Carpenter >--- LGTM, both patches applied to net-mlx5. will send the PR shortly.