From: Hangbin Liu <liuhangbin@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, Jiri Pirko <jiri@resnulli.us>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [Draft PATCH net-next 1/3] Documentation: netlink: add a YAML spec for team
Date: Thu, 14 Dec 2023 11:52:50 +0800 [thread overview]
Message-ID: <ZXp8Elbqfxuum01g@Laptop-X1> (raw)
In-Reply-To: <20231213081818.4e885817@kernel.org>
On Wed, Dec 13, 2023 at 08:18:18AM -0800, Jakub Kicinski wrote:
> On Wed, 13 Dec 2023 16:45:00 +0800 Hangbin Liu wrote:
> > + -
> > + name: noop
> > + doc: No operation
> > + value: 0
> > + attribute-set: team
> > + dont-validate: [ strict, dump ]
> > +
> > + do:
> > + # Actually it only reply the team netlink family
> > + reply:
> > + attributes:
> > + - team-ifindex
>
> Oh my. Does it actually take team-ifindex or its an op with no input
> and no output?
No, it doesn't take team-ifindex. It's an option with no input
and just reply the team_nl_family.
I added this reply attribute just to make sure the TEAM_CMD_NOOP show in the
cmd enum to not break uAPI.
Thanks
Hangbin
next prev parent reply other threads:[~2023-12-14 3:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-13 8:44 [Draft PATCH net-next 0/3] add YAML spec for team Hangbin Liu
2023-12-13 8:45 ` [Draft PATCH net-next 1/3] Documentation: netlink: add a " Hangbin Liu
2023-12-13 15:36 ` Jiri Pirko
2023-12-14 3:44 ` Hangbin Liu
2023-12-14 8:25 ` Jiri Pirko
2023-12-13 16:18 ` Jakub Kicinski
2023-12-14 3:52 ` Hangbin Liu [this message]
2023-12-14 19:14 ` Jakub Kicinski
2023-12-13 8:45 ` [Draft PATCH net-next 2/3] net: team: use policy generated by YAML spec Hangbin Liu
2023-12-13 15:44 ` Jiri Pirko
2023-12-13 8:45 ` [Draft PATCH net-next 3/3] uapi: team: use header file generated from " Hangbin Liu
2023-12-13 15:39 ` Jiri Pirko
2023-12-13 16:36 ` [Draft PATCH net-next 0/3] add YAML spec for team Jakub Kicinski
2023-12-14 4:15 ` Hangbin Liu
2023-12-14 19:17 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXp8Elbqfxuum01g@Laptop-X1 \
--to=liuhangbin@gmail.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).