From: Jiri Pirko <jiri@resnulli.us>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [Draft PATCH net-next 1/3] Documentation: netlink: add a YAML spec for team
Date: Thu, 14 Dec 2023 09:25:56 +0100 [thread overview]
Message-ID: <ZXq8FIawPKUqcvk6@nanopsycho> (raw)
In-Reply-To: <ZXp6CsaveeEPOVOm@Laptop-X1>
Thu, Dec 14, 2023 at 04:44:10AM CET, liuhangbin@gmail.com wrote:
>On Wed, Dec 13, 2023 at 04:36:32PM +0100, Jiri Pirko wrote:
>> >+operations:
>> >+ list:
>> >+ -
>> >+ name: noop
>> >+ doc: No operation
>> >+ value: 0
>> >+ attribute-set: team
>> >+ dont-validate: [ strict, dump ]
>>
>> What is this good for?
>>
>>
>> >+
>> >+ do:
>> >+ # Actually it only reply the team netlink family
>> >+ reply:
>> >+ attributes:
>> >+ - team-ifindex
>> >+
>> >+ -
>> >+ name: options-set
>> >+ doc: Set team options
>> >+ attribute-set: team
>> >+ dont-validate: [ strict, dump ]
>>
>> There is no dump op. Same below.
>>
>Hi Jiri,
>
>I just copied this from the current team.c code. e.g.
Right, it is something which is not looked at. Remove it during the
conversion.
>
>static const struct genl_small_ops team_nl_ops[] = {
> {
> .cmd = TEAM_CMD_NOOP,
> .validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP,
> .doit = team_nl_cmd_noop,
> },
> {
> .cmd = TEAM_CMD_OPTIONS_SET,
> .validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP,
> .doit = team_nl_cmd_options_set,
> .flags = GENL_ADMIN_PERM,
> },
>
>Do you want to remove all the GENL_DONT_VALIDATE_DUMP flags from team_nl_ops?
>
>Thanks
>Hangbin
next prev parent reply other threads:[~2023-12-14 8:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-13 8:44 [Draft PATCH net-next 0/3] add YAML spec for team Hangbin Liu
2023-12-13 8:45 ` [Draft PATCH net-next 1/3] Documentation: netlink: add a " Hangbin Liu
2023-12-13 15:36 ` Jiri Pirko
2023-12-14 3:44 ` Hangbin Liu
2023-12-14 8:25 ` Jiri Pirko [this message]
2023-12-13 16:18 ` Jakub Kicinski
2023-12-14 3:52 ` Hangbin Liu
2023-12-14 19:14 ` Jakub Kicinski
2023-12-13 8:45 ` [Draft PATCH net-next 2/3] net: team: use policy generated by YAML spec Hangbin Liu
2023-12-13 15:44 ` Jiri Pirko
2023-12-13 8:45 ` [Draft PATCH net-next 3/3] uapi: team: use header file generated from " Hangbin Liu
2023-12-13 15:39 ` Jiri Pirko
2023-12-13 16:36 ` [Draft PATCH net-next 0/3] add YAML spec for team Jakub Kicinski
2023-12-14 4:15 ` Hangbin Liu
2023-12-14 19:17 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXq8FIawPKUqcvk6@nanopsycho \
--to=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).