From: Daniel Golle <daniel@makrotopia.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: phy: skip LED triggers on PHYs on SFP modules
Date: Fri, 15 Dec 2023 02:54:20 +0000 [thread overview]
Message-ID: <ZXu_3OnSzmLq5GAH@makrotopia.org> (raw)
In-Reply-To: <20231214183123.0f0af377@kernel.org>
On Thu, Dec 14, 2023 at 06:31:23PM -0800, Jakub Kicinski wrote:
> On Tue, 12 Dec 2023 00:05:35 +0000 Daniel Golle wrote:
> > Calling led_trigger_register() when attaching a PHY located on an SFP
> > module potentially (and practically) leads into a deadlock.
> > Fix this by not calling led_trigger_register() for PHYs localted on SFP
> > modules as such modules actually never got any LEDs.
>
> Any suggestion of a Fixes tag?
> Looks like the triggers were added a while back, are we only seeing it
> now because we started exercising the code more?
I've noticed this as a consequence of commit 2f3ce7a56
"net: sfp: rework the RollBall PHY waiting code"
because (?) some PHYs on SFP+ now probe immediately as the previously
enforced minimum delay now became a timeout.
Blaming that commit would be wrong though, it's more that the problem
has probably always been there and was just previously augmented by
the delay.
next prev parent reply other threads:[~2023-12-15 3:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 0:05 [PATCH net] net: phy: skip LED triggers on PHYs on SFP modules Daniel Golle
2023-12-12 14:35 ` Maxime Chevallier
2023-12-13 9:08 ` Andrew Lunn
2023-12-13 10:06 ` Maxime Chevallier
2023-12-13 10:47 ` Andrew Lunn
2023-12-13 15:35 ` Russell King (Oracle)
2023-12-13 15:27 ` Russell King (Oracle)
2023-12-13 17:12 ` Maxime Chevallier
2023-12-13 19:01 ` Daniel Golle
2023-12-13 20:23 ` Russell King (Oracle)
2023-12-14 9:48 ` Paolo Abeni
2023-12-14 16:52 ` Russell King (Oracle)
2023-12-15 9:46 ` Andrew Lunn
2023-12-15 9:59 ` Maxime Chevallier
2023-12-15 15:39 ` Maxime Chevallier
2023-12-15 2:31 ` Jakub Kicinski
2023-12-15 2:54 ` Daniel Golle [this message]
2023-12-15 9:53 ` Andrew Lunn
2023-12-15 16:45 ` Russell King (Oracle)
2023-12-16 2:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXu_3OnSzmLq5GAH@makrotopia.org \
--to=daniel@makrotopia.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).