From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 889CB2DB85; Fri, 15 Dec 2023 13:36:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Tud6o92I" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04C1FC433C8; Fri, 15 Dec 2023 13:36:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702647397; bh=subHRTKMwmMr0u+Qf2RNzCSmCaDcHEzfdzarxtD8z/U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Tud6o92I0jvVdrQ08FGKjdwhC80aUmMEmOH08YZYA7JMT2nqm5k4KKn6vBcUbxJjP VmpYMMCDc/VLLrETSfv2FpWhSRRti1nAMypE+MNbCK/UR8mamGdHErStfqAZXkgaKC qBv5XaksNxAOX6jipIaq1IbmkhKayDCxE6KAcyXAv3QSDdh51sfDh1IcgQiy2tAttY WXgcpMVNiCj3RxJHmQEXR/hTQbtqjFGwwlG5b3BHtjTFBOyuVjwGH1S6sM6UqultwY zXpxq3Nw1vqu3UFHQsvlUnunnipIRRlxvKbgttSUVa1ufg21iJkPpOgtx6sbhdvg9A kjq2BdKV10YQg== Received: from johan by xi.lan with local (Exim 4.96.2) (envelope-from ) id 1rE8Mh-0008LA-2Z; Fri, 15 Dec 2023 14:36:31 +0100 Date: Fri, 15 Dec 2023 14:36:31 +0100 From: Johan Hovold To: Francesco Dolcini , Greg Kroah-Hartman Cc: Jiri Slaby , linux-bluetooth@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, greybus-dev@lists.linaro.org, linux-iio@vger.kernel.org, netdev@vger.kernel.org, chrome-platform@lists.linux.dev, platform-driver-x86@vger.kernel.org, linux-serial@vger.kernel.org, linux-sound@vger.kernel.org, Francesco Dolcini , Luiz Augusto von Dentz , Alex Elder , Jonathan Cameron , Lee Jones , Jakub Kicinski , Paolo Abeni , Eric Dumazet , "David S. Miller" , Krzysztof Kozlowski , Hans de Goede , Ilpo =?utf-8?B?SsOkcnZpbmVu?= , Benson Leung , Tzung-Bi Shih , Rob Herring Subject: Re: [PATCH v1] treewide, serdev: change receive_buf() return type to size_t Message-ID: References: <20231214170146.641783-1-francesco@dolcini.it> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231214170146.641783-1-francesco@dolcini.it> On Thu, Dec 14, 2023 at 06:01:46PM +0100, Francesco Dolcini wrote: > From: Francesco Dolcini > > receive_buf() is called from ttyport_receive_buf() that expects values > ">= 0" from serdev_controller_receive_buf(), change its return type from > ssize_t to size_t. > > Suggested-by: Jiri Slaby > Link: https://lore.kernel.org/all/087be419-ec6b-47ad-851a-5e1e3ea5cfcc@kernel.org/ > Signed-off-by: Francesco Dolcini > --- > drivers/gnss/core.c | 6 +++--- > drivers/gnss/serial.c | 4 ++-- > drivers/gnss/sirf.c | 6 +++--- > diff --git a/drivers/gnss/core.c b/drivers/gnss/core.c > index 48f2ee0f78c4..9b8a0605ec76 100644 > --- a/drivers/gnss/core.c > +++ b/drivers/gnss/core.c > @@ -317,10 +317,10 @@ EXPORT_SYMBOL_GPL(gnss_deregister_device); > * > * Must not be called for a closed device. > */ > -int gnss_insert_raw(struct gnss_device *gdev, const unsigned char *buf, > - size_t count) > +size_t gnss_insert_raw(struct gnss_device *gdev, const unsigned char *buf, > + size_t count) > { > - int ret; > + size_t ret; > > ret = kfifo_in(&gdev->read_fifo, buf, count); > Why are you changing this function? This is part of the GNSS interface and has nothing to do with the rest of this patch. Greg, please drop this one again until this has been resolved. Johan