From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail11.truemail.it (mail11.truemail.it [217.194.8.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 437B63FE55; Fri, 15 Dec 2023 17:07:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dolcini.it Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=dolcini.it Received: from francesco-nb.int.toradex.com (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id ADB5C20640; Fri, 15 Dec 2023 18:07:37 +0100 (CET) Date: Fri, 15 Dec 2023 18:07:33 +0100 From: Francesco Dolcini To: Johan Hovold , Greg Kroah-Hartman Cc: Francesco Dolcini , Jiri Slaby , linux-bluetooth@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, greybus-dev@lists.linaro.org, linux-iio@vger.kernel.org, netdev@vger.kernel.org, chrome-platform@lists.linux.dev, platform-driver-x86@vger.kernel.org, linux-serial@vger.kernel.org, linux-sound@vger.kernel.org, Francesco Dolcini , Luiz Augusto von Dentz , Alex Elder , Jonathan Cameron , Lee Jones , Jakub Kicinski , Paolo Abeni , Eric Dumazet , "David S. Miller" , Krzysztof Kozlowski , Hans de Goede , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , Benson Leung , Tzung-Bi Shih , Rob Herring Subject: Re: [PATCH v1] treewide, serdev: change receive_buf() return type to size_t Message-ID: References: <20231214170146.641783-1-francesco@dolcini.it> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hello Johan, Greg On Fri, Dec 15, 2023 at 05:18:52PM +0100, Johan Hovold wrote: > On Fri, Dec 15, 2023 at 02:55:59PM +0100, Francesco Dolcini wrote: > > To me the change is correct, with that said probably this should have > > been explicitly mentioned in the commit message or a separate > > preparation patch. > > It's a separate change and should not be hidden away in a tree-wide > change that goes through a different maintainer. > > Please drop this change from this patch and resubmit it separately to me > if you want and I'll review when I have the time. Fine, I agree. I see those options (let me know if you see other options I have not mentioned): 1. I add this change (taking into account also intel ice) as a separate patch in this series and you may just ack it and Greg could merge together with the serdev one. 2. I prepare an independent patch for the GNSS change and only once this is merged I'll send a rebased v2 of this one. 3. I update this patch without this GNSS API change, that mean I will have to cast away the signed type from a few GNSS drivers. 1 is my preferred option, 2 is fine, but it seems a little bit of overdoing, 3 I would avoid, we are doing this cleanup to be a little bit more strongly typed and to prevent the kind of bugs that is the original trigger for this patch. What would you Greg and Johan prefer? > And when doing tree-wide changes, please try to follow the style of the > driver you are changing (e.g. do not introduce inconsistencies by > changing to open parenthesis alignment of continuation lines in code > that do not use it). ack, sorry about that, looking back at the archive is seems a recent pain point, also Jiri fell in this trap. Francesco