From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D471101E8; Mon, 18 Dec 2023 08:35:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cqKR6jTw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 14FCAC433C8; Mon, 18 Dec 2023 08:35:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702888506; bh=PvieyW9kHU+3JjdvRizTuAsBF+M7+DN21zt8QD6huP8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cqKR6jTwpmCKyTFqiDsud8Ud91Y2vl0XnJ70WkUUWsejg3N21krgNOC2hGTW6Sr// PkugwCVTKDJbZBbTAjn2pZOtgeXLfIt4KhVQdagYFnoBeWEVHdgSDchIq1/IEoOYgz UPhMPfMZofuUfwXr9yS3PhKhC0IHJypA2VlCOfPMF5X3opuQwu7Tnyq59gPlfhE2L7 BMOT1Z09reyctvlBiTybBEDPjQ60FLqs31RXDW6RG7gr4O0un4ilMkg7Cgrs/fszps ppFsjdnc33uZ69wLfbVJFyRfIMVBseNo/FtnnrcNqwp53jB9iKEBeFsADcFruxnW5a /8S2G6GLNLRGw== Received: from johan by xi.lan with local (Exim 4.96.2) (envelope-from ) id 1rF95c-0003FH-0v; Mon, 18 Dec 2023 09:35:05 +0100 Date: Mon, 18 Dec 2023 09:35:04 +0100 From: Johan Hovold To: Francesco Dolcini Cc: Greg Kroah-Hartman , Jiri Slaby , linux-bluetooth@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, greybus-dev@lists.linaro.org, linux-iio@vger.kernel.org, netdev@vger.kernel.org, chrome-platform@lists.linux.dev, platform-driver-x86@vger.kernel.org, linux-serial@vger.kernel.org, linux-sound@vger.kernel.org, Francesco Dolcini , Luiz Augusto von Dentz , Alex Elder , Jonathan Cameron , Lee Jones , Jakub Kicinski , Paolo Abeni , Eric Dumazet , "David S. Miller" , Krzysztof Kozlowski , Hans de Goede , Ilpo =?utf-8?B?SsOkcnZpbmVu?= , Benson Leung , Tzung-Bi Shih , Rob Herring Subject: Re: [PATCH v1] treewide, serdev: change receive_buf() return type to size_t Message-ID: References: <20231214170146.641783-1-francesco@dolcini.it> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Dec 15, 2023 at 06:07:33PM +0100, Francesco Dolcini wrote: > On Fri, Dec 15, 2023 at 05:18:52PM +0100, Johan Hovold wrote: > > On Fri, Dec 15, 2023 at 02:55:59PM +0100, Francesco Dolcini wrote: > > > To me the change is correct, with that said probably this should have > > > been explicitly mentioned in the commit message or a separate > > > preparation patch. > > > > It's a separate change and should not be hidden away in a tree-wide > > change that goes through a different maintainer. > > > > Please drop this change from this patch and resubmit it separately to me > > if you want and I'll review when I have the time. > > Fine, I agree. > > I see those options (let me know if you see other options I have not > mentioned): > > 1. I add this change (taking into account also intel ice) as a separate > patch in this series and you may just ack it and Greg could merge > together with the serdev one. > 2. I prepare an independent patch for the GNSS change and only once this > is merged I'll send a rebased v2 of this one. > 3. I update this patch without this GNSS API change, that mean I will > have to cast away the signed type from a few GNSS drivers. > > 1 is my preferred option, 2 is fine, but it seems a little bit of overdoing, > 3 I would avoid, we are doing this cleanup to be a little bit more > strongly typed and to prevent the kind of bugs that is the original trigger > for this patch. Changing the return type of gnss_insert_raw() is going to be a bit more involved and should be done in a separate patch (e.g. you need to look at gnss_usb_rx_complete() and ice_gnss_read() to avoid introducing new warnings there). And both option 2 and 3 will introduce conversion warnings (W=3, which we have plenty of anyway) unless you add casts. I suggest you go with 3, unless you insist on 2. Johan