From: Hangbin Liu <liuhangbin@gmail.com>
To: Dmitry Safonov <dima@arista.com>
Cc: Shuah Khan <shuah@kernel.org>, David Ahern <dsahern@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Salam Noureddine <noureddine@arista.com>,
Bob Gilligan <gilligan@arista.com>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
netdev@vger.kernel.org, Dmitry Safonov <0x7f454c46@gmail.com>
Subject: Re: [PATCH 03/12] selftests/net: Add TCP-AO ICMPs accept test
Date: Mon, 18 Dec 2023 17:04:41 +0800 [thread overview]
Message-ID: <ZYALKQGYuRrpOo_A@Laptop-X1> (raw)
In-Reply-To: <20231215-tcp-ao-selftests-v1-3-f6c08180b985@arista.com>
On Fri, Dec 15, 2023 at 02:36:17AM +0000, Dmitry Safonov wrote:
> Reverse to icmps-discard test: the server accepts ICMPs, using
> TCP_AO_CMDF_ACCEPT_ICMP and it is expected to fail under ICMP
> flood from client. Test that the default pre-TCP-AO behaviour functions
> when TCP_AO_CMDF_ACCEPT_ICMP is set.
>
> Expected output for ipv4 version (in case it receives ICMP_PROT_UNREACH):
> > # ./icmps-accept_ipv4
> > 1..3
> > # 3209[lib/setup.c:166] rand seed 1642623870
> > TAP version 13
> > # 3209[lib/proc.c:207] Snmp6 Ip6InReceives: 0 => 1
> > # 3209[lib/proc.c:207] Snmp6 Ip6InNoRoutes: 0 => 1
> > # 3209[lib/proc.c:207] Snmp6 Ip6InOctets: 0 => 76
> > # 3209[lib/proc.c:207] Snmp6 Ip6InNoECTPkts: 0 => 1
> > # 3209[lib/proc.c:207] Tcp InSegs: 3 => 23
> > # 3209[lib/proc.c:207] Tcp OutSegs: 2 => 22
> > # 3209[lib/proc.c:207] IcmpMsg InType3: 0 => 4
> > # 3209[lib/proc.c:207] Icmp InMsgs: 0 => 4
> > # 3209[lib/proc.c:207] Icmp InDestUnreachs: 0 => 4
> > # 3209[lib/proc.c:207] Ip InReceives: 3 => 27
> > # 3209[lib/proc.c:207] Ip InDelivers: 3 => 27
> > # 3209[lib/proc.c:207] Ip OutRequests: 2 => 22
> > # 3209[lib/proc.c:207] IpExt InOctets: 288 => 3420
> > # 3209[lib/proc.c:207] IpExt OutOctets: 124 => 3244
> > # 3209[lib/proc.c:207] IpExt InNoECTPkts: 3 => 25
> > # 3209[lib/proc.c:207] TcpExt TCPPureAcks: 1 => 2
> > # 3209[lib/proc.c:207] TcpExt TCPOrigDataSent: 0 => 20
> > # 3209[lib/proc.c:207] TcpExt TCPDelivered: 0 => 19
> > # 3209[lib/proc.c:207] TcpExt TCPAOGood: 3 => 23
> > ok 1 InDestUnreachs delivered 4
> > ok 2 server failed with -92: Protocol not available
> > ok 3 TCPAODroppedIcmps counter didn't change: 0 >= 0
> > # Totals: pass:3 fail:0 xfail:0 xpass:0 skip:0 error:0
>
> Expected output for ipv6 version (in case it receives ADM_PROHIBITED):
> > # ./icmps-accept_ipv6
> > 1..3
> > # 3277[lib/setup.c:166] rand seed 1642624035
> > TAP version 13
> > # 3277[lib/proc.c:207] Snmp6 Ip6InReceives: 6 => 31
> > # 3277[lib/proc.c:207] Snmp6 Ip6InDelivers: 4 => 29
> > # 3277[lib/proc.c:207] Snmp6 Ip6OutRequests: 4 => 24
> > # 3277[lib/proc.c:207] Snmp6 Ip6InOctets: 592 => 4492
> > # 3277[lib/proc.c:207] Snmp6 Ip6OutOctets: 332 => 3852
> > # 3277[lib/proc.c:207] Snmp6 Ip6InNoECTPkts: 6 => 31
> > # 3277[lib/proc.c:207] Snmp6 Icmp6InMsgs: 1 => 6
> > # 3277[lib/proc.c:207] Snmp6 Icmp6InDestUnreachs: 0 => 5
> > # 3277[lib/proc.c:207] Snmp6 Icmp6InType1: 0 => 5
> > # 3277[lib/proc.c:207] Tcp InSegs: 3 => 23
> > # 3277[lib/proc.c:207] Tcp OutSegs: 2 => 22
> > # 3277[lib/proc.c:207] TcpExt TCPPureAcks: 1 => 2
> > # 3277[lib/proc.c:207] TcpExt TCPOrigDataSent: 0 => 20
> > # 3277[lib/proc.c:207] TcpExt TCPDelivered: 0 => 19
> > # 3277[lib/proc.c:207] TcpExt TCPAOGood: 3 => 23
> > ok 1 Icmp6InDestUnreachs delivered 5
> > ok 2 server failed with -13: Permission denied
> > ok 3 TCPAODroppedIcmps counter didn't change: 0 >= 0
> > # Totals: pass:3 fail:0 xfail:0 xpass:0 skip:0 error:0
>
> With some luck the server may fail with ECONNREFUSED (depending on what
> icmp packet was delivered firstly).
> For the kernel error handlers see: tab_unreach[] and icmp_err_convert[].
>
> Signed-off-by: Dmitry Safonov <dima@arista.com>
Tested-by: Hangbin Liu <liuhangbin@gmail.com>
next prev parent reply other threads:[~2023-12-18 9:04 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 2:36 [PATCH 00/12] selftests/net: Add TCP-AO tests Dmitry Safonov
2023-12-15 2:36 ` [PATCH 01/12] selftests/net: Add TCP-AO library Dmitry Safonov
2024-01-12 18:02 ` Nassiri, Mohammad
2023-12-15 2:36 ` [PATCH 02/12] selftests/net: Verify that TCP-AO complies with ignoring ICMPs Dmitry Safonov
2023-12-18 9:03 ` Hangbin Liu
2023-12-15 2:36 ` [PATCH 03/12] selftests/net: Add TCP-AO ICMPs accept test Dmitry Safonov
2023-12-18 9:04 ` Hangbin Liu [this message]
2023-12-15 2:36 ` [PATCH 04/12] selftests/net: Add a test for TCP-AO keys matching Dmitry Safonov
2023-12-18 9:05 ` Hangbin Liu
2023-12-15 2:36 ` [PATCH 05/12] selftests/net: Add test for TCP-AO add setsockopt() command Dmitry Safonov
2023-12-18 9:06 ` Hangbin Liu
2023-12-15 2:36 ` [PATCH 06/12] selftests/net: Add TCP-AO + TCP-MD5 + no sign listen socket tests Dmitry Safonov
2023-12-18 9:08 ` Hangbin Liu
2023-12-15 2:36 ` [PATCH 07/12] selftests/net: Add test/benchmark for removing MKTs Dmitry Safonov
2023-12-18 9:09 ` Hangbin Liu
2023-12-15 2:36 ` [PATCH 08/12] selftests/net: Add TCP_REPAIR TCP-AO tests Dmitry Safonov
2023-12-18 9:10 ` Hangbin Liu
2023-12-15 2:36 ` [PATCH 09/12] selftests/net: Add SEQ number extension test Dmitry Safonov
2023-12-18 9:11 ` Hangbin Liu
2023-12-15 2:36 ` [PATCH 10/12] selftests/net: Add TCP-AO RST test Dmitry Safonov
2023-12-18 9:11 ` Hangbin Liu
2023-12-15 2:36 ` [PATCH 11/12] selftests/net: Add TCP-AO selfconnect/simultaneous connect test Dmitry Safonov
2023-12-18 9:12 ` Hangbin Liu
2023-12-15 2:36 ` [PATCH 12/12] selftests/net: Add TCP-AO key-management test Dmitry Safonov
2024-01-12 18:57 ` Nassiri, Mohammad
2024-01-15 18:05 ` Dmitry Safonov
2024-01-15 22:26 ` Nassiri, Mohammad
2023-12-18 9:36 ` [PATCH 00/12] selftests/net: Add TCP-AO tests Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZYALKQGYuRrpOo_A@Laptop-X1 \
--to=liuhangbin@gmail.com \
--cc=0x7f454c46@gmail.com \
--cc=davem@davemloft.net \
--cc=dima@arista.com \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=gilligan@arista.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=noureddine@arista.com \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).