From: Ido Schimmel <idosch@nvidia.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: netdev@vger.kernel.org, mptcp@lists.linux.dev,
davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, nhorman@tuxdriver.com, matttbe@kernel.org,
martineau@kernel.org, yotam.gi@gmail.com, jiri@resnulli.us,
jacob.e.keller@intel.com, johannes@sipsolutions.net,
fw@strlen.de
Subject: Re: [PATCH net-next] genetlink: Use internal flags for multicast groups
Date: Mon, 18 Dec 2023 18:31:10 +0200 [thread overview]
Message-ID: <ZYBzzsZfUOkXGdpI@shredder> (raw)
In-Reply-To: <ZYAvBdhiAnR9dIi3@smile.fi.intel.com>
On Mon, Dec 18, 2023 at 01:37:41PM +0200, Andy Shevchenko wrote:
> No functional, but documentation changes...
>
> So, I suggest to have these flags being described
>
> /* ... */
> #define FLAG1
>
> /* ... */
> #define FLAG2
OK, thanks. I will squash the following diff into v2:
diff --git a/include/net/genetlink.h b/include/net/genetlink.h
index 5a402fd24817..bd6a6ffdec76 100644
--- a/include/net/genetlink.h
+++ b/include/net/genetlink.h
@@ -8,7 +8,9 @@
#define GENLMSG_DEFAULT_SIZE (NLMSG_DEFAULT_SIZE - GENL_HDRLEN)
+/* Binding to multicast group requires %CAP_NET_ADMIN */
#define GENL_MCAST_CAP_NET_ADMIN BIT(0)
+/* Binding to multicast group requires %CAP_SYS_ADMIN */
#define GENL_MCAST_CAP_SYS_ADMIN BIT(1)
/**
prev parent reply other threads:[~2023-12-18 16:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-17 7:53 [PATCH net-next] genetlink: Use internal flags for multicast groups Ido Schimmel
2023-12-18 11:37 ` Andy Shevchenko
2023-12-18 16:31 ` Ido Schimmel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZYBzzsZfUOkXGdpI@shredder \
--to=idosch@nvidia.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=jacob.e.keller@intel.com \
--cc=jiri@resnulli.us \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=martineau@kernel.org \
--cc=matttbe@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=pabeni@redhat.com \
--cc=yotam.gi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox