From: Hangbin Liu <liuhangbin@gmail.com>
To: Yujie Liu <yujie.liu@intel.com>
Cc: netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
David Ahern <dsahern@kernel.org>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
lkp@intel.com, kernel test robot <oliver.sang@intel.com>
Subject: Re: [PATCH net-next] selftests/net: change the shebang of unicast_extensions.sh to bash
Date: Mon, 25 Dec 2023 20:39:09 +0800 [thread overview]
Message-ID: <ZYl37fnxGGop7VCs@Laptop-X1> (raw)
In-Reply-To: <20231225072109.3835503-1-yujie.liu@intel.com>
On Mon, Dec 25, 2023 at 03:21:09PM +0800, Yujie Liu wrote:
> The patch set [1] added a general lib.sh in net selftests, and converted
> several test scripts to source the lib.sh.
Oh, I didn't know dash doesn't support "source". Thanks for the fix.
Would you please also help fix the pmtu.sh, which has the same issue?
BTW, you can change the "source ./lib.sh" to "source lib.sh" to consistent
with other tests.
Thanks
Hangbin
next prev parent reply other threads:[~2023-12-25 12:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-25 7:21 [PATCH net-next] selftests/net: change the shebang of unicast_extensions.sh to bash Yujie Liu
2023-12-25 12:39 ` Hangbin Liu [this message]
2023-12-26 8:43 ` Yujie Liu
2023-12-26 12:51 ` Hangbin Liu
2023-12-29 13:34 ` Yujie Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZYl37fnxGGop7VCs@Laptop-X1 \
--to=liuhangbin@gmail.com \
--cc=dsahern@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=oliver.sang@intel.com \
--cc=pabeni@redhat.com \
--cc=yujie.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).