From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 054578F51 for ; Sun, 31 Dec 2023 16:27:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="S/LJlL9G" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704040030; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=W9SZrZXQYhT7Sd91knQv7PNkQL8oY2rRS96yOdxg1Q0=; b=S/LJlL9G3DfwM0H3JBNqcgPWmcb5rr/VVagu6SYe1czGI+GWzXbpvCSD5qxew6QgeYkJap tULIuUP3WlRnZJErv7dZVISBpYXHDmzM6lykv5FlVZFcZVIMpmYbWWAyT9l6Cz/5vtNXYy N7PTWnqZCXI+WSbjvmuKDGmNx5dW8xc= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-652-TvlHsaIDPZGZH2wIyrv5iQ-1; Sun, 31 Dec 2023 11:27:08 -0500 X-MC-Unique: TvlHsaIDPZGZH2wIyrv5iQ-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-40d2a286757so49267565e9.1 for ; Sun, 31 Dec 2023 08:27:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704040027; x=1704644827; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=W9SZrZXQYhT7Sd91knQv7PNkQL8oY2rRS96yOdxg1Q0=; b=XJJQSKJorVDl6kUHLSV9fnmmR6Z+5yekLaWT8QKBfPmKak2kDeUUpWAgvAED0ZO5ah o+69PanqMrn6cr54yQG2oS65EAG+NAH2m6Wi3aowW1TSFAsmKsvFZBnhYKt4XQDp3pv1 uEa8bcLpYK6+JoLdam0jpKcCH4pEXSxZl7gYRwjL2/CkOQNWcpK8N4dCIqtqSdrDWcUv G3VeC1AI8JZYA3IAA4lhwTlggtlB7vREQXBAJyRScSLF+jD4P6t70c3uBzkGOwwe+zAq 9n52IhSbb3/btIsyENBK0RMAt6CY3sx9AuZPy0uu21xeltZlamVz2OGIojFWrK4rv0pj sVZg== X-Gm-Message-State: AOJu0YwF52s+dgKZQejG2gjuVhOe5RtR8WJ391cLJIS7ow8AG9TuDQjJ PkCOqde2o8sbRk0pGyZNkk37cOJDCBpZHKj+vGuq/8BDkBmZe7NSZKMXuR4pQZqIUeNV6c7fnO7 UJAp8By3phWHa4tDev1/sp0r0 X-Received: by 2002:a05:600c:1383:b0:40d:628a:1229 with SMTP id u3-20020a05600c138300b0040d628a1229mr2894703wmf.96.1704040027752; Sun, 31 Dec 2023 08:27:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IG9b93ScSUl7ZhuJmGttFNJHej7gGjBgYPQSNbx8GJYzHGFQpUOA9OuiE3Dj4nmpqxVpP6n0g== X-Received: by 2002:a05:600c:1383:b0:40d:628a:1229 with SMTP id u3-20020a05600c138300b0040d628a1229mr2894699wmf.96.1704040027489; Sun, 31 Dec 2023 08:27:07 -0800 (PST) Received: from debian (2a01cb058918ce00b14e8593d3a1c390.ipv6.abo.wanadoo.fr. [2a01:cb05:8918:ce00:b14e:8593:d3a1:c390]) by smtp.gmail.com with ESMTPSA id w5-20020a5d5445000000b0033660f75d08sm23926474wrv.116.2023.12.31.08.27.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 31 Dec 2023 08:27:06 -0800 (PST) Date: Sun, 31 Dec 2023 17:27:05 +0100 From: Guillaume Nault To: Yujie Liu Cc: netdev@vger.kernel.org, Hangbin Liu , Paolo Abeni , David Ahern , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, lkp@intel.com, kernel test robot Subject: Re: [PATCH v2 net-next] selftests/net: change shebang to bash to support "source" Message-ID: References: <20231229131931.3961150-1-yujie.liu@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231229131931.3961150-1-yujie.liu@intel.com> On Fri, Dec 29, 2023 at 09:19:31PM +0800, Yujie Liu wrote: > The patch set [1] added a general lib.sh in net selftests, and converted > several test scripts to source the lib.sh. > > unicast_extensions.sh (converted in [1]) and pmtu.sh (converted in [2]) > have a /bin/sh shebang which may point to various shells in different > distributions, but "source" is only available in some of them. For > example, "source" is a built-it function in bash, but it cannot be > used in dash. > > Refer to other scripts that were converted together, simply change the > shebang to bash to fix the following issues when the default /bin/sh > points to other shells. > > # selftests: net: unicast_extensions.sh > # ./unicast_extensions.sh: 31: source: not found > # ########################################################################### > # Unicast address extensions tests (behavior of reserved IPv4 addresses) > # ########################################################################### > # TEST: assign and ping within 240/4 (1 of 2) (is allowed) [FAIL] > # TEST: assign and ping within 240/4 (2 of 2) (is allowed) [FAIL] > # TEST: assign and ping within 0/8 (1 of 2) (is allowed) [FAIL] > # TEST: assign and ping within 0/8 (2 of 2) (is allowed) [FAIL] > # TEST: assign and ping inside 255.255/16 (is allowed) [FAIL] > # TEST: assign and ping inside 255.255.255/24 (is allowed) [FAIL] > # TEST: route between 240.5.6/24 and 255.1.2/24 (is allowed) [FAIL] > # TEST: route between 0.200/16 and 245.99/16 (is allowed) [FAIL] > # TEST: assign and ping lowest address (/24) [FAIL] > # TEST: assign and ping lowest address (/26) [FAIL] > # TEST: routing using lowest address [FAIL] > # TEST: assigning 0.0.0.0 (is forbidden) [ OK ] > # TEST: assigning 255.255.255.255 (is forbidden) [ OK ] > # TEST: assign and ping inside 127/8 (is forbidden) [ OK ] > # TEST: assign and ping class D address (is forbidden) [ OK ] > # TEST: routing using class D (is forbidden) [ OK ] > # TEST: routing using 127/8 (is forbidden) [ OK ] > not ok 51 selftests: net: unicast_extensions.sh # exit=1 > > v1 -> v2: > - Fix pmtu.sh which has the same issue as unicast_extensions.sh, > suggested by Hangbin > - Change the style of the "source" line to be consistent with other > tests, suggested by Hangbin > > Link: https://lore.kernel.org/all/20231202020110.362433-1-liuhangbin@gmail.com/ [1] > Link: https://lore.kernel.org/all/20231219094856.1740079-1-liuhangbin@gmail.com/ [2] Also, please add the missing Fixes tags. > Reported-by: kernel test robot > Signed-off-by: Yujie Liu