From: Hangbin Liu <liuhangbin@gmail.com>
To: Yujie Liu <yujie.liu@intel.com>
Cc: Guillaume Nault <gnault@redhat.com>,
netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
David Ahern <dsahern@kernel.org>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
lkp@intel.com, kernel test robot <oliver.sang@intel.com>
Subject: Re: [PATCH v2 net-next] selftests/net: change shebang to bash to support "source"
Date: Tue, 2 Jan 2024 14:51:00 +0800 [thread overview]
Message-ID: <ZZOyVGQ7U3K16wHr@Laptop-X1> (raw)
In-Reply-To: <ZZOkfPgs6T3ujpJo@yujie-X299>
On Tue, Jan 02, 2024 at 01:51:56PM +0800, Yujie Liu wrote:
> > Looks like it'd be simpler to just replace the "source" commands with
> > "." and leave the shebang as is (unless there are other bash-specific
> > constructs in these scripts of course).
> >
> > Generally speaking, I think we should avoid madating a specific shell,
> > unless that really simplifies the test script (which is not the case
> > here).
>
> Hi Guillaume,
>
> Thanks for the comments. As this is related with a large patch series from
> Hangbin, and other scripts use "source" during the conversion, so we may
> need some input from Hangbin.
>
> Hi Hangbin,
>
> Could you please share your comments on this? Would you like to replace
> "source" with "." for these two specific scripts as Guillaume suggested,
> or change the shebang from "sh" to "bash"?
Both works for me :)
Thanks
Hangbin
next prev parent reply other threads:[~2024-01-02 6:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-29 13:19 [PATCH v2 net-next] selftests/net: change shebang to bash to support "source" Yujie Liu
2023-12-29 15:19 ` Przemek Kitszel
2023-12-30 6:20 ` Hangbin Liu
2023-12-30 6:30 ` Muhammad Usama Anjum
2023-12-31 12:17 ` Guillaume Nault
2024-01-02 5:51 ` Yujie Liu
2024-01-02 6:51 ` Hangbin Liu [this message]
2024-01-02 8:20 ` Yujie Liu
2024-01-02 11:32 ` Guillaume Nault
2023-12-31 16:27 ` Guillaume Nault
2024-01-04 1:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZZOyVGQ7U3K16wHr@Laptop-X1 \
--to=liuhangbin@gmail.com \
--cc=dsahern@kernel.org \
--cc=gnault@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=oliver.sang@intel.com \
--cc=pabeni@redhat.com \
--cc=yujie.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).