* [net-next: PATCH] net: mvpp2: initialize port fwnode pointer
@ 2023-12-31 12:20 Marcin Wojtas
2024-01-02 6:35 ` [EXT] " Suman Ghosh
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Marcin Wojtas @ 2023-12-31 12:20 UTC (permalink / raw)
To: linux-kernel, netdev
Cc: andriy.shevchenko, olteanv, davem, edumazet, kuba, linux,
Marcin Wojtas
Update the port's device structure also with its fwnode pointer
with a recommended device_set_node() helper routine.
Signed-off-by: Marcin Wojtas <marcin.s.wojtas@gmail.com>
---
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
index 1ca273f17d29..820b1fabe297 100644
--- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
+++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
@@ -6877,7 +6877,7 @@ static int mvpp2_port_probe(struct platform_device *pdev,
dev->min_mtu = ETH_MIN_MTU;
/* 9704 == 9728 - 20 and rounding to 8 */
dev->max_mtu = MVPP2_BM_JUMBO_PKT_SIZE;
- dev->dev.of_node = port_node;
+ device_set_node(&dev->dev, port_fwnode);
port->pcs_gmac.ops = &mvpp2_phylink_gmac_pcs_ops;
port->pcs_gmac.neg_mode = true;
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* RE: [EXT] [net-next: PATCH] net: mvpp2: initialize port fwnode pointer
2023-12-31 12:20 [net-next: PATCH] net: mvpp2: initialize port fwnode pointer Marcin Wojtas
@ 2024-01-02 6:35 ` Suman Ghosh
2024-01-02 12:03 ` Russell King (Oracle)
2024-01-04 1:00 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Suman Ghosh @ 2024-01-02 6:35 UTC (permalink / raw)
To: Marcin Wojtas, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Cc: andriy.shevchenko@linux.intel.com, olteanv@gmail.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
linux@armlinux.org.uk
Looks good to me.
>----------------------------------------------------------------------
>Update the port's device structure also with its fwnode pointer with a
>recommended device_set_node() helper routine.
>
>Signed-off-by: Marcin Wojtas <marcin.s.wojtas@gmail.com>
[Suman] Reviewed-by: Suman Ghosh <sumang@marvell.com>
>---
> drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
>b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
>index 1ca273f17d29..820b1fabe297 100644
>--- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
>+++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
>@@ -6877,7 +6877,7 @@ static int mvpp2_port_probe(struct platform_device
>*pdev,
> dev->min_mtu = ETH_MIN_MTU;
> /* 9704 == 9728 - 20 and rounding to 8 */
> dev->max_mtu = MVPP2_BM_JUMBO_PKT_SIZE;
>- dev->dev.of_node = port_node;
>+ device_set_node(&dev->dev, port_fwnode);
>
> port->pcs_gmac.ops = &mvpp2_phylink_gmac_pcs_ops;
> port->pcs_gmac.neg_mode = true;
>--
>2.34.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [net-next: PATCH] net: mvpp2: initialize port fwnode pointer
2023-12-31 12:20 [net-next: PATCH] net: mvpp2: initialize port fwnode pointer Marcin Wojtas
2024-01-02 6:35 ` [EXT] " Suman Ghosh
@ 2024-01-02 12:03 ` Russell King (Oracle)
2024-01-04 1:00 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Russell King (Oracle) @ 2024-01-02 12:03 UTC (permalink / raw)
To: Marcin Wojtas
Cc: linux-kernel, netdev, andriy.shevchenko, olteanv, davem, edumazet,
kuba
On Sun, Dec 31, 2023 at 12:20:19PM +0000, Marcin Wojtas wrote:
> Update the port's device structure also with its fwnode pointer
> with a recommended device_set_node() helper routine.
>
> Signed-off-by: Marcin Wojtas <marcin.s.wojtas@gmail.com>
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Thanks!
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [net-next: PATCH] net: mvpp2: initialize port fwnode pointer
2023-12-31 12:20 [net-next: PATCH] net: mvpp2: initialize port fwnode pointer Marcin Wojtas
2024-01-02 6:35 ` [EXT] " Suman Ghosh
2024-01-02 12:03 ` Russell King (Oracle)
@ 2024-01-04 1:00 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-01-04 1:00 UTC (permalink / raw)
To: Marcin Wojtas
Cc: linux-kernel, netdev, andriy.shevchenko, olteanv, davem, edumazet,
kuba, linux
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Sun, 31 Dec 2023 12:20:19 +0000 you wrote:
> Update the port's device structure also with its fwnode pointer
> with a recommended device_set_node() helper routine.
>
> Signed-off-by: Marcin Wojtas <marcin.s.wojtas@gmail.com>
> ---
> drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- [net-next:] net: mvpp2: initialize port fwnode pointer
https://git.kernel.org/netdev/net-next/c/5fe65375e3d4
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-01-04 1:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-31 12:20 [net-next: PATCH] net: mvpp2: initialize port fwnode pointer Marcin Wojtas
2024-01-02 6:35 ` [EXT] " Suman Ghosh
2024-01-02 12:03 ` Russell King (Oracle)
2024-01-04 1:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).