From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D7A7DDA7; Tue, 2 Jan 2024 10:53:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="Py2XMqE5" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=P7Jb3mDo49MLacBnG7AhGIaZNuCuPSYfPQElZXHcOe0=; b=Py2XMqE5fjChLA604/A9Yo5eia YtalWfuwqCLpnFPfAzizPcxQ0u644zIM9Amhtnf4f9E3xu/MAtqMKlR5altz5yJXHjvYW1XQ4SWHz T+TeuKNzCNdytlJSP6fUVyMgG4xEilF8CruX68mHGG3zXKRanBXI94KIB0xZL/Gl5AhR8okC0oU/1 LHgxJDcQGYD8n/6p9HXtcVt2J/0uLQaEsKYEFwqzMritPeWnY0gXFhu91P3YhrDsfoDhZ7CZv0vgU /Fhu9w8WmyQIu+K/BXX9gM0LoXNJnz1CVTXP4KwZPF/p9+QWTc4bhaNpAbLAweNzXcUDaaQ9WsDu0 9LOUnvqw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:44170) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rKcOs-0006Pl-1d; Tue, 02 Jan 2024 10:53:34 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1rKcOu-0005Ci-4w; Tue, 02 Jan 2024 10:53:36 +0000 Date: Tue, 2 Jan 2024 10:53:36 +0000 From: "Russell King (Oracle)" To: Christian Marangi Cc: Andrew Lunn , Heiner Kallweit , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [net-next PATCH v2] net: phy: at803x: better align function varibles to open parenthesis Message-ID: References: <20231219202124.30013-1-ansuelsmth@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231219202124.30013-1-ansuelsmth@gmail.com> Sender: Russell King (Oracle) On Tue, Dec 19, 2023 at 09:21:24PM +0100, Christian Marangi wrote: > Better align function variables to open parenthesis as suggested by > checkpatch script for qca808x function to make code cleaner. > > For cable_test_get_status function some additional rework was needed to > handle too long functions. > > Signed-off-by: Christian Marangi > --- > Changes v2: > - Add an additional fixup for qca808x_is_prefer_master Just found v2... see my comments on v1. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!