public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Hangbin Liu <liuhangbin@gmail.com>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: "David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Eric Dumazet <edumazet@google.com>, Phil Sutter <phil@nwl.cc>,
	David Ahern <dsahern@kernel.org>,
	netdev@vger.kernel.org
Subject: Re: [PATCH net v3 2/2] selftests: rtnetlink: check enslaving iface in a bond
Date: Fri, 5 Jan 2024 10:26:11 +0800	[thread overview]
Message-ID: <ZZdow05irUiN1c8x@Laptop-X1> (raw)
In-Reply-To: <20240104164300.3870209-3-nicolas.dichtel@6wind.com>

On Thu, Jan 04, 2024 at 05:43:00PM +0100, Nicolas Dichtel wrote:
> +kci_test_enslave_bonding()
> +{
> +	local testns="testns"
> +	local bond="bond123"
> +	local dummy="dummy123"
> +	local ret=0
> +
> +	run_cmd ip netns add "$testns"
> +	if [ $? -ne 0 ]; then
> +		end_test "SKIP bonding tests: cannot add net namespace $testns"
> +		return $ksft_skip
> +	fi
> +
> +	# test native tunnel
> +	run_cmd ip -netns $testns link add dev $bond type bond mode balance-rr

Hi Nicolas,

If you are going to target the patch to net-next. Please update it in the
subject. And use `setup_ns` when create new netns.

Thanks
Hangbin

  reply	other threads:[~2024-01-05  2:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-04 16:42 [PATCH net v3 0/2] rtnetlink: allow to enslave with one msg an up interface Nicolas Dichtel
2024-01-04 16:42 ` [PATCH net v3 1/2] rtnetlink: allow to set iface down before enslaving it Nicolas Dichtel
2024-01-05 11:59   ` Jiri Pirko
2024-01-05 16:22     ` Nicolas Dichtel
2024-01-06  3:32     ` Phil Sutter
2024-01-06 11:08       ` Jiri Pirko
2024-01-04 16:43 ` [PATCH net v3 2/2] selftests: rtnetlink: check enslaving iface in a bond Nicolas Dichtel
2024-01-05  2:26   ` Hangbin Liu [this message]
2024-01-05 10:48     ` Nicolas Dichtel
2024-01-05 23:45       ` Hangbin Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZZdow05irUiN1c8x@Laptop-X1 \
    --to=liuhangbin@gmail.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.dichtel@6wind.com \
    --cc=pabeni@redhat.com \
    --cc=phil@nwl.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox