From: Jiri Pirko <jiri@resnulli.us>
To: Jijie Shao <shaojijie@huawei.com>
Cc: yisen.zhuang@huawei.com, salil.mehta@huawei.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, horms@kernel.org, shenjian15@huawei.com,
wangjie125@huawei.com, liuyonglong@huawei.com, lanhao@huawei.com,
wangpeiyang1@huawei.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V4 net-next 1/4] net: hns3: add command queue trace for hns3
Date: Fri, 5 Jan 2024 10:52:19 +0100 [thread overview]
Message-ID: <ZZfRU3QyRIUUUbRi@nanopsycho> (raw)
In-Reply-To: <20240105010119.2619873-2-shaojijie@huawei.com>
Fri, Jan 05, 2024 at 02:01:16AM CET, shaojijie@huawei.com wrote:
>From: Hao Lan <lanhao@huawei.com>
>
>Currently, the hns3 driver does not have the trace
>of the command queue. As a result, it is difficult to
>locate the communication between the driver and firmware.
>Therefore, the trace function of the command queue is
>added in this test case to facilitate the locating of
>communication problems between the driver and firmware.
Use imperative mood in the patch desctiption so it is clear what is the
intention of the patch:
https://www.kernel.org/doc/html/v6.6/process/submitting-patches.html#describe-your-changes
next prev parent reply other threads:[~2024-01-05 9:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-05 1:01 [PATCH V4 net-next 0/4] There are some features for the HNS3 ethernet driver Jijie Shao
2024-01-05 1:01 ` [PATCH V4 net-next 1/4] net: hns3: add command queue trace for hns3 Jijie Shao
2024-01-05 9:52 ` Jiri Pirko [this message]
2024-01-09 8:19 ` Jijie Shao
2024-01-05 1:01 ` [PATCH V4 net-next 2/4] net: hns3: move constants from hclge_debugfs.h to hclge_debugfs.c Jijie Shao
2024-01-05 1:01 ` [PATCH V4 net-next 3/4] net: hns3: dump more reg info based on ras mod Jijie Shao
2024-01-05 1:01 ` [PATCH V4 net-next 4/4] net: hns3: support dump pfc frame statistics in tx timeout log Jijie Shao
2024-01-05 9:55 ` Jiri Pirko
2024-01-09 8:19 ` Jijie Shao
2024-01-09 9:00 ` Jiri Pirko
2024-01-05 9:50 ` [PATCH V4 net-next 0/4] There are some features for the HNS3 ethernet driver Jiri Pirko
2024-01-09 8:20 ` Jijie Shao
-- strict thread matches above, loose matches on Subject: below --
2023-12-19 1:35 Jijie Shao
2023-12-19 1:35 ` [PATCH V4 net-next 1/4] net: hns3: add command queue trace for hns3 Jijie Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZZfRU3QyRIUUUbRi@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=lanhao@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyonglong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=salil.mehta@huawei.com \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
--cc=wangjie125@huawei.com \
--cc=wangpeiyang1@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).