Netdev List
 help / color / mirror / Atom feed
From: Hangbin Liu <liuhangbin@gmail.com>
To: Mirsad Todorovac <mirsad.todorovac@alu.unizg.hr>
Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Shuah Khan <shuah@kernel.org>, David Ahern <dsahern@kernel.org>
Subject: Re: [PATCH v1 1/1] selftests: net: increase timeout value for tests
Date: Sun, 7 Jan 2024 20:49:52 +0800	[thread overview]
Message-ID: <ZZqd8PqvHlYCqbMX@Laptop-X1> (raw)
In-Reply-To: <20240107003929.891669-1-mirsad.todorovac@alu.unizg.hr>

On Sun, Jan 07, 2024 at 01:39:29AM +0100, Mirsad Todorovac wrote:
> In particular, fcnal-test.sh timed out on slower hardware after
> some new permutations of tests were added.
> 
> This single test ran for almost an hour instead of the expected
> 25 min (1500s). 75 minutes should suffice for most systems.
> 
> Cc: David Ahern <dsahern@kernel.org>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Cc: Shuah Khan <shuah@kernel.org>
> Cc: netdev@vger.kernel.org
> Cc: linux-kselftest@vger.kernel.org
> Signed-off-by: Mirsad Todorovac <mirsad.todorovac@alu.unizg.hr>
> ---
>  tools/testing/selftests/net/settings | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/net/settings b/tools/testing/selftests/net/settings
> index dfc27cdc6c05..ed8418e8217a 100644
> --- a/tools/testing/selftests/net/settings
> +++ b/tools/testing/selftests/net/settings
> @@ -1 +1 @@
> -timeout=1500
> +timeout=4500
> -- 
> 2.40.1
> 

FYI, the net-next patch 779283b7770f ("selftests/net: convert fcnal-test.sh
to run it in unique namespace") has extended the timeout to 3600s.

Thanks
Hangbin

  reply	other threads:[~2024-01-07 12:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-07  0:39 [PATCH v1 1/1] selftests: net: increase timeout value for tests Mirsad Todorovac
2024-01-07 12:49 ` Hangbin Liu [this message]
2024-01-07 15:22   ` Mirsad Todorovac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZZqd8PqvHlYCqbMX@Laptop-X1 \
    --to=liuhangbin@gmail.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mirsad.todorovac@alu.unizg.hr \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox