* [PATCH net-next] rxrpc: rxgk: Set error code in rxgk_yfs_decode_ticket()
@ 2025-04-16 11:09 Dan Carpenter
2025-04-18 17:00 ` Simon Horman
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2025-04-16 11:09 UTC (permalink / raw)
To: David Howells
Cc: Marc Dionne, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Simon Horman, linux-afs, netdev, linux-kernel,
kernel-janitors
Propagate the error code if key_alloc() fails. Don't return
success.
Fixes: 9d1d2b59341f ("rxrpc: rxgk: Implement the yfs-rxgk security class (GSSAPI)")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
It's not totally clear if these patch prefixes are real things or just
a cat walking across the keyboard. "rxrxpc: gk: yfs-rxgk" Really?
We expect people to believe these are real?
---
net/rxrpc/rxgk_app.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/rxrpc/rxgk_app.c b/net/rxrpc/rxgk_app.c
index 6206a84395b8..b94b77a1c317 100644
--- a/net/rxrpc/rxgk_app.c
+++ b/net/rxrpc/rxgk_app.c
@@ -141,6 +141,7 @@ int rxgk_yfs_decode_ticket(struct rxrpc_connection *conn, struct sk_buff *skb,
KEY_ALLOC_NOT_IN_QUOTA, NULL);
if (IS_ERR(key)) {
_leave(" = -ENOMEM [alloc %ld]", PTR_ERR(key));
+ ret = PTR_ERR(key);
goto error;
}
--
2.47.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net-next] rxrpc: rxgk: Set error code in rxgk_yfs_decode_ticket()
2025-04-16 11:09 [PATCH net-next] rxrpc: rxgk: Set error code in rxgk_yfs_decode_ticket() Dan Carpenter
@ 2025-04-18 17:00 ` Simon Horman
0 siblings, 0 replies; 2+ messages in thread
From: Simon Horman @ 2025-04-18 17:00 UTC (permalink / raw)
To: Dan Carpenter
Cc: David Howells, Marc Dionne, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, linux-afs, netdev, linux-kernel,
kernel-janitors
On Wed, Apr 16, 2025 at 02:09:51PM +0300, Dan Carpenter wrote:
> Propagate the error code if key_alloc() fails. Don't return
> success.
>
> Fixes: 9d1d2b59341f ("rxrpc: rxgk: Implement the yfs-rxgk security class (GSSAPI)")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Simon Horman <horms@kernel.org>
...
> diff --git a/net/rxrpc/rxgk_app.c b/net/rxrpc/rxgk_app.c
> index 6206a84395b8..b94b77a1c317 100644
> --- a/net/rxrpc/rxgk_app.c
> +++ b/net/rxrpc/rxgk_app.c
> @@ -141,6 +141,7 @@ int rxgk_yfs_decode_ticket(struct rxrpc_connection *conn, struct sk_buff *skb,
> KEY_ALLOC_NOT_IN_QUOTA, NULL);
> if (IS_ERR(key)) {
> _leave(" = -ENOMEM [alloc %ld]", PTR_ERR(key));
Not a bug, but it doesn't seem ideal that _leave(), which logs a debug
message, is called here and with a more general format in the error label.
> + ret = PTR_ERR(key);
> goto error;
> }
>
> --
> 2.47.2
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-04-18 17:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-16 11:09 [PATCH net-next] rxrpc: rxgk: Set error code in rxgk_yfs_decode_ticket() Dan Carpenter
2025-04-18 17:00 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).