From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: Simon Horman <horms@kernel.org>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Shinas Rasheed <srasheed@marvell.com>,
Veerasenareddy Burru <vburru@marvell.com>,
Sathesh Edara <sedara@marvell.com>,
Satananda Burla <sburla@marvell.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next] octeon_ep_vf: Remove octep_vf_wq
Date: Mon, 14 Apr 2025 16:59:47 +0000 [thread overview]
Message-ID: <Z_0_AyjQRT58dYIb@gallifrey> (raw)
In-Reply-To: <20250414-octeon-wq-v1-1-23700e4bd208@kernel.org>
* Simon Horman (horms@kernel.org) wrote:
> commit cb7dd712189f ("octeon_ep_vf: Add driver framework and device
> initialization") added octep_vf_wq but it has never been used. Remove it.
>
> Reported-by: Dr. David Alan Gilbert <linux@treblig.org>
> Closes: https://lore.kernel.org/netdev/Z70bEoTKyeBau52q@gallifrey/
> Signed-off-by: Simon Horman <horms@kernel.org>
Thanks,
Reviewed-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
> drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c | 2 --
> drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.h | 2 --
> 2 files changed, 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c b/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c
> index 18c922dd5fc6..5841e30dff2a 100644
> --- a/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c
> +++ b/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c
> @@ -18,8 +18,6 @@
> #include "octep_vf_config.h"
> #include "octep_vf_main.h"
>
> -struct workqueue_struct *octep_vf_wq;
> -
> /* Supported Devices */
> static const struct pci_device_id octep_vf_pci_id_tbl[] = {
> {PCI_DEVICE(PCI_VENDOR_ID_CAVIUM, OCTEP_PCI_DEVICE_ID_CN93_VF)},
> diff --git a/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.h b/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.h
> index 1a352f41f823..b9f13506f462 100644
> --- a/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.h
> +++ b/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.h
> @@ -320,8 +320,6 @@ static inline u16 OCTEP_VF_MINOR_REV(struct octep_vf_device *oct)
> #define octep_vf_read_csr64(octep_vf_dev, reg_off) \
> readq((octep_vf_dev)->mmio.hw_addr + (reg_off))
>
> -extern struct workqueue_struct *octep_vf_wq;
> -
> int octep_vf_device_setup(struct octep_vf_device *oct);
> int octep_vf_setup_iqs(struct octep_vf_device *oct);
> void octep_vf_free_iqs(struct octep_vf_device *oct);
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
next prev parent reply other threads:[~2025-04-14 16:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-14 16:44 [PATCH net-next] octeon_ep_vf: Remove octep_vf_wq Simon Horman
2025-04-14 16:59 ` Dr. David Alan Gilbert [this message]
2025-04-15 17:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_0_AyjQRT58dYIb@gallifrey \
--to=linux@treblig.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sburla@marvell.com \
--cc=sedara@marvell.com \
--cc=srasheed@marvell.com \
--cc=vburru@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).