* [PATCH net-next] octeon_ep_vf: Remove octep_vf_wq
@ 2025-04-14 16:44 Simon Horman
2025-04-14 16:59 ` Dr. David Alan Gilbert
2025-04-15 17:00 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Simon Horman @ 2025-04-14 16:44 UTC (permalink / raw)
To: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Shinas Rasheed
Cc: Veerasenareddy Burru, Sathesh Edara, Satananda Burla,
Dr. David Alan Gilbert, netdev
commit cb7dd712189f ("octeon_ep_vf: Add driver framework and device
initialization") added octep_vf_wq but it has never been used. Remove it.
Reported-by: Dr. David Alan Gilbert <linux@treblig.org>
Closes: https://lore.kernel.org/netdev/Z70bEoTKyeBau52q@gallifrey/
Signed-off-by: Simon Horman <horms@kernel.org>
---
drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c | 2 --
drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.h | 2 --
2 files changed, 4 deletions(-)
diff --git a/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c b/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c
index 18c922dd5fc6..5841e30dff2a 100644
--- a/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c
+++ b/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c
@@ -18,8 +18,6 @@
#include "octep_vf_config.h"
#include "octep_vf_main.h"
-struct workqueue_struct *octep_vf_wq;
-
/* Supported Devices */
static const struct pci_device_id octep_vf_pci_id_tbl[] = {
{PCI_DEVICE(PCI_VENDOR_ID_CAVIUM, OCTEP_PCI_DEVICE_ID_CN93_VF)},
diff --git a/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.h b/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.h
index 1a352f41f823..b9f13506f462 100644
--- a/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.h
+++ b/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.h
@@ -320,8 +320,6 @@ static inline u16 OCTEP_VF_MINOR_REV(struct octep_vf_device *oct)
#define octep_vf_read_csr64(octep_vf_dev, reg_off) \
readq((octep_vf_dev)->mmio.hw_addr + (reg_off))
-extern struct workqueue_struct *octep_vf_wq;
-
int octep_vf_device_setup(struct octep_vf_device *oct);
int octep_vf_setup_iqs(struct octep_vf_device *oct);
void octep_vf_free_iqs(struct octep_vf_device *oct);
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] octeon_ep_vf: Remove octep_vf_wq
2025-04-14 16:44 [PATCH net-next] octeon_ep_vf: Remove octep_vf_wq Simon Horman
@ 2025-04-14 16:59 ` Dr. David Alan Gilbert
2025-04-15 17:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Dr. David Alan Gilbert @ 2025-04-14 16:59 UTC (permalink / raw)
To: Simon Horman
Cc: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Shinas Rasheed, Veerasenareddy Burru, Sathesh Edara,
Satananda Burla, netdev
* Simon Horman (horms@kernel.org) wrote:
> commit cb7dd712189f ("octeon_ep_vf: Add driver framework and device
> initialization") added octep_vf_wq but it has never been used. Remove it.
>
> Reported-by: Dr. David Alan Gilbert <linux@treblig.org>
> Closes: https://lore.kernel.org/netdev/Z70bEoTKyeBau52q@gallifrey/
> Signed-off-by: Simon Horman <horms@kernel.org>
Thanks,
Reviewed-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
> drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c | 2 --
> drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.h | 2 --
> 2 files changed, 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c b/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c
> index 18c922dd5fc6..5841e30dff2a 100644
> --- a/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c
> +++ b/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c
> @@ -18,8 +18,6 @@
> #include "octep_vf_config.h"
> #include "octep_vf_main.h"
>
> -struct workqueue_struct *octep_vf_wq;
> -
> /* Supported Devices */
> static const struct pci_device_id octep_vf_pci_id_tbl[] = {
> {PCI_DEVICE(PCI_VENDOR_ID_CAVIUM, OCTEP_PCI_DEVICE_ID_CN93_VF)},
> diff --git a/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.h b/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.h
> index 1a352f41f823..b9f13506f462 100644
> --- a/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.h
> +++ b/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.h
> @@ -320,8 +320,6 @@ static inline u16 OCTEP_VF_MINOR_REV(struct octep_vf_device *oct)
> #define octep_vf_read_csr64(octep_vf_dev, reg_off) \
> readq((octep_vf_dev)->mmio.hw_addr + (reg_off))
>
> -extern struct workqueue_struct *octep_vf_wq;
> -
> int octep_vf_device_setup(struct octep_vf_device *oct);
> int octep_vf_setup_iqs(struct octep_vf_device *oct);
> void octep_vf_free_iqs(struct octep_vf_device *oct);
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] octeon_ep_vf: Remove octep_vf_wq
2025-04-14 16:44 [PATCH net-next] octeon_ep_vf: Remove octep_vf_wq Simon Horman
2025-04-14 16:59 ` Dr. David Alan Gilbert
@ 2025-04-15 17:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-04-15 17:00 UTC (permalink / raw)
To: Simon Horman
Cc: andrew+netdev, davem, edumazet, kuba, pabeni, srasheed, vburru,
sedara, sburla, linux, netdev
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 14 Apr 2025 17:44:48 +0100 you wrote:
> commit cb7dd712189f ("octeon_ep_vf: Add driver framework and device
> initialization") added octep_vf_wq but it has never been used. Remove it.
>
> Reported-by: Dr. David Alan Gilbert <linux@treblig.org>
> Closes: https://lore.kernel.org/netdev/Z70bEoTKyeBau52q@gallifrey/
> Signed-off-by: Simon Horman <horms@kernel.org>
>
> [...]
Here is the summary with links:
- [net-next] octeon_ep_vf: Remove octep_vf_wq
https://git.kernel.org/netdev/net-next/c/bbfc077d4572
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-04-15 16:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-14 16:44 [PATCH net-next] octeon_ep_vf: Remove octep_vf_wq Simon Horman
2025-04-14 16:59 ` Dr. David Alan Gilbert
2025-04-15 17:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).