netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 nf-next] docs: tproxy: fix formatting for nft code block
@ 2025-04-08  7:35 Chen Linxuan
  2025-04-08 10:17 ` Bagas Sanjaya
  2025-04-15 15:41 ` Pablo Neira Ayuso
  0 siblings, 2 replies; 3+ messages in thread
From: Chen Linxuan @ 2025-04-08  7:35 UTC (permalink / raw)
  To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	Simon Horman, Jonathan Corbet
  Cc: Pablo Neira Ayuso, Jozsef Kadlecsik, netfilter-devel, coreteam,
	Chen Linxuan, netdev, linux-doc, linux-kernel

The nft command snippet for redirecting traffic isn't formatted
in a literal code block like the rest of snippets.
Fix the formatting inconsistency.

Signed-off-by: Chen Linxuan <chenlinxuan@uniontech.com>
---
v2:
  - Update commit message according to suggestion from Bagas
v1: https://lore.kernel.org/all/CFD0AAF9D7040B1E+20250407031727.1615941-1-chenlinxuan@uniontech.com/
---
 Documentation/networking/tproxy.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/networking/tproxy.rst b/Documentation/networking/tproxy.rst
index 7f7c1ff6f159..75e4990cc3db 100644
--- a/Documentation/networking/tproxy.rst
+++ b/Documentation/networking/tproxy.rst
@@ -69,9 +69,9 @@ add rules like this to the iptables ruleset above::
     # iptables -t mangle -A PREROUTING -p tcp --dport 80 -j TPROXY \
       --tproxy-mark 0x1/0x1 --on-port 50080
 
-Or the following rule to nft:
+Or the following rule to nft::
 
-# nft add rule filter divert tcp dport 80 tproxy to :50080 meta mark set 1 accept
+    # nft add rule filter divert tcp dport 80 tproxy to :50080 meta mark set 1 accept
 
 Note that for this to work you'll have to modify the proxy to enable (SOL_IP,
 IP_TRANSPARENT) for the listening socket.
-- 
2.48.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2 nf-next] docs: tproxy: fix formatting for nft code block
  2025-04-08  7:35 [PATCH v2 nf-next] docs: tproxy: fix formatting for nft code block Chen Linxuan
@ 2025-04-08 10:17 ` Bagas Sanjaya
  2025-04-15 15:41 ` Pablo Neira Ayuso
  1 sibling, 0 replies; 3+ messages in thread
From: Bagas Sanjaya @ 2025-04-08 10:17 UTC (permalink / raw)
  To: Chen Linxuan, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Simon Horman, Jonathan Corbet
  Cc: Pablo Neira Ayuso, Jozsef Kadlecsik, netfilter-devel, coreteam,
	netdev, linux-doc, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1521 bytes --]

On Tue, Apr 08, 2025 at 03:35:50PM +0800, Chen Linxuan wrote:
> The nft command snippet for redirecting traffic isn't formatted
> in a literal code block like the rest of snippets.
> Fix the formatting inconsistency.
> 
> Signed-off-by: Chen Linxuan <chenlinxuan@uniontech.com>
> ---
> v2:
>   - Update commit message according to suggestion from Bagas
> v1: https://lore.kernel.org/all/CFD0AAF9D7040B1E+20250407031727.1615941-1-chenlinxuan@uniontech.com/
> ---
>  Documentation/networking/tproxy.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/networking/tproxy.rst b/Documentation/networking/tproxy.rst
> index 7f7c1ff6f159..75e4990cc3db 100644
> --- a/Documentation/networking/tproxy.rst
> +++ b/Documentation/networking/tproxy.rst
> @@ -69,9 +69,9 @@ add rules like this to the iptables ruleset above::
>      # iptables -t mangle -A PREROUTING -p tcp --dport 80 -j TPROXY \
>        --tproxy-mark 0x1/0x1 --on-port 50080
>  
> -Or the following rule to nft:
> +Or the following rule to nft::
>  
> -# nft add rule filter divert tcp dport 80 tproxy to :50080 meta mark set 1 accept
> +    # nft add rule filter divert tcp dport 80 tproxy to :50080 meta mark set 1 accept
>  
>  Note that for this to work you'll have to modify the proxy to enable (SOL_IP,
>  IP_TRANSPARENT) for the listening socket.

Looks good, thanks!

Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2 nf-next] docs: tproxy: fix formatting for nft code block
  2025-04-08  7:35 [PATCH v2 nf-next] docs: tproxy: fix formatting for nft code block Chen Linxuan
  2025-04-08 10:17 ` Bagas Sanjaya
@ 2025-04-15 15:41 ` Pablo Neira Ayuso
  1 sibling, 0 replies; 3+ messages in thread
From: Pablo Neira Ayuso @ 2025-04-15 15:41 UTC (permalink / raw)
  To: Chen Linxuan
  Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	Simon Horman, Jonathan Corbet, Jozsef Kadlecsik, netfilter-devel,
	coreteam, netdev, linux-doc, linux-kernel

On Tue, Apr 08, 2025 at 03:35:50PM +0800, Chen Linxuan wrote:
> The nft command snippet for redirecting traffic isn't formatted
> in a literal code block like the rest of snippets.
> Fix the formatting inconsistency.

Applied to nf-next, thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-04-15 15:41 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-08  7:35 [PATCH v2 nf-next] docs: tproxy: fix formatting for nft code block Chen Linxuan
2025-04-08 10:17 ` Bagas Sanjaya
2025-04-15 15:41 ` Pablo Neira Ayuso

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).