From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-a5-smtp.messagingengine.com (fout-a5-smtp.messagingengine.com [103.168.172.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B080C1CD213; Tue, 15 Apr 2025 11:37:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.148 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744717058; cv=none; b=axmg4optlk5eZJnj6eRiSBCoFOEu2Th7VNCkt1SBD+K5EXAWtzCM+Haxu1jmcnQUeSaCTNX/gqrK+6frzZA1SQjI92KTmQJTfmKI8Nm0QPyBAJjfwd1h83FtWBwcEakCQIlOcwtjPL81+H1rY003I4TpPJPCckLTQtSA3JOiEbY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744717058; c=relaxed/simple; bh=A2TSmsOW/blYb3WpryncuCWD9dGMjOMZAggqPa01g4o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=APFxj66CAQtuIvvBtd4P6NXbPLcWJntgcJou0XW6tBrJAR4+of8dH+b0NFMt/uakN0/Ychl8epq/pOppsU9LnsdWkL8AsxgE1TUWnSq8hQbQzSWktjoMnK49Tnvut719Q5d+UVdRBO0UFf0obW+8OkNVSBs8pNPkG6qMk19n8co= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=idosch.org; spf=none smtp.mailfrom=idosch.org; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=P2ZwlbJA; arc=none smtp.client-ip=103.168.172.148 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=idosch.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=idosch.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="P2ZwlbJA" Received: from phl-compute-01.internal (phl-compute-01.phl.internal [10.202.2.41]) by mailfout.phl.internal (Postfix) with ESMTP id B137B1380185; Tue, 15 Apr 2025 07:37:35 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-01.internal (MEProxy); Tue, 15 Apr 2025 07:37:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1744717055; x=1744803455; bh=xYpBnhlfvA1MSL6hBNxfqsWMQtyi8h9iLjN /6UqIjuc=; b=P2ZwlbJAvO+q01o0NnriO2vpssIqaGkTSwEVM4VBJl4Y2VCR0Yh QxftKmA3ulAfQYUIVyCLuZn1J1QzKFbWlCQf0LkE9eisUklzOg25A+6fL4F6ga/d 4+AZcSeRBgbkP5mwcUlxR1qjfSuYVsJmymKQCA0ohNuIpMhjROXixzxaiPLOsno2 tLkofpj8Xc2l/qKWVVk6UlBAeipvgNoknHsyyaksj2WhWQ3h/Ji6TmNP/kbK0G48 1S65epLN1hSHct3r2bqs2z4ws3AEDTHkmRPeIium4UZeKyJceCRdKjXb70AxrWAo WWkuLZxWnJk0VGMxUlDvb+8v9exnI01F8pQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvvdeffeelucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhepfffhvfevuffkfhggtggujgesthdtredttddt vdenucfhrhhomhepkfguohcuufgthhhimhhmvghluceoihguohhstghhsehiughoshgthh drohhrgheqnecuggftrfgrthhtvghrnhepvddufeevkeehueegfedtvdevfefgudeifedu ieefgfelkeehgeelgeejjeeggefhnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrg hmpehmrghilhhfrhhomhepihguohhstghhsehiughoshgthhdrohhrghdpnhgspghrtghp thhtohepuddupdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegrlhhokhdrrgdrth hifigrrhhisehorhgrtghlvgdrtghomhdprhgtphhtthhopegurghvvghmsegurghvvghm lhhofhhtrdhnvghtpdhrtghpthhtohepvgguuhhmrgiivghtsehgohhoghhlvgdrtghomh dprhgtphhtthhopehkuhgsrgeskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepphgrsggv nhhisehrvgguhhgrthdrtghomhdprhgtphhtthhopehhohhrmhhssehkvghrnhgvlhdroh hrghdprhgtphhtthhopehshhhurghhsehkvghrnhgvlhdrohhrghdprhgtphhtthhopehl ihhnuhigqdhkvghrnhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphhtthhope hnvghtuggvvhesvhhgvghrrdhkvghrnhgvlhdrohhrgh X-ME-Proxy: Feedback-ID: i494840e7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 15 Apr 2025 07:37:34 -0400 (EDT) Date: Tue, 15 Apr 2025 14:37:31 +0300 From: Ido Schimmel To: Alok Tiwari Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, shuah@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, darren.kenny@oracle.com Subject: Re: [PATCH] selftests: rtnetlink: Fix bridge_parent_id failure on interface state Message-ID: References: <20250414172549.1691612-1-alok.a.tiwari@oracle.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250414172549.1691612-1-alok.a.tiwari@oracle.com> On Mon, Apr 14, 2025 at 10:25:33AM -0700, Alok Tiwari wrote: > The selftest "kci_test_bridge_parent_id" fails with the error: > "Device can not be enslaved while up" when trying to attach interfaces > (`eni10np1`, `eni20np1`) to a bonding device (`test-bond0`) while the > interfaces are in the UP state. Why are they up? The test creates the interfaces and never brings them up. It's most likely caused by some interface manager in your user space. I suggest fixing that instead. > > Failure log: > COMMAND: ip link set dev eni10np1 master test-bond0 > Error: Device can not be enslaved while up. > COMMAND: ip link set dev eni20np1 master test-bond0 > Error: Device can not be enslaved while up. > FAIL: bridge_parent_id > > This behavior aligns with bonding driver requirements, where a slave > interface must be in the DOWN state before being enslaved. This was > reinforced in upstream commit: 'ec4ffd100ffb ("Revert 'net: rtnetlink: > Enslave device before bringing it up'")'. > > This patch updates the test to bring interfaces down explicitly before > adding them to the bonding device: I don't see why the test needs to bring them down when it never brought them up to begin with.