netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] net: phy: remove redundant dependency on NETDEVICES for PHYLINK and PHYLIB
@ 2025-04-13 21:23 Heiner Kallweit
  2025-04-15 16:46 ` Simon Horman
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Heiner Kallweit @ 2025-04-13 21:23 UTC (permalink / raw)
  To: Andrew Lunn, Russell King - ARM Linux, David Miller, Paolo Abeni,
	Jakub Kicinski, Eric Dumazet
  Cc: netdev@vger.kernel.org

drivers/net/phy/Kconfig is included from drivers/net/Kconfig in an
"if NETDEVICES" section. Therefore we don't have to duplicate the
dependency here. And if e.g. PHYLINK is selected somewhere, then the
dependency is ignored anyway (see note in Kconfig help).

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 drivers/net/phy/Kconfig | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
index d29f9f7fd..0b8cc325e 100644
--- a/drivers/net/phy/Kconfig
+++ b/drivers/net/phy/Kconfig
@@ -5,7 +5,6 @@
 
 config PHYLINK
 	tristate
-	depends on NETDEVICES
 	select PHYLIB
 	select SWPHY
 	help
@@ -15,7 +14,6 @@ config PHYLINK
 
 menuconfig PHYLIB
 	tristate "PHY Device support and infrastructure"
-	depends on NETDEVICES
 	select MDIO_DEVICE
 	select MDIO_DEVRES
 	help
-- 
2.49.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH net-next] net: phy: remove redundant dependency on NETDEVICES for PHYLINK and PHYLIB
  2025-04-13 21:23 [PATCH net-next] net: phy: remove redundant dependency on NETDEVICES for PHYLINK and PHYLIB Heiner Kallweit
@ 2025-04-15 16:46 ` Simon Horman
  2025-04-15 17:05 ` Russell King (Oracle)
  2025-04-16  1:00 ` patchwork-bot+netdevbpf
  2 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2025-04-15 16:46 UTC (permalink / raw)
  To: Heiner Kallweit
  Cc: Andrew Lunn, Russell King - ARM Linux, David Miller, Paolo Abeni,
	Jakub Kicinski, Eric Dumazet, netdev@vger.kernel.org

On Sun, Apr 13, 2025 at 11:23:25PM +0200, Heiner Kallweit wrote:
> drivers/net/phy/Kconfig is included from drivers/net/Kconfig in an
> "if NETDEVICES" section. Therefore we don't have to duplicate the
> dependency here. And if e.g. PHYLINK is selected somewhere, then the
> dependency is ignored anyway (see note in Kconfig help).
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

Reviewed-by: Simon Horman <horms@kernel.org>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH net-next] net: phy: remove redundant dependency on NETDEVICES for PHYLINK and PHYLIB
  2025-04-13 21:23 [PATCH net-next] net: phy: remove redundant dependency on NETDEVICES for PHYLINK and PHYLIB Heiner Kallweit
  2025-04-15 16:46 ` Simon Horman
@ 2025-04-15 17:05 ` Russell King (Oracle)
  2025-04-16  1:00 ` patchwork-bot+netdevbpf
  2 siblings, 0 replies; 4+ messages in thread
From: Russell King (Oracle) @ 2025-04-15 17:05 UTC (permalink / raw)
  To: Heiner Kallweit
  Cc: Andrew Lunn, David Miller, Paolo Abeni, Jakub Kicinski,
	Eric Dumazet, netdev@vger.kernel.org

On Sun, Apr 13, 2025 at 11:23:25PM +0200, Heiner Kallweit wrote:
> drivers/net/phy/Kconfig is included from drivers/net/Kconfig in an
> "if NETDEVICES" section. Therefore we don't have to duplicate the
> dependency here. And if e.g. PHYLINK is selected somewhere, then the
> dependency is ignored anyway (see note in Kconfig help).
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>

Thanks!

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH net-next] net: phy: remove redundant dependency on NETDEVICES for PHYLINK and PHYLIB
  2025-04-13 21:23 [PATCH net-next] net: phy: remove redundant dependency on NETDEVICES for PHYLINK and PHYLIB Heiner Kallweit
  2025-04-15 16:46 ` Simon Horman
  2025-04-15 17:05 ` Russell King (Oracle)
@ 2025-04-16  1:00 ` patchwork-bot+netdevbpf
  2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-04-16  1:00 UTC (permalink / raw)
  To: Heiner Kallweit; +Cc: andrew, linux, davem, pabeni, kuba, edumazet, netdev

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Sun, 13 Apr 2025 23:23:25 +0200 you wrote:
> drivers/net/phy/Kconfig is included from drivers/net/Kconfig in an
> "if NETDEVICES" section. Therefore we don't have to duplicate the
> dependency here. And if e.g. PHYLINK is selected somewhere, then the
> dependency is ignored anyway (see note in Kconfig help).
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> 
> [...]

Here is the summary with links:
  - [net-next] net: phy: remove redundant dependency on NETDEVICES for PHYLINK and PHYLIB
    https://git.kernel.org/netdev/net-next/c/1310f44dd4d6

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-04-16  0:59 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-13 21:23 [PATCH net-next] net: phy: remove redundant dependency on NETDEVICES for PHYLINK and PHYLIB Heiner Kallweit
2025-04-15 16:46 ` Simon Horman
2025-04-15 17:05 ` Russell King (Oracle)
2025-04-16  1:00 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).