netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Alexander Duyck <alexander.duyck@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
	Maxime Chevallier <maxime.chevallier@bootlin.com>,
	netdev@vger.kernel.org, hkallweit1@gmail.com,
	davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com
Subject: Re: [net PATCH 1/2] net: phy: Cleanup handling of recent changes to phy_lookup_setting
Date: Sat, 5 Apr 2025 10:43:15 +0100	[thread overview]
Message-ID: <Z_D7M4QGrRB8lezC@shell.armlinux.org.uk> (raw)
In-Reply-To: <CAKgT0UfG6Du3RepV4v0hyta4f5jcUt3P1Bh7E2Jo2Cn4kWJtGw@mail.gmail.com>

On Fri, Apr 04, 2025 at 03:46:38PM -0700, Alexander Duyck wrote:
> On Fri, Apr 4, 2025 at 9:33 AM Andrew Lunn <andrew@lunn.ch> wrote:
> > So for us, we have:
> >
> > MAC - PHY
> > MAC - PCS - PHY
> > MAC - PCS - SFP cage
> > MAC - PCS - PHY - SFP cage
> 
> Is this last one correct? I would have thought it would be MAC - PCS -
> SFP cage - PHY. At least that is how I remember it being with some of
> the igb setups I worked on back in the day.

Yes.

Macchiatobin:

-Part of SoC -|                         /----- RJ45
MAC - PCS --------- 88X3310 Ethernet PHY
--------------|                         \----- SFP cage

Things get more interesting when one plugs in a SFP which itself
contains a PHY, where we effectively end up with:

MAC - PCS - PHY - PHY on SFP module - media

which we don't support very well, partly because it doesn't fit into
the higher levels of the networking model (that's being worked on), and
the 88X3310 doesn't support SGMII on its "fibre" port.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

  reply	other threads:[~2025-04-05  9:43 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-01 21:29 [net PATCH 0/2] Fixes for net/phy/phylink.c Alexander Duyck
2025-04-01 21:30 ` [net PATCH 1/2] net: phy: Cleanup handling of recent changes to phy_lookup_setting Alexander Duyck
2025-04-02  7:00   ` Maxime Chevallier
2025-04-02 14:21     ` Alexander H Duyck
2025-04-02 17:17       ` Jakub Kicinski
2025-04-02 17:30         ` Russell King (Oracle)
2025-04-02 22:37           ` Alexander Duyck
2025-04-03 14:55   ` Russell King (Oracle)
2025-04-03 15:29     ` Maxime Chevallier
2025-04-03 16:34       ` Andrew Lunn
2025-04-03 21:53         ` Alexander Duyck
2025-04-03 23:19           ` Russell King (Oracle)
2025-04-04 15:56             ` Alexander Duyck
2025-04-04 16:33               ` Andrew Lunn
2025-04-04 22:46                 ` Alexander Duyck
2025-04-05  9:43                   ` Russell King (Oracle) [this message]
2025-04-05 14:51                   ` Andrew Lunn
2025-04-05 20:41                     ` Alexander Duyck
2025-04-05 20:53                       ` Andrew Lunn
2025-04-05  9:10               ` Russell King (Oracle)
2025-04-05 15:43                 ` Andrew Lunn
2025-04-05 15:52                 ` Andrew Lunn
2025-04-05 16:19                   ` Alexander Duyck
2025-04-05 20:23                 ` Alexander Duyck
2025-04-03 23:26           ` Russell King (Oracle)
2025-04-04  1:46             ` Andrew Lunn
2025-04-04  7:16               ` Russell King (Oracle)
2025-04-04 16:18                 ` Alexander Duyck
2025-04-07 17:01                   ` Jakub Kicinski
2025-04-07 18:20                     ` Alexander Duyck
2025-04-07 19:34                       ` Andrew Lunn
2025-04-07 23:01                         ` Alexander Duyck
2025-04-01 21:30 ` [net PATCH 2/2] net: phylink: Set advertising based on phy_lookup_setting in ksettings_set Alexander Duyck
2025-04-02 18:02   ` Russell King (Oracle)
2025-04-02 22:34     ` Alexander Duyck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z_D7M4QGrRB8lezC@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=alexander.duyck@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=maxime.chevallier@bootlin.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).