From: Joe Damato <jdamato@fastly.com>
To: Kuniyuki Iwashima <kuniyu@amazon.com>
Cc: Shay Agroskin <shayagr@amazon.com>,
Arthur Kiyanovski <akiyano@amazon.com>,
David Arinzon <darinzon@amazon.com>,
Saeed Bishara <saeedb@amazon.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Kuniyuki Iwashima <kuni1840@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH v1 net-next] net: ena: Support persistent per-NAPI config.
Date: Mon, 7 Apr 2025 11:09:11 -0700 [thread overview]
Message-ID: <Z_QUx7c-7LxPEuor@LQ3V64L9R2> (raw)
In-Reply-To: <20250407164802.25184-1-kuniyu@amazon.com>
On Mon, Apr 07, 2025 at 09:47:59AM -0700, Kuniyuki Iwashima wrote:
> Let's pass the queue index to netif_napi_add_config() to preserve
> per-NAPI config.
>
> Test:
>
> Set 100 to defer-hard-irqs (default is 0) and check the value after
> link down & up.
>
> $ cat /sys/class/net/enp39s0/napi_defer_hard_irqs
> 0
>
> $ ./tools/net/ynl/pyynl/cli.py --spec Documentation/netlink/specs/netdev.yaml \
> --dump napi-get --json='{"ifindex": 2}'
> [{'defer-hard-irqs': 0,
> 'gro-flush-timeout': 0,
> 'id': 65,
> 'ifindex': 2,
> 'irq': 29,
> 'irq-suspend-timeout': 0}]
>
> $ sudo ./tools/net/ynl/pyynl/cli.py --spec Documentation/netlink/specs/netdev.yaml \
> --do napi-set --json='{"id": 65, "defer-hard-irqs": 100}'
>
> $ sudo ip link set enp39s0 down && sudo ip link set enp39s0 up
>
> Without patch:
>
> $ ./tools/net/ynl/pyynl/cli.py --spec Documentation/netlink/specs/netdev.yaml \
> --dump napi-get --json='{"ifindex": 2}'
> [{'defer-hard-irqs': 0, <------------------- Reset to 0
> 'gro-flush-timeout': 0,
> 'id': 66, <------------------------------- New ID
> 'ifindex': 2,
> 'irq': 29,
> 'irq-suspend-timeout': 0}]
>
> With patch:
>
> $ ./tools/net/ynl/pyynl/cli.py --spec Documentation/netlink/specs/netdev.yaml \
> --dump napi-get --json='{"ifindex": 2}'
> [{'defer-hard-irqs': 100, <--------------+-- Preserved
> 'gro-flush-timeout': 0, |
> 'id': 65, <----------------------------'
> 'ifindex': 2,
> 'irq': 29,
> 'irq-suspend-timeout': 0}]
>
> Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
> ---
> drivers/net/ethernet/amazon/ena/ena_netdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thank you for adding support for this!
Reviewed-by: Joe Damato <jdamato@fastly.com>
next prev parent reply other threads:[~2025-04-07 18:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 16:47 [PATCH v1 net-next] net: ena: Support persistent per-NAPI config Kuniyuki Iwashima
2025-04-07 18:09 ` Joe Damato [this message]
2025-04-07 20:17 ` Kiyanovski, Arthur
2025-04-08 20:08 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_QUx7c-7LxPEuor@LQ3V64L9R2 \
--to=jdamato@fastly.com \
--cc=akiyano@amazon.com \
--cc=andrew+netdev@lunn.ch \
--cc=darinzon@amazon.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=kuni1840@gmail.com \
--cc=kuniyu@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedb@amazon.com \
--cc=shayagr@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox