Re: [PATCH net-next 7/8] docs: netdev: break down the instance locking info per ops struct

Joe Damato
2025-04-08T02:34:38Z

On Mon, Apr 07, 2025 at 12:01:16PM -0700, Jakub Kicinski wrote:
> Explicitly list all the ops structs and what locking they provide.
> Use "ops locked" as a term for drivers which have ops called under
> the instance lock.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> Documentation/networking/netdevices.rst | 54 +++++++++++++++++++------
> 1 file changed, 42 insertions(+), 12 deletions(-)
>
> diff --git a/Documentation/networking/netdevices.rst b/Documentation/networking/netdevices.rst
> index d6357472d3f1..0cfff56b436e 100644
> --- a/Documentation/networking/netdevices.rst
> +++ b/Documentation/networking/netdevices.rst
> @@ -314,13 +314,8 @@ struct napi_struct synchronization rules

[...]

> +struct ethtool_ops
> +------------------
> +
> +Similarly to ``ndos`` the instance lock is only held for select drivers.
> +For "ops locked" drivers all ethtool ops without an exception should
> +be called under the instance lock.

Extreme nit (which you can ignore): "without an exception" read
oddly to me. Did you mean "without exception" ?

At any rate:

Reviewed-by: Joe Damato <jdamato@fastly.com>