netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Chen Linxuan <chenlinxuan@uniontech.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>, Jonathan Corbet <corbet@lwn.net>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
	Jozsef Kadlecsik <kadlec@netfilter.org>,
	netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
	netdev@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 nf-next] docs: tproxy: fix formatting for nft code block
Date: Tue, 8 Apr 2025 17:17:06 +0700	[thread overview]
Message-ID: <Z_T3onGJiXbbd8ST@archie.me> (raw)
In-Reply-To: <E25F951CDC9F22B2+20250408073550.3319892-2-chenlinxuan@uniontech.com>

[-- Attachment #1: Type: text/plain, Size: 1521 bytes --]

On Tue, Apr 08, 2025 at 03:35:50PM +0800, Chen Linxuan wrote:
> The nft command snippet for redirecting traffic isn't formatted
> in a literal code block like the rest of snippets.
> Fix the formatting inconsistency.
> 
> Signed-off-by: Chen Linxuan <chenlinxuan@uniontech.com>
> ---
> v2:
>   - Update commit message according to suggestion from Bagas
> v1: https://lore.kernel.org/all/CFD0AAF9D7040B1E+20250407031727.1615941-1-chenlinxuan@uniontech.com/
> ---
>  Documentation/networking/tproxy.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/networking/tproxy.rst b/Documentation/networking/tproxy.rst
> index 7f7c1ff6f159..75e4990cc3db 100644
> --- a/Documentation/networking/tproxy.rst
> +++ b/Documentation/networking/tproxy.rst
> @@ -69,9 +69,9 @@ add rules like this to the iptables ruleset above::
>      # iptables -t mangle -A PREROUTING -p tcp --dport 80 -j TPROXY \
>        --tproxy-mark 0x1/0x1 --on-port 50080
>  
> -Or the following rule to nft:
> +Or the following rule to nft::
>  
> -# nft add rule filter divert tcp dport 80 tproxy to :50080 meta mark set 1 accept
> +    # nft add rule filter divert tcp dport 80 tproxy to :50080 meta mark set 1 accept
>  
>  Note that for this to work you'll have to modify the proxy to enable (SOL_IP,
>  IP_TRANSPARENT) for the listening socket.

Looks good, thanks!

Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2025-04-08 10:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-08  7:35 [PATCH v2 nf-next] docs: tproxy: fix formatting for nft code block Chen Linxuan
2025-04-08 10:17 ` Bagas Sanjaya [this message]
2025-04-15 15:41 ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z_T3onGJiXbbd8ST@archie.me \
    --to=bagasdotme@gmail.com \
    --cc=chenlinxuan@uniontech.com \
    --cc=corbet@lwn.net \
    --cc=coreteam@netfilter.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kadlec@netfilter.org \
    --cc=kuba@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).