From: Ido Schimmel <idosch@idosch.org>
To: Michael Chan <michael.chan@broadcom.com>
Cc: Damodharam Ammepalli <damodharam.ammepalli@broadcom.com>,
davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, andrew@lunn.ch,
horms@kernel.org, danieller@nvidia.com,
andrew.gospodarek@broadcom.com, petrm@nvidia.com
Subject: Re: [PATCH net 2/2] ethtool: cmis: use u16 for calculated read_write_len_ext
Date: Wed, 9 Apr 2025 09:40:32 +0300 [thread overview]
Message-ID: <Z_YWYKfUATz19geO@shredder> (raw)
In-Reply-To: <CACKFLik=7nTXHGUiTQH=aAsY=3sxd39ouZLEYkN2hj8rRHetsw@mail.gmail.com>
On Tue, Apr 08, 2025 at 11:25:44AM -0700, Michael Chan wrote:
> On Mon, Apr 7, 2025 at 9:23 AM Ido Schimmel <idosch@idosch.org> wrote:
> >
> > To be clear, this is what I'm suggesting [1] and it doesn't involve
> > setting args->req.epl_len to zero, so I'm not sure what was tested.
> >
> > Basically, setting maximum length of read or write to 128 bytes as the
> > kernel does not currently support auto paging (even if the transceiver
> > module does) and will not try to perform cross-page reads or writes.
>
> Ido, do you want to post your patch formally? Damodharam has tested
> it and he is providing his:
>
> Tested-by: Damodharam Ammepalli <damodharam.ammepalli@broadcom.com>
>
> I'll drop this patch and repost patch #1 only. Thanks.
OK, as you wish. I figured you would just incorporate the change into
v2, but I can post the patch myself.
prev parent reply other threads:[~2025-04-09 6:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-02 18:31 [PATCH net 0/2] ethtool: cmis fixes Michael Chan
2025-04-02 18:31 ` [PATCH net 1/2] ethtool: cmis_cdb: use correct rpl size in ethtool_cmis_module_poll() Michael Chan
2025-04-03 9:02 ` Simon Horman
2025-04-03 15:06 ` Ido Schimmel
2025-04-02 18:31 ` [PATCH net 2/2] ethtool: cmis: use u16 for calculated read_write_len_ext Michael Chan
2025-04-03 9:04 ` Simon Horman
2025-04-03 15:03 ` Ido Schimmel
2025-04-07 15:09 ` Damodharam Ammepalli
2025-04-07 16:23 ` Ido Schimmel
2025-04-07 18:03 ` Damodharam Ammepalli
2025-04-08 18:25 ` Michael Chan
2025-04-09 6:40 ` Ido Schimmel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_YWYKfUATz19geO@shredder \
--to=idosch@idosch.org \
--cc=andrew.gospodarek@broadcom.com \
--cc=andrew@lunn.ch \
--cc=damodharam.ammepalli@broadcom.com \
--cc=danieller@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).