From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh-a6-smtp.messagingengine.com (fhigh-a6-smtp.messagingengine.com [103.168.172.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1ED3A1DF26F for ; Wed, 9 Apr 2025 06:40:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.157 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744180839; cv=none; b=lKD8E9og91UvTHtAuR0C0jcnmyVt5drX1cx9ne6NqPzTes+Ubmklkm1jYt4gJp8jYb38nsYwwJf3GZVSVEqZTGpdYvmC0flZ4jKryyLPBgpJvM/cXblSFGSRwiNBrt9bv3S+OPkx1fSy+cRPq4U2G1hpUKEyuLCctz3wzwK6jbQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744180839; c=relaxed/simple; bh=7o6a2nvVwLYHeX/c8zhJrI+adrIx2FSoCS5LnDERMWE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eVll/+9xnd5erwcBysqNL7DSHPKHTAAsNEBvCgx6w4vVJmdkNxuw04CuDNxv5MO28x6DGEYfELPxr/O8ghy6hdMMpiEfRO8dDgAbO40yZL4ahrxO3CYAppJsYWPSUrR4BWyNy28wtTzYOmyykf5J2s+cGwMk8V0mGfopvoroV/8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=idosch.org; spf=none smtp.mailfrom=idosch.org; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=cRTNueH0; arc=none smtp.client-ip=103.168.172.157 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=idosch.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=idosch.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="cRTNueH0" Received: from phl-compute-01.internal (phl-compute-01.phl.internal [10.202.2.41]) by mailfhigh.phl.internal (Postfix) with ESMTP id 11D751140192; Wed, 9 Apr 2025 02:40:36 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-01.internal (MEProxy); Wed, 09 Apr 2025 02:40:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1744180836; x= 1744267236; bh=BcwP9avawRhonmUticFT0MAEd9a2Df0v1P5/5LGiiZM=; b=c RTNueH0IIMwHk5ZWS3iQqiWHI4yQmVKZ4se9XthdxlD/m9oExf+w6/QAIh4mp1KA mALw5j+BbJ2P16SiQMF7gicYpaVN+yjbjrSaL9xMRMYcOutrtnLtGqmyC6O1diQk HqN5rrO+9VIjxOsjBiaTm+pDdaahU/Fjc9hTavqPKLMW/y9Yh1GtaYRgEnSxbBxu rzeImKV/jNqShgwat24210y6Fs/LH8KL+4oPjQ1Qu+GHcFKQI1yTfwce6CPxVlkR DoVzM/NPj5ETX2E+y2kTJxdijgpv1d8JRsfAAWzdiTpGXUXvzaNrJOLKy9mE9UBi PXAspbrFnqbwIAVWpJvOA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvtdehvdelucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhepfffhvfevuffkfhggtggugfgjsehtkeertddt tdejnecuhfhrohhmpefkughoucfutghhihhmmhgvlhcuoehiughoshgthhesihguohhstg hhrdhorhhgqeenucggtffrrghtthgvrhhnpeekgefggefhuedvgeettdegvdeuvdfhudej vddvjeetledvuedtheehleelhffhudenucevlhhushhtvghrufhiiigvpedtnecurfgrrh grmhepmhgrihhlfhhrohhmpehiughoshgthhesihguohhstghhrdhorhhgpdhnsggprhgt phhtthhopeduvddpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepmhhitghhrggvlh drtghhrghnsegsrhhorggutghomhdrtghomhdprhgtphhtthhopegurghmohguhhgrrhgr mhdrrghmmhgvphgrlhhlihessghrohgruggtohhmrdgtohhmpdhrtghpthhtohepuggrvh gvmhesuggrvhgvmhhlohhfthdrnhgvthdprhgtphhtthhopehnvghtuggvvhesvhhgvghr rdhkvghrnhgvlhdrohhrghdprhgtphhtthhopegvughumhgriigvthesghhoohhglhgvrd gtohhmpdhrtghpthhtohepkhhusggrsehkvghrnhgvlhdrohhrghdprhgtphhtthhopehp rggsvghnihesrhgvughhrghtrdgtohhmpdhrtghpthhtoheprghnughrvgifsehluhhnnh drtghhpdhrtghpthhtohephhhorhhmsheskhgvrhhnvghlrdhorhhg X-ME-Proxy: Feedback-ID: i494840e7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 9 Apr 2025 02:40:35 -0400 (EDT) Date: Wed, 9 Apr 2025 09:40:32 +0300 From: Ido Schimmel To: Michael Chan Cc: Damodharam Ammepalli , davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew@lunn.ch, horms@kernel.org, danieller@nvidia.com, andrew.gospodarek@broadcom.com, petrm@nvidia.com Subject: Re: [PATCH net 2/2] ethtool: cmis: use u16 for calculated read_write_len_ext Message-ID: References: <20250402183123.321036-1-michael.chan@broadcom.com> <20250402183123.321036-3-michael.chan@broadcom.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Apr 08, 2025 at 11:25:44AM -0700, Michael Chan wrote: > On Mon, Apr 7, 2025 at 9:23 AM Ido Schimmel wrote: > > > > To be clear, this is what I'm suggesting [1] and it doesn't involve > > setting args->req.epl_len to zero, so I'm not sure what was tested. > > > > Basically, setting maximum length of read or write to 128 bytes as the > > kernel does not currently support auto paging (even if the transceiver > > module does) and will not try to perform cross-page reads or writes. > > Ido, do you want to post your patch formally? Damodharam has tested > it and he is providing his: > > Tested-by: Damodharam Ammepalli > > I'll drop this patch and repost patch #1 only. Thanks. OK, as you wish. I figured you would just incorporate the change into v2, but I can post the patch myself.