From: Ido Schimmel <idosch@idosch.org>
To: Martyna Szapar-Mudlaw <martyna.szapar-mudlaw@linux.intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
Michal Kubiak <michal.kubiak@intel.com>
Subject: Re: [PATCH iwl-next 1/2] ice: add link_down_events statistic
Date: Wed, 9 Apr 2025 15:06:24 +0300 [thread overview]
Message-ID: <Z_ZiwNUJy7xGeT8m@shredder> (raw)
In-Reply-To: <20250409113622.161379-4-martyna.szapar-mudlaw@linux.intel.com>
On Wed, Apr 09, 2025 at 01:36:23PM +0200, Martyna Szapar-Mudlaw wrote:
> Introduce a new ethtool statistic to ice driver, `link_down_events`,
> to track the number of times the link transitions from up to down.
> This counter can help diagnose issues related to link stability,
> such as port flapping or unexpected link drops.
>
> The counter increments when a link-down event occurs and is exposed
> via ethtool stats as `link_down_events.nic`.
Are you aware of commit 9a0f830f8026 ("ethtool: linkstate: add a
statistic for PHY down events")?
Better to report this via the generic counter than a driver-specific
one.
next prev parent reply other threads:[~2025-04-09 12:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-09 11:36 [PATCH iwl-next 0/2] Add link_down_events ethtool stat to ixgbe and ice Martyna Szapar-Mudlaw
2025-04-09 11:36 ` [PATCH iwl-next 1/2] ice: add link_down_events statistic Martyna Szapar-Mudlaw
2025-04-09 12:06 ` Ido Schimmel [this message]
2025-04-14 13:03 ` Szapar-Mudlaw, Martyna
2025-04-09 12:08 ` [Intel-wired-lan] " Paul Menzel
2025-04-14 13:12 ` Szapar-Mudlaw, Martyna
2025-05-12 9:27 ` Paul Menzel
2025-05-15 10:52 ` Szapar-Mudlaw, Martyna
2025-04-09 11:36 ` [PATCH iwl-next 2/2] ixgbe: " Martyna Szapar-Mudlaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_ZiwNUJy7xGeT8m@shredder \
--to=idosch@idosch.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=martyna.szapar-mudlaw@linux.intel.com \
--cc=michal.kubiak@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox