netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Kory Maincent <kory.maincent@bootlin.com>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
	"Heiner Kallweit" <hkallweit1@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Marek Behún" <kabel@kernel.org>,
	"Richard Cochran" <richardcochran@gmail.com>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	"Maxime Chevallier" <maxime.chevallier@bootlin.com>,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 2/2] net: phy: Add Marvell PHY PTP support
Date: Wed, 9 Apr 2025 16:34:36 +0100	[thread overview]
Message-ID: <Z_aTjBrUw79skcAg@shell.armlinux.org.uk> (raw)
In-Reply-To: <20250407-feature_marvell_ptp-v2-2-a297d3214846@bootlin.com>

On Mon, Apr 07, 2025 at 04:03:01PM +0200, Kory Maincent wrote:
> From: Russell King <rmk+kernel@armlinux.org.uk>
> 
> From: Russell King <rmk+kernel@armlinux.org.uk>
> 
> Add PTP basic support for Marvell 88E151x PHYs. These PHYs support
> timestamping the egress and ingress of packets, but does not support
> any packet modification.
> 
> The PHYs support hardware pins for providing an external clock for the
> TAI counter, and a separate pin that can be used for event capture or
> generation of a trigger (either a pulse or periodic).  This code does
> not support either of these modes.
> 
> The driver takes inspiration from the Marvell 88E6xxx DSA and DP83640
> drivers.  The hardware is very similar to the implementation found in
> the 88E6xxx DSA driver, but the access methods are very different,
> although it may be possible to create a library that both can use
> along with accessor functions.
> 
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> 
> Add support for interruption.
> Fix L2 PTP encapsulation frame detection.
> Fix first PTP timestamp being dropped.
> Fix Kconfig to depends on MARVELL_PHY.
> Update comments to use kdoc.

Would you mind forwarding me the changes you actually made so I can
integrate them into the version I have (which is structured quite
differently from - what I assume - is a much older version of my
patches please?

The PTP IP is re-used not only in Marvell PHY drivers but also their
DSA drivers, and having it all in drivers/net/phy/ as this version
has does not make sense.

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

  parent reply	other threads:[~2025-04-09 15:34 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-07 14:02 [PATCH net-next v2 0/2] Add Marvell PHY PTP support Kory Maincent
2025-04-07 14:03 ` [PATCH net-next v2 1/2] net: phy: Move Marvell PHY drivers to its own subdirectory Kory Maincent
2025-04-07 14:03 ` [PATCH net-next v2 2/2] net: phy: Add Marvell PHY PTP support Kory Maincent
2025-04-07 14:15   ` Kory Maincent
2025-04-08 15:49   ` Simon Horman
2025-04-08 17:32     ` Russell King (Oracle)
2025-04-09  8:18       ` Kory Maincent
2025-04-09  8:33         ` Russell King (Oracle)
2025-04-09  8:48           ` Kory Maincent
2025-04-09 12:16             ` Russell King (Oracle)
2025-04-09 12:38               ` Kory Maincent
2025-04-09 13:35                 ` Russell King (Oracle)
2025-04-09 16:04                   ` Kory Maincent
2025-04-09 17:34                     ` Russell King (Oracle)
2025-04-09 22:38                       ` Russell King (Oracle)
2025-04-10  4:16                         ` Richard Cochran
2025-04-10  7:44                           ` Russell King (Oracle)
2025-04-21 11:20                             ` Richard Cochran
2025-04-10  9:17                         ` Kory Maincent
2025-04-10 15:41                           ` Russell King (Oracle)
2025-04-10 16:02                             ` Kory Maincent
2025-04-10 18:16                               ` Russell King (Oracle)
2025-04-10 19:40                                 ` Russell King (Oracle)
2025-04-11  8:01                                   ` Kory Maincent
2025-04-11  8:25                                     ` Russell King (Oracle)
2025-04-09  8:07     ` Kory Maincent
2025-04-11 15:53       ` Simon Horman
2025-04-09 15:34   ` Russell King (Oracle) [this message]
2025-04-09 16:01     ` Kory Maincent
2025-04-07 14:08 ` [PATCH net-next v2 0/2] " Andrew Lunn
2025-04-07 14:31   ` Kory Maincent
2025-04-07 16:02 ` Russell King (Oracle)
2025-04-07 16:20   ` Kory Maincent
2025-04-07 16:32     ` Russell King (Oracle)
2025-04-07 16:39       ` Kory Maincent
2025-04-08 20:38         ` Russell King (Oracle)
2025-04-09  8:31           ` Kory Maincent
2025-04-09  8:35             ` Russell King (Oracle)
2025-04-09  8:38               ` Vladimir Oltean
2025-04-09  8:48                 ` Kory Maincent
2025-04-09  9:28                 ` Russell King (Oracle)
2025-04-09  8:46               ` Kory Maincent
2025-04-09  9:29                 ` Russell King (Oracle)
2025-04-09 12:23                   ` Kory Maincent
2025-04-09 12:46                     ` Maxime Chevallier
2025-04-09 14:49                       ` Kory Maincent
2025-04-09 15:10                         ` Maxime Chevallier
2025-04-09 15:14                           ` Kory Maincent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z_aTjBrUw79skcAg@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=kabel@kernel.org \
    --cc=kory.maincent@bootlin.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime.chevallier@bootlin.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=richardcochran@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).