Re: [PATCH net-next] net: convert dev->rtnl_link_state to a bool

[Stanislav Fomichev <stfomichev@gmail.com>]

On 04/09, Jakub Kicinski wrote:
> netdevice reg_state was split into two 16 bit enums back in 2010
> in commit a2835763e130 ("rtnetlink: handle rtnl_link netlink
> notifications manually"). Since the split the fields have been
> moved apart, and last year we converted reg_state to a normal
> u8 in commit 4d42b37def70 ("net: convert dev->reg_state to u8").
> 
> rtnl_link_state being a 16 bitfield makes no sense. Convert it
> to a single bool, it seems very unlikely after 15 years that
> we'll need more values in it.
> 
> We could drop dev->rtnl_link_ops from the conditions but feels
> like having it there more clearly points at the reason for this
> hack.

Acked-by: Stanislav Fomichev <sdf@fomichev.me>

But for me having rtnl_link_ops in the mix is still hard to read.
Might be more clear to rename rtnl_link_initializing to
suppress_rtnl_notify, make it false by default, and set to true 
from rtnl_create_link. Then reading conditions like the one below
will make more sense (imo):

	if (!dev->suppress_rtnl_notify)
  		rtmsg_ifinfo(RTM_NEWLINK, dev, ~0U, GFP_KERNEL, 0, NULL);

(iow, reverse the conditional so false works for most non-ops devices)