From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: linux-renesas-soc@vger.kernel.org,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org
Subject: Re: [RFC PATCH net-next] net: phy: marvell: support DT configurations with only two LEDs
Date: Thu, 10 Apr 2025 22:05:32 +0200 [thread overview]
Message-ID: <Z_gkjKharPsRhT6J@shikoro> (raw)
In-Reply-To: <1cb6ec18-9abb-48d9-b9a2-ca79584d4d0d@lunn.ch>
[-- Attachment #1: Type: text/plain, Size: 631 bytes --]
> > The 'link_*' files appeared, 'device_name' and 'offloaded' have the
> > expected values. But now the LED is blinking like crazy despite all the
> > rx/tx/whatnot triggers still set to 0.
>
> So that is odd. If offloaded indicates the hardware is doing the
> blinking, that means we have a problem with the PHY configuration.
> What model of Marvell PHY is it? There are some differences between
> the models.
Thank you for the detailed explanations. I think they could be a basis
for a documentation file.
My PHY is a M88E1510. This is why changing its init to
MII_88E1510_PHY_LED0_LINK_LED1_ACTIVE helps.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2025-04-10 20:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-08 6:30 [RFC PATCH net-next] net: phy: marvell: support DT configurations with only two LEDs Wolfram Sang
2025-04-08 12:44 ` Andrew Lunn
2025-04-09 6:55 ` Wolfram Sang
2025-04-09 12:11 ` Andrew Lunn
2025-04-10 7:40 ` Wolfram Sang
2025-04-10 13:10 ` Andrew Lunn
2025-04-10 20:05 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_gkjKharPsRhT6J@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox