Re: [PATCH ethtool] Set type property to console-application for provided AppStream metainfo XML

[Salvatore Bonaccorso <carnil@debian.org>]

Hi Michal,

On Fri, Apr 11, 2025 at 04:10:24PM +0200, Salvatore Bonaccorso wrote:
> As pointed out in the Debian downstream report, as ethtool is a
> command-line tool the XML root myst have the type property set to
> console-application.
> 
> Additionally with the type propety set to desktop, ethtool is user
> uninstallable via GUI (such as GNOME Software or KDE Discover).
> 
> Fixes: 02d505bba6fe ("Add AppStream metainfo XML with modalias documented supported hardware.")
> Reported-by: asciiwolf@seznam.cz
> Cc: Petter Reinholdtsen <pere@hungry.com>
> Link: https://bugs.debian.org/1102647
> Link: https://bugzilla.redhat.com/show_bug.cgi?id=2359069
> Link: https://freedesktop.org/software/appstream/docs/sect-Metadata-ConsoleApplication.html
> Signed-off-by: Salvatore Bonaccorso <carnil@debian.org>
> ---
>  org.kernel.software.network.ethtool.metainfo.xml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/org.kernel.software.network.ethtool.metainfo.xml b/org.kernel.software.network.ethtool.metainfo.xml
> index efe84c17e4cd..c31cae4bede6 100644
> --- a/org.kernel.software.network.ethtool.metainfo.xml
> +++ b/org.kernel.software.network.ethtool.metainfo.xml
> @@ -1,5 +1,5 @@
>  <?xml version="1.0" encoding="UTF-8"?>
> -<component type="desktop">
> +<component type="console-application">
>    <id>org.kernel.software.network.ethtool</id>
>    <metadata_license>MIT</metadata_license>
>    <name>ethtool</name>
> -- 
> 2.49.0

ignore that please as Daniel and Petter have the proper proposal
building up.

Thanks Daniel and Petter.

Petter, once it's commited upstream I will cherry-pick back for
Debian.

Regards,
Salvatore