From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C79DB5674E for ; Sun, 13 Apr 2025 22:40:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744584057; cv=none; b=NVCqnJ6wLTxqk+gBn2eyJ4X2sIOSSu0ByNME/uedAOZBOZmEAvZ27y72lmF18zv+CEcqmJ4GZxHYOk0DlH7BXRf9UjCvhNNXe8iamYeYhzQn/Ul57zjP+CWG3tsX4yfPpGv/JcZqHhifwzr1LACYWoo3HBJ3RKPECdlO85OLhcM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744584057; c=relaxed/simple; bh=mTciRUiCc02Z6hwxoBv+s/F5gx/tWEtihBHNt/9NrA8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kxECR9TtRqfEn/InnT6Y/eyOS/Va+GIaU7QNrnUpzKw+yXzGK3PjtiQSaG3HP59ex7ZBe+wtOHEs1j3Wz/4xctz0yocGd3NV9Oj9HaoqczlLq0/Yva70mAPYIjBE+df8ktIvwrP5cvimtBMtUkmbDZenQFvfQ3G5FIYnll0xJb8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=MIKCdwdT; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="MIKCdwdT" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=yZKPPgLOnaA6LtXNLTqGU/0863A2eFjmUO8YRdkWJA4=; b=MIKCdwdTxzfm3nfeLK8y3tQrPx GMWv72wuecKr72/MAFovpO4qbGD8I8Cg87KO745HF+Dl2ZGdoRMUpfuvoSf6yXBRRTe2iQkYFgt5N gTgOojG7ShUf0rqNK0xgzGqV98HMv0Wt5sUzlFYynzlhBnuxaPq71cYgyT1uzoplz+w3uIh01v9l4 Hf2qzDPOtxo34Of4kFQtbMgRdoq3O3qk5twXCMkm/hToxF3aPri/nuuO9fb0Jj1t/0F2VYhb9hTVd Hb/QX10GHmk4NCgEVTuuwwgMFo4aVF5HPtRgGMvY1wZFwnOZFqbArFnPzIXNymN4kx2OdP1MDtbnB RlZiSjtA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:42456) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1u460K-0005hA-0X; Sun, 13 Apr 2025 23:40:44 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.96) (envelope-from ) id 1u460G-00072n-0w; Sun, 13 Apr 2025 23:40:40 +0100 Date: Sun, 13 Apr 2025 23:40:40 +0100 From: "Russell King (Oracle)" To: Andrew Lunn Cc: Heiner Kallweit , Alexandre Torgue , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Coquelin , netdev@vger.kernel.org, Paolo Abeni Subject: Re: [PATCH net-next 4/4] net: stmmac: anarion: use devm_stmmac_pltfr_probe() Message-ID: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Russell King (Oracle) On Sun, Apr 13, 2025 at 11:10:24PM +0200, Andrew Lunn wrote: > On Sat, Apr 12, 2025 at 03:17:12PM +0100, Russell King (Oracle) wrote: > > Convert anarion to use devm_stmmac_pltfr_probe() which allows the > > removal of an explicit call to stmmac_pltfr_remove(). > > > > Signed-off-by: Russell King (Oracle) > > Reviewed-by: Andrew Lunn Thanks - but nipa found an error in the patch - s/&pdev->dev/pdev/ with the new call. Ditto for "net: stmmac: anarion: use stmmac_pltfr_probe()" so I'll be sending a v2 for both. Do you want me to keep your r-b with that change for both patches? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!