[PATCH net-next 01/22] net: fill in MODULE_DESCRIPTION()s for 8390

[PATCH net-next 01/22] net: fill in MODULE_DESCRIPTION()s for 8390

[Breno Leitao]

W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to all the good old 8390 modules and drivers.

Signed-off-by: Breno Leitao <leitao@debian.org>
CC: geert@linux-m68k.org
---
 drivers/net/ethernet/8390/8390.c      | 1 +
 drivers/net/ethernet/8390/8390p.c     | 1 +
 drivers/net/ethernet/8390/apne.c      | 1 +
 drivers/net/ethernet/8390/hydra.c     | 1 +
 drivers/net/ethernet/8390/stnic.c     | 1 +
 drivers/net/ethernet/8390/zorro8390.c | 1 +
 6 files changed, 6 insertions(+)

diff --git a/drivers/net/ethernet/8390/8390.c b/drivers/net/ethernet/8390/8390.c
index 0e0aa4016858..c5636245f1ca 100644
--- a/drivers/net/ethernet/8390/8390.c
+++ b/drivers/net/ethernet/8390/8390.c
@@ -100,4 +100,5 @@ static void __exit ns8390_module_exit(void)
 module_init(ns8390_module_init);
 module_exit(ns8390_module_exit);
 #endif /* MODULE */
+MODULE_DESCRIPTION("National Semiconductor 8390 core driver");
 MODULE_LICENSE("GPL");
diff --git a/drivers/net/ethernet/8390/8390p.c b/drivers/net/ethernet/8390/8390p.c
index 6834742057b3..6d429b11e9c6 100644
--- a/drivers/net/ethernet/8390/8390p.c
+++ b/drivers/net/ethernet/8390/8390p.c
@@ -102,4 +102,5 @@ static void __exit NS8390p_cleanup_module(void)
 
 module_init(NS8390p_init_module);
 module_exit(NS8390p_cleanup_module);
+MODULE_DESCRIPTION("National Semiconductor 8390 core for ISA driver");
 MODULE_LICENSE("GPL");
diff --git a/drivers/net/ethernet/8390/apne.c b/drivers/net/ethernet/8390/apne.c
index a09f383dd249..828edca8d30c 100644
--- a/drivers/net/ethernet/8390/apne.c
+++ b/drivers/net/ethernet/8390/apne.c
@@ -610,4 +610,5 @@ static int init_pcmcia(void)
 	return 1;
 }
 
+MODULE_DESCRIPTION("National Semiconductor 8390 Amiga PCMCIA ethernet driver");
 MODULE_LICENSE("GPL");
diff --git a/drivers/net/ethernet/8390/hydra.c b/drivers/net/ethernet/8390/hydra.c
index 24f49a8ff903..fd9dcdc356e6 100644
--- a/drivers/net/ethernet/8390/hydra.c
+++ b/drivers/net/ethernet/8390/hydra.c
@@ -270,4 +270,5 @@ static void __exit hydra_cleanup_module(void)
 module_init(hydra_init_module);
 module_exit(hydra_cleanup_module);
 
+MODULE_DESCRIPTION("Zorro-II Hydra 8390 ethernet driver");
 MODULE_LICENSE("GPL");
diff --git a/drivers/net/ethernet/8390/stnic.c b/drivers/net/ethernet/8390/stnic.c
index 265976e3b64a..6cc0e190aa79 100644
--- a/drivers/net/ethernet/8390/stnic.c
+++ b/drivers/net/ethernet/8390/stnic.c
@@ -296,4 +296,5 @@ static void __exit stnic_cleanup(void)
 
 module_init(stnic_probe);
 module_exit(stnic_cleanup);
+MODULE_DESCRIPTION("National Semiconductor DP83902AV ethernet driver");
 MODULE_LICENSE("GPL");
diff --git a/drivers/net/ethernet/8390/zorro8390.c b/drivers/net/ethernet/8390/zorro8390.c
index d70390e9d03d..c24dd4fe7a10 100644
--- a/drivers/net/ethernet/8390/zorro8390.c
+++ b/drivers/net/ethernet/8390/zorro8390.c
@@ -443,4 +443,5 @@ static void __exit zorro8390_cleanup_module(void)
 module_init(zorro8390_init_module);
 module_exit(zorro8390_cleanup_module);
 
+MODULE_DESCRIPTION("Zorro NS8390-based ethernet driver");
 MODULE_LICENSE("GPL");
-- 
2.39.3

[PATCH net-next 02/22] net: fill in MODULE_DESCRIPTION()s for ieee802154

[Breno Leitao]

W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to ieee802154 modules.

Signed-off-by: Breno Leitao <leitao@debian.org>
Acked-by: Stefan Schmidt <stefan@datenfreihafen.org>
---
 net/ieee802154/6lowpan/core.c | 1 +
 net/ieee802154/socket.c       | 1 +
 2 files changed, 2 insertions(+)

diff --git a/net/ieee802154/6lowpan/core.c b/net/ieee802154/6lowpan/core.c
index 2c087b7f17c5..e643f52663f9 100644
--- a/net/ieee802154/6lowpan/core.c
+++ b/net/ieee802154/6lowpan/core.c
@@ -280,5 +280,6 @@ static void __exit lowpan_cleanup_module(void)
 
 module_init(lowpan_init_module);
 module_exit(lowpan_cleanup_module);
+MODULE_DESCRIPTION("IPv6 over Low power Wireless Personal Area Network IEEE 802.15.4 core");
 MODULE_LICENSE("GPL");
 MODULE_ALIAS_RTNL_LINK("lowpan");
diff --git a/net/ieee802154/socket.c b/net/ieee802154/socket.c
index 00302e8b9615..990a83455dcf 100644
--- a/net/ieee802154/socket.c
+++ b/net/ieee802154/socket.c
@@ -1137,4 +1137,5 @@ module_init(af_ieee802154_init);
 module_exit(af_ieee802154_remove);
 
 MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("IEEE 802.15.4 socket interface");
 MODULE_ALIAS_NETPROTO(PF_IEEE802154);
-- 
2.39.3

Re: [PATCH net-next 02/22] net: fill in MODULE_DESCRIPTION()s for ieee802154

[Miquel Raynal]

Hi Breno,

leitao@debian.org wrote on Mon, 22 Jan 2024 10:45:23 -0800:

> W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> Add descriptions to ieee802154 modules.
> 
> Signed-off-by: Breno Leitao <leitao@debian.org>
> Acked-by: Stefan Schmidt <stefan@datenfreihafen.org>

I just see the v2 now. Please use "v2" in your commit title using -v or
git-format-patch.

I'll take it through wpan.

Thanks,
Miquèl

Re: [PATCH net-next 02/22] net: fill in MODULE_DESCRIPTION()s for ieee802154

[Breno Leitao]

Hello Miquèl,

On Wed, Jan 24, 2024 at 05:51:58PM +0100, Miquel Raynal wrote:
> Hi Breno,
> 
> leitao@debian.org wrote on Mon, 22 Jan 2024 10:45:23 -0800:
> 
> > W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> > Add descriptions to ieee802154 modules.
> > 
> > Signed-off-by: Breno Leitao <leitao@debian.org>
> > Acked-by: Stefan Schmidt <stefan@datenfreihafen.org>
> 
> I just see the v2 now. Please use "v2" in your commit title using -v or
> git-format-patch.

Sorry, I am not sure I followed what you meant.  I've sent the v2, which
contains the 'v2' _tag_:

https://lore.kernel.org/all/20240123190332.677489-1-leitao@debian.org/

I didn't include the ieee802154 fix because the maintainers asked me to
split the patchset in a maximum of 10 patches[1], and I am doing it by
area (net, wifi, ethernet, etc). That means that this patch was not send
on the first batch, that is prioritizing Ethernet drivers (which is
described in the cover letter of v2)[2].

Anyway, let me know if I missed something here.

Thanks!
[1] https://lore.kernel.org/all/20240122105708.52d33fa0@kernel.org/
[2] https://lore.kernel.org/all/20240123190332.677489-1-leitao@debian.org/

Re: [PATCH net-next 02/22] net: fill in MODULE_DESCRIPTION()s for ieee802154

[Miquel Raynal]

Hi Breno,

leitao@debian.org wrote on Thu, 25 Jan 2024 02:01:06 -0800:

> Hello Miquèl,
> 
> On Wed, Jan 24, 2024 at 05:51:58PM +0100, Miquel Raynal wrote:
> > Hi Breno,
> > 
> > leitao@debian.org wrote on Mon, 22 Jan 2024 10:45:23 -0800:
> >   
> > > W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> > > Add descriptions to ieee802154 modules.
> > > 
> > > Signed-off-by: Breno Leitao <leitao@debian.org>
> > > Acked-by: Stefan Schmidt <stefan@datenfreihafen.org>  
> > 
> > I just see the v2 now. Please use "v2" in your commit title using -v or
> > git-format-patch.  
> 
> Sorry, I am not sure I followed what you meant.  I've sent the v2, which
> contains the 'v2' _tag_:

I believe *this* is a v2 because you fixed your initial patch,
following Stefan's suggestion.

Anyway, it's fine for me to merge this patch through net directly (I
don't know if net maintainers want W=1 fixes to go through net or
net-next) so:

Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>

Thanks,
Miquèl

Re: [PATCH net-next 02/22] net: fill in MODULE_DESCRIPTION()s for ieee802154

[Breno Leitao]

On Thu, Jan 25, 2024 at 03:55:32PM +0100, Miquel Raynal wrote:
> Hi Breno,
> 
> leitao@debian.org wrote on Thu, 25 Jan 2024 02:01:06 -0800:
> 
> > Hello Miquèl,
> > 
> > On Wed, Jan 24, 2024 at 05:51:58PM +0100, Miquel Raynal wrote:
> > > Hi Breno,
> > > 
> > > leitao@debian.org wrote on Mon, 22 Jan 2024 10:45:23 -0800:
> > >   
> > > > W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> > > > Add descriptions to ieee802154 modules.
> > > > 
> > > > Signed-off-by: Breno Leitao <leitao@debian.org>
> > > > Acked-by: Stefan Schmidt <stefan@datenfreihafen.org>  
> > > 
> > > I just see the v2 now. Please use "v2" in your commit title using -v or
> > > git-format-patch.  
> > 
> > Sorry, I am not sure I followed what you meant.  I've sent the v2, which
> > contains the 'v2' _tag_:
> 
> I believe *this* is a v2 because you fixed your initial patch,
> following Stefan's suggestion.
> 
> Anyway, it's fine for me to merge this patch through net directly (I
> don't know if net maintainers want W=1 fixes to go through net or
> net-next) so:

Thanks Miquèl. Jakub convinced Paolo that these fixes should go through
net, that is why I am targeting `net`.

https://lore.kernel.org/all/20240122105708.52d33fa0@kernel.org/

[PATCH net-next 03/22] net: fill in MODULE_DESCRIPTION()s for PCS Layer

[Breno Leitao]

W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to the LynxI PCS MediaTek's SoC.

Signed-off-by: Breno Leitao <leitao@debian.org>
---
 drivers/net/pcs/pcs-lynx.c      | 1 +
 drivers/net/pcs/pcs-mtk-lynxi.c | 1 +
 drivers/net/pcs/pcs-xpcs.c      | 1 +
 3 files changed, 3 insertions(+)

diff --git a/drivers/net/pcs/pcs-lynx.c b/drivers/net/pcs/pcs-lynx.c
index dc3962b2aa6b..d51d09beaab3 100644
--- a/drivers/net/pcs/pcs-lynx.c
+++ b/drivers/net/pcs/pcs-lynx.c
@@ -398,4 +398,5 @@ void lynx_pcs_destroy(struct phylink_pcs *pcs)
 }
 EXPORT_SYMBOL(lynx_pcs_destroy);
 
+MODULE_DESCRIPTION("MediaTek SGMII library for Lynx PCS");
 MODULE_LICENSE("Dual BSD/GPL");
diff --git a/drivers/net/pcs/pcs-mtk-lynxi.c b/drivers/net/pcs/pcs-mtk-lynxi.c
index 8501dd365279..4f63abe638c4 100644
--- a/drivers/net/pcs/pcs-mtk-lynxi.c
+++ b/drivers/net/pcs/pcs-mtk-lynxi.c
@@ -303,4 +303,5 @@ void mtk_pcs_lynxi_destroy(struct phylink_pcs *pcs)
 }
 EXPORT_SYMBOL(mtk_pcs_lynxi_destroy);
 
+MODULE_DESCRIPTION("MediaTek SGMII library for LynxI");
 MODULE_LICENSE("GPL");
diff --git a/drivers/net/pcs/pcs-xpcs.c b/drivers/net/pcs/pcs-xpcs.c
index 31f0beba638a..9c020dd3c766 100644
--- a/drivers/net/pcs/pcs-xpcs.c
+++ b/drivers/net/pcs/pcs-xpcs.c
@@ -1456,4 +1456,5 @@ struct dw_xpcs *xpcs_create_mdiodev(struct mii_bus *bus, int addr,
 }
 EXPORT_SYMBOL_GPL(xpcs_create_mdiodev);
 
+MODULE_DESCRIPTION("Synopsys DesignWare XPCS helpers");
 MODULE_LICENSE("GPL v2");
-- 
2.39.3

Re: [PATCH net-next 03/22] net: fill in MODULE_DESCRIPTION()s for PCS Layer

[Daniel Golle]

Hi Breno,

On Mon, Jan 22, 2024 at 10:45:24AM -0800, Breno Leitao wrote:
> W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> Add descriptions to the LynxI PCS MediaTek's SoC.
> 
> Signed-off-by: Breno Leitao <leitao@debian.org>
> ---
>  drivers/net/pcs/pcs-lynx.c      | 1 +
>  drivers/net/pcs/pcs-mtk-lynxi.c | 1 +
>  drivers/net/pcs/pcs-xpcs.c      | 1 +
>  3 files changed, 3 insertions(+)
> 
> diff --git a/drivers/net/pcs/pcs-lynx.c b/drivers/net/pcs/pcs-lynx.c
> index dc3962b2aa6b..d51d09beaab3 100644
> --- a/drivers/net/pcs/pcs-lynx.c
> +++ b/drivers/net/pcs/pcs-lynx.c
> @@ -398,4 +398,5 @@ void lynx_pcs_destroy(struct phylink_pcs *pcs)
>  }
>  EXPORT_SYMBOL(lynx_pcs_destroy);
>  
> +MODULE_DESCRIPTION("MediaTek SGMII library for Lynx PCS");

Nah, pcs-lynx.c is used by various SoC vendors **other than MediaTek**
such as Freescale and STMicroelectronics.

Users of the pcs-lynx.c driver are
ethernet/stmicro/stmmac/dwmac-socfpga.c
ethernet/altera/altera_tse_main.c
ethernet/freescale/dpaa2/dpaa2-mac.c
ethernet/freescale/enetc/enetc_pf.c
ethernet/freescale/fman/fman_memac.c
dsa/ocelot/felix_vsc9959.c
dsa/ocelot/seville_vsc9953.c


>  MODULE_LICENSE("Dual BSD/GPL");
> diff --git a/drivers/net/pcs/pcs-mtk-lynxi.c b/drivers/net/pcs/pcs-mtk-lynxi.c
> index 8501dd365279..4f63abe638c4 100644
> --- a/drivers/net/pcs/pcs-mtk-lynxi.c
> +++ b/drivers/net/pcs/pcs-mtk-lynxi.c
> @@ -303,4 +303,5 @@ void mtk_pcs_lynxi_destroy(struct phylink_pcs *pcs)
>  }
>  EXPORT_SYMBOL(mtk_pcs_lynxi_destroy);
>  
> +MODULE_DESCRIPTION("MediaTek SGMII library for LynxI");

Ack on this one.

>  MODULE_LICENSE("GPL");
> diff --git a/drivers/net/pcs/pcs-xpcs.c b/drivers/net/pcs/pcs-xpcs.c
> index 31f0beba638a..9c020dd3c766 100644
> --- a/drivers/net/pcs/pcs-xpcs.c
> +++ b/drivers/net/pcs/pcs-xpcs.c
> @@ -1456,4 +1456,5 @@ struct dw_xpcs *xpcs_create_mdiodev(struct mii_bus *bus, int addr,
>  }
>  EXPORT_SYMBOL_GPL(xpcs_create_mdiodev);
>  
> +MODULE_DESCRIPTION("Synopsys DesignWare XPCS helpers");
>  MODULE_LICENSE("GPL v2");
> -- 
> 2.39.3
> 

Re: [PATCH net-next 03/22] net: fill in MODULE_DESCRIPTION()s for PCS Layer

[Breno Leitao]

On Mon, Jan 22, 2024 at 07:31:18PM +0000, Daniel Golle wrote:
> Hi Breno,
> 
> On Mon, Jan 22, 2024 at 10:45:24AM -0800, Breno Leitao wrote:
> > W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> > Add descriptions to the LynxI PCS MediaTek's SoC.
> > 
> > Signed-off-by: Breno Leitao <leitao@debian.org>
> > ---
> >  drivers/net/pcs/pcs-lynx.c      | 1 +
> >  drivers/net/pcs/pcs-mtk-lynxi.c | 1 +
> >  drivers/net/pcs/pcs-xpcs.c      | 1 +
> >  3 files changed, 3 insertions(+)
> > 
> > diff --git a/drivers/net/pcs/pcs-lynx.c b/drivers/net/pcs/pcs-lynx.c
> > index dc3962b2aa6b..d51d09beaab3 100644
> > --- a/drivers/net/pcs/pcs-lynx.c
> > +++ b/drivers/net/pcs/pcs-lynx.c
> > @@ -398,4 +398,5 @@ void lynx_pcs_destroy(struct phylink_pcs *pcs)
> >  }
> >  EXPORT_SYMBOL(lynx_pcs_destroy);
> >  
> > +MODULE_DESCRIPTION("MediaTek SGMII library for Lynx PCS");
> 
> Nah, pcs-lynx.c is used by various SoC vendors **other than MediaTek**
> such as Freescale and STMicroelectronics.
> 
> Users of the pcs-lynx.c driver are
> ethernet/stmicro/stmmac/dwmac-socfpga.c
> ethernet/altera/altera_tse_main.c
> ethernet/freescale/dpaa2/dpaa2-mac.c
> ethernet/freescale/enetc/enetc_pf.c
> ethernet/freescale/fman/fman_memac.c
> dsa/ocelot/felix_vsc9959.c
> dsa/ocelot/seville_vsc9953.c

Thanks. What about something as?

MODULE_DESCRIPTION("Lynx PCS MDIO helpers");

Re: [PATCH net-next 03/22] net: fill in MODULE_DESCRIPTION()s for PCS Layer

[Andrew Lunn]

On Mon, Jan 22, 2024 at 10:45:24AM -0800, Breno Leitao wrote:
> W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> Add descriptions to the LynxI PCS MediaTek's SoC.

That patch now does more than that.

> Signed-off-by: Breno Leitao <leitao@debian.org>
> ---
>  drivers/net/pcs/pcs-lynx.c      | 1 +
>  drivers/net/pcs/pcs-mtk-lynxi.c | 1 +
>  drivers/net/pcs/pcs-xpcs.c      | 1 +
>  3 files changed, 3 insertions(+)
> 
> diff --git a/drivers/net/pcs/pcs-lynx.c b/drivers/net/pcs/pcs-lynx.c
> index dc3962b2aa6b..d51d09beaab3 100644
> --- a/drivers/net/pcs/pcs-lynx.c
> +++ b/drivers/net/pcs/pcs-lynx.c
> @@ -398,4 +398,5 @@ void lynx_pcs_destroy(struct phylink_pcs *pcs)
>  }
>  EXPORT_SYMBOL(lynx_pcs_destroy);
>  
> +MODULE_DESCRIPTION("MediaTek SGMII library for Lynx PCS");

pcs-lynx is for NXP hardware, not MediaTek.

    Andrew

---
pw-bot: cr

Re: [PATCH net-next 03/22] net: fill in MODULE_DESCRIPTION()s for PCS Layer

[Breno Leitao]

On Mon, Jan 22, 2024 at 08:33:31PM +0100, Andrew Lunn wrote:
> On Mon, Jan 22, 2024 at 10:45:24AM -0800, Breno Leitao wrote:
> > W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> > Add descriptions to the LynxI PCS MediaTek's SoC.
> 
> That patch now does more than that.
> 
> > Signed-off-by: Breno Leitao <leitao@debian.org>
> > ---
> >  drivers/net/pcs/pcs-lynx.c      | 1 +
> >  drivers/net/pcs/pcs-mtk-lynxi.c | 1 +
> >  drivers/net/pcs/pcs-xpcs.c      | 1 +
> >  3 files changed, 3 insertions(+)
> > 
> > diff --git a/drivers/net/pcs/pcs-lynx.c b/drivers/net/pcs/pcs-lynx.c
> > index dc3962b2aa6b..d51d09beaab3 100644
> > --- a/drivers/net/pcs/pcs-lynx.c
> > +++ b/drivers/net/pcs/pcs-lynx.c
> > @@ -398,4 +398,5 @@ void lynx_pcs_destroy(struct phylink_pcs *pcs)
> >  }
> >  EXPORT_SYMBOL(lynx_pcs_destroy);
> >  
> > +MODULE_DESCRIPTION("MediaTek SGMII library for Lynx PCS");
> 
> pcs-lynx is for NXP hardware, not MediaTek.

Thanks. I will update!

[PATCH net-next 04/22] net: fill in MODULE_DESCRIPTION()s for Broadcom bgmac

[Breno Leitao]

W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to the Broadcom iProc GBit driver.

Signed-off-by: Breno Leitao <leitao@debian.org>
---
 drivers/net/ethernet/broadcom/bcm4908_enet.c    | 1 +
 drivers/net/ethernet/broadcom/bgmac-bcma-mdio.c | 1 +
 drivers/net/ethernet/broadcom/bgmac-bcma.c      | 1 +
 drivers/net/ethernet/broadcom/bgmac-platform.c  | 1 +
 drivers/net/ethernet/broadcom/bgmac.c           | 1 +
 5 files changed, 5 insertions(+)

diff --git a/drivers/net/ethernet/broadcom/bcm4908_enet.c b/drivers/net/ethernet/broadcom/bcm4908_enet.c
index 3e7c8671cd11..a6bc5ce70230 100644
--- a/drivers/net/ethernet/broadcom/bcm4908_enet.c
+++ b/drivers/net/ethernet/broadcom/bcm4908_enet.c
@@ -793,5 +793,6 @@ static struct platform_driver bcm4908_enet_driver = {
 };
 module_platform_driver(bcm4908_enet_driver);
 
+MODULE_DESCRIPTION("Broadcom iProc GBit Ethernet driver");
 MODULE_LICENSE("GPL v2");
 MODULE_DEVICE_TABLE(of, bcm4908_enet_of_match);
diff --git a/drivers/net/ethernet/broadcom/bgmac-bcma-mdio.c b/drivers/net/ethernet/broadcom/bgmac-bcma-mdio.c
index 9b83d5361699..50b8e97a811d 100644
--- a/drivers/net/ethernet/broadcom/bgmac-bcma-mdio.c
+++ b/drivers/net/ethernet/broadcom/bgmac-bcma-mdio.c
@@ -260,4 +260,5 @@ void bcma_mdio_mii_unregister(struct mii_bus *mii_bus)
 EXPORT_SYMBOL_GPL(bcma_mdio_mii_unregister);
 
 MODULE_AUTHOR("Rafał Miłecki");
+MODULE_DESCRIPTION("Broadcom iProc GBit BCMA MDIO helpers");
 MODULE_LICENSE("GPL");
diff --git a/drivers/net/ethernet/broadcom/bgmac-bcma.c b/drivers/net/ethernet/broadcom/bgmac-bcma.c
index 6e4f36aaf5db..6c53ea522daf 100644
--- a/drivers/net/ethernet/broadcom/bgmac-bcma.c
+++ b/drivers/net/ethernet/broadcom/bgmac-bcma.c
@@ -362,4 +362,5 @@ module_init(bgmac_init)
 module_exit(bgmac_exit)
 
 MODULE_AUTHOR("Rafał Miłecki");
+MODULE_DESCRIPTION("Broadcom iProc GBit BCMA helpers");
 MODULE_LICENSE("GPL");
diff --git a/drivers/net/ethernet/broadcom/bgmac-platform.c b/drivers/net/ethernet/broadcom/bgmac-platform.c
index 0b21fd5bd457..5bdd875831f1 100644
--- a/drivers/net/ethernet/broadcom/bgmac-platform.c
+++ b/drivers/net/ethernet/broadcom/bgmac-platform.c
@@ -298,4 +298,5 @@ static struct platform_driver bgmac_enet_driver = {
 };
 
 module_platform_driver(bgmac_enet_driver);
+MODULE_DESCRIPTION("Broadcom iProc GBit platform");
 MODULE_LICENSE("GPL");
diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c
index 448a1b90de5e..6ffdc4229407 100644
--- a/drivers/net/ethernet/broadcom/bgmac.c
+++ b/drivers/net/ethernet/broadcom/bgmac.c
@@ -1626,4 +1626,5 @@ int bgmac_enet_resume(struct bgmac *bgmac)
 EXPORT_SYMBOL_GPL(bgmac_enet_resume);
 
 MODULE_AUTHOR("Rafał Miłecki");
+MODULE_DESCRIPTION("Broadcom iProc GBit driver");
 MODULE_LICENSE("GPL");
-- 
2.39.3

Re: [PATCH net-next 04/22] net: fill in MODULE_DESCRIPTION()s for Broadcom bgmac

[Florian Fainelli]

[-- Attachment #1: Type: text/plain, Size: 3181 bytes --]

On 1/22/24 10:45, Breno Leitao wrote:
> W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> Add descriptions to the Broadcom iProc GBit driver.
> 
> Signed-off-by: Breno Leitao <leitao@debian.org>
> ---
>   drivers/net/ethernet/broadcom/bcm4908_enet.c    | 1 +
>   drivers/net/ethernet/broadcom/bgmac-bcma-mdio.c | 1 +
>   drivers/net/ethernet/broadcom/bgmac-bcma.c      | 1 +
>   drivers/net/ethernet/broadcom/bgmac-platform.c  | 1 +
>   drivers/net/ethernet/broadcom/bgmac.c           | 1 +
>   5 files changed, 5 insertions(+)
> 
> diff --git a/drivers/net/ethernet/broadcom/bcm4908_enet.c b/drivers/net/ethernet/broadcom/bcm4908_enet.c
> index 3e7c8671cd11..a6bc5ce70230 100644
> --- a/drivers/net/ethernet/broadcom/bcm4908_enet.c
> +++ b/drivers/net/ethernet/broadcom/bcm4908_enet.c
> @@ -793,5 +793,6 @@ static struct platform_driver bcm4908_enet_driver = {
>   };
>   module_platform_driver(bcm4908_enet_driver);
>   
> +MODULE_DESCRIPTION("Broadcom iProc GBit Ethernet driver");

This should be:

Broadcom BCM4908 Gigabit Ethernet driver

>   MODULE_LICENSE("GPL v2");
>   MODULE_DEVICE_TABLE(of, bcm4908_enet_of_match);
> diff --git a/drivers/net/ethernet/broadcom/bgmac-bcma-mdio.c b/drivers/net/ethernet/broadcom/bgmac-bcma-mdio.c
> index 9b83d5361699..50b8e97a811d 100644
> --- a/drivers/net/ethernet/broadcom/bgmac-bcma-mdio.c
> +++ b/drivers/net/ethernet/broadcom/bgmac-bcma-mdio.c
> @@ -260,4 +260,5 @@ void bcma_mdio_mii_unregister(struct mii_bus *mii_bus)
>   EXPORT_SYMBOL_GPL(bcma_mdio_mii_unregister);
>   
>   MODULE_AUTHOR("Rafał Miłecki");
> +MODULE_DESCRIPTION("Broadcom iProc GBit BCMA MDIO helpers");
>   MODULE_LICENSE("GPL");
> diff --git a/drivers/net/ethernet/broadcom/bgmac-bcma.c b/drivers/net/ethernet/broadcom/bgmac-bcma.c
> index 6e4f36aaf5db..6c53ea522daf 100644
> --- a/drivers/net/ethernet/broadcom/bgmac-bcma.c
> +++ b/drivers/net/ethernet/broadcom/bgmac-bcma.c
> @@ -362,4 +362,5 @@ module_init(bgmac_init)
>   module_exit(bgmac_exit)
>   
>   MODULE_AUTHOR("Rafał Miłecki");
> +MODULE_DESCRIPTION("Broadcom iProc GBit BCMA helpers");

Broadcom iProc GBit BCMA interface driver

>   MODULE_LICENSE("GPL");
> diff --git a/drivers/net/ethernet/broadcom/bgmac-platform.c b/drivers/net/ethernet/broadcom/bgmac-platform.c
> index 0b21fd5bd457..5bdd875831f1 100644
> --- a/drivers/net/ethernet/broadcom/bgmac-platform.c
> +++ b/drivers/net/ethernet/broadcom/bgmac-platform.c
> @@ -298,4 +298,5 @@ static struct platform_driver bgmac_enet_driver = {
>   };
>   
>   module_platform_driver(bgmac_enet_driver);
> +MODULE_DESCRIPTION("Broadcom iProc GBit platform");

Broadcom iProc GBit platform interface driver

>   MODULE_LICENSE("GPL");
> diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c
> index 448a1b90de5e..6ffdc4229407 100644
> --- a/drivers/net/ethernet/broadcom/bgmac.c
> +++ b/drivers/net/ethernet/broadcom/bgmac.c
> @@ -1626,4 +1626,5 @@ int bgmac_enet_resume(struct bgmac *bgmac)
>   EXPORT_SYMBOL_GPL(bgmac_enet_resume);
>   
>   MODULE_AUTHOR("Rafał Miłecki");
> +MODULE_DESCRIPTION("Broadcom iProc GBit driver");
>   MODULE_LICENSE("GPL");

pw-bot: cr
-- 
Florian


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]

Re: [PATCH net-next 04/22] net: fill in MODULE_DESCRIPTION()s for Broadcom bgmac

[Breno Leitao]

On Mon, Jan 22, 2024 at 10:50:32AM -0800, Florian Fainelli wrote:
> On 1/22/24 10:45, Breno Leitao wrote:
> > W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> > Add descriptions to the Broadcom iProc GBit driver.
> > 
> > Signed-off-by: Breno Leitao <leitao@debian.org>
> > ---
> >   drivers/net/ethernet/broadcom/bcm4908_enet.c    | 1 +
> >   drivers/net/ethernet/broadcom/bgmac-bcma-mdio.c | 1 +
> >   drivers/net/ethernet/broadcom/bgmac-bcma.c      | 1 +
> >   drivers/net/ethernet/broadcom/bgmac-platform.c  | 1 +
> >   drivers/net/ethernet/broadcom/bgmac.c           | 1 +
> >   5 files changed, 5 insertions(+)
> > 
> > diff --git a/drivers/net/ethernet/broadcom/bcm4908_enet.c b/drivers/net/ethernet/broadcom/bcm4908_enet.c
> > index 3e7c8671cd11..a6bc5ce70230 100644
> > --- a/drivers/net/ethernet/broadcom/bcm4908_enet.c
> > +++ b/drivers/net/ethernet/broadcom/bcm4908_enet.c
> > @@ -793,5 +793,6 @@ static struct platform_driver bcm4908_enet_driver = {
> >   };
> >   module_platform_driver(bcm4908_enet_driver);
> > +MODULE_DESCRIPTION("Broadcom iProc GBit Ethernet driver");
> 
> This should be:
> 
> Broadcom BCM4908 Gigabit Ethernet driver

Thanks. I will update in v2.

[PATCH net-next 05/22] net: fill in MODULE_DESCRIPTION()s for liquidio

[Breno Leitao]

W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to the Cavium Liquidio.

Signed-off-by: Breno Leitao <leitao@debian.org>
---
 drivers/net/ethernet/cavium/liquidio/lio_core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/cavium/liquidio/lio_core.c b/drivers/net/ethernet/cavium/liquidio/lio_core.c
index 9cc6303c82ff..f38d31bfab1b 100644
--- a/drivers/net/ethernet/cavium/liquidio/lio_core.c
+++ b/drivers/net/ethernet/cavium/liquidio/lio_core.c
@@ -27,6 +27,7 @@
 #include "octeon_network.h"
 
 MODULE_AUTHOR("Cavium Networks, <support@cavium.com>");
+MODULE_DESCRIPTION("Cavium LiquidIO Intelligent Server Adapter Core");
 MODULE_LICENSE("GPL");
 
 /* OOM task polling interval */
-- 
2.39.3

[PATCH net-next 06/22] net: fill in MODULE_DESCRIPTION()s for ep93xxx_eth

[Breno Leitao]

W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to the Cirrus EP93xx ethernet driver.

Signed-off-by: Breno Leitao <leitao@debian.org>
---
 drivers/net/ethernet/cirrus/ep93xx_eth.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/cirrus/ep93xx_eth.c b/drivers/net/ethernet/cirrus/ep93xx_eth.c
index 1c2a540db13d..1f495cfd7959 100644
--- a/drivers/net/ethernet/cirrus/ep93xx_eth.c
+++ b/drivers/net/ethernet/cirrus/ep93xx_eth.c
@@ -868,5 +868,6 @@ static struct platform_driver ep93xx_eth_driver = {
 
 module_platform_driver(ep93xx_eth_driver);
 
+MODULE_DESCRIPTION("Cirrus EP93xx Ethernet driver");
 MODULE_LICENSE("GPL");
 MODULE_ALIAS("platform:ep93xx-eth");
-- 
2.39.3

[PATCH net-next 07/22] net: fill in MODULE_DESCRIPTION()s for nps_enet

[Breno Leitao]

W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to the EZchip NPS ethernet driver.

Signed-off-by: Breno Leitao <leitao@debian.org>
---
 drivers/net/ethernet/ezchip/nps_enet.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/ezchip/nps_enet.c b/drivers/net/ethernet/ezchip/nps_enet.c
index 07c2b701b5fa..9ebe751c1df0 100644
--- a/drivers/net/ethernet/ezchip/nps_enet.c
+++ b/drivers/net/ethernet/ezchip/nps_enet.c
@@ -661,4 +661,5 @@ static struct platform_driver nps_enet_driver = {
 module_platform_driver(nps_enet_driver);
 
 MODULE_AUTHOR("EZchip Semiconductor");
+MODULE_DESCRIPTION("EZchip NPS Ethernet driver");
 MODULE_LICENSE("GPL v2");
-- 
2.39.3

[PATCH net-next 08/22] net: fill in MODULE_DESCRIPTION()s for enetc

[Breno Leitao]

W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to the NXP ENETC Ethernet driver.

Signed-off-by: Breno Leitao <leitao@debian.org>
---
 drivers/net/ethernet/freescale/enetc/enetc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/freescale/enetc/enetc.c b/drivers/net/ethernet/freescale/enetc/enetc.c
index cffbf27c4656..bfdbdab443ae 100644
--- a/drivers/net/ethernet/freescale/enetc/enetc.c
+++ b/drivers/net/ethernet/freescale/enetc/enetc.c
@@ -3216,4 +3216,5 @@ void enetc_pci_remove(struct pci_dev *pdev)
 }
 EXPORT_SYMBOL_GPL(enetc_pci_remove);
 
+MODULE_DESCRIPTION("NXP ENETC Ethernet driver");
 MODULE_LICENSE("Dual BSD/GPL");
-- 
2.39.3

[PATCH net-next 09/22] net: fill in MODULE_DESCRIPTION()s for fec

[Breno Leitao]

W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to the FEC (MPC8xx) Ethernet controller.

Signed-off-by: Breno Leitao <leitao@debian.org>
---
 drivers/net/ethernet/freescale/fec_main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index d42594f32275..c56807b757dc 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -4769,4 +4769,5 @@ static struct platform_driver fec_driver = {
 
 module_platform_driver(fec_driver);
 
+MODULE_DESCRIPTION("Fast Ethernet Controller (FEC) MPC8xx Ethernet driver");
 MODULE_LICENSE("GPL");
-- 
2.39.3

RE: [PATCH net-next 09/22] net: fill in MODULE_DESCRIPTION()s for fec

[Wei Fang]

> -----Original Message-----
> From: Breno Leitao <leitao@debian.org>
> Sent: 2024年1月23日 2:46
> To: kuba@kernel.org; davem@davemloft.net; abeni@redhat.com;
> edumazet@google.com; Wei Fang <wei.fang@nxp.com>; Shenwei Wang
> <shenwei.wang@nxp.com>; Clark Wang <xiaoning.wang@nxp.com>;
> dl-linux-imx <linux-imx@nxp.com>; Paolo Abeni <pabeni@redhat.com>
> Cc: dsahern@kernel.org; weiwan@google.com; open list:FREESCALE IMX /
> MXC FEC DRIVER <netdev@vger.kernel.org>; open list
> <linux-kernel@vger.kernel.org>
> Subject: [PATCH net-next 09/22] net: fill in MODULE_DESCRIPTION()s for fec
> 
> W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> Add descriptions to the FEC (MPC8xx) Ethernet controller.
> 
> Signed-off-by: Breno Leitao <leitao@debian.org>
> ---
>  drivers/net/ethernet/freescale/fec_main.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/freescale/fec_main.c
> b/drivers/net/ethernet/freescale/fec_main.c
> index d42594f32275..c56807b757dc 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -4769,4 +4769,5 @@ static struct platform_driver fec_driver = {
> 
>  module_platform_driver(fec_driver);
> 
> +MODULE_DESCRIPTION("Fast Ethernet Controller (FEC) MPC8xx Ethernet
> driver");

Thank you very much for this patch. It would be better if you change the
description to " NXP Fast Ethernet Controller (FEC) driver".

>  MODULE_LICENSE("GPL");
> --
> 2.39.3

[PATCH net-next 10/22] net: fill in MODULE_DESCRIPTION()s for fsl_pq_mdio

[Breno Leitao]

W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to the Freescale PQ MDIO driver.

Signed-off-by: Breno Leitao <leitao@debian.org>
---
 drivers/net/ethernet/freescale/fsl_pq_mdio.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/freescale/fsl_pq_mdio.c b/drivers/net/ethernet/freescale/fsl_pq_mdio.c
index 70dd982a5edc..026f7270a54d 100644
--- a/drivers/net/ethernet/freescale/fsl_pq_mdio.c
+++ b/drivers/net/ethernet/freescale/fsl_pq_mdio.c
@@ -531,4 +531,5 @@ static struct platform_driver fsl_pq_mdio_driver = {
 
 module_platform_driver(fsl_pq_mdio_driver);
 
+MODULE_DESCRIPTION("Freescale PQ MDIO helpers");
 MODULE_LICENSE("GPL");
-- 
2.39.3

[PATCH net-next 11/22] net: fill in MODULE_DESCRIPTION()s for litex

[Breno Leitao]

W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to the LiteX Liteeth Ethernet device.

Signed-off-by: Breno Leitao <leitao@debian.org>
---
 drivers/net/ethernet/litex/litex_liteeth.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/litex/litex_liteeth.c b/drivers/net/ethernet/litex/litex_liteeth.c
index 5182fe737c37..ff54fbe41bcc 100644
--- a/drivers/net/ethernet/litex/litex_liteeth.c
+++ b/drivers/net/ethernet/litex/litex_liteeth.c
@@ -318,4 +318,5 @@ static struct platform_driver liteeth_driver = {
 module_platform_driver(liteeth_driver);
 
 MODULE_AUTHOR("Joel Stanley <joel@jms.id.au>");
+MODULE_DESCRIPTION("LiteX Liteeth Ethernet driver");
 MODULE_LICENSE("GPL");
-- 
2.39.3

Re: [PATCH net-next 11/22] net: fill in MODULE_DESCRIPTION()s for litex

[Gabriel L. Somlo]

On Mon, Jan 22, 2024 at 10:45:32AM -0800, Breno Leitao wrote:
> W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> Add descriptions to the LiteX Liteeth Ethernet device.
> 
> Signed-off-by: Breno Leitao <leitao@debian.org>

Acked-by: Gabriel Somlo <gsomlo@gmail.com>

Thanks,
--Gabriel

> ---
>  drivers/net/ethernet/litex/litex_liteeth.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/litex/litex_liteeth.c b/drivers/net/ethernet/litex/litex_liteeth.c
> index 5182fe737c37..ff54fbe41bcc 100644
> --- a/drivers/net/ethernet/litex/litex_liteeth.c
> +++ b/drivers/net/ethernet/litex/litex_liteeth.c
> @@ -318,4 +318,5 @@ static struct platform_driver liteeth_driver = {
>  module_platform_driver(liteeth_driver);
>  
>  MODULE_AUTHOR("Joel Stanley <joel@jms.id.au>");
> +MODULE_DESCRIPTION("LiteX Liteeth Ethernet driver");
>  MODULE_LICENSE("GPL");
> -- 
> 2.39.3
> 

[PATCH net-next 12/22] net: fill in MODULE_DESCRIPTION()s for rvu_mbox

[Breno Leitao]

W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to the Marvel RVU mbox driver.

Signed-off-by: Breno Leitao <leitao@debian.org>
---
 drivers/net/ethernet/marvell/octeontx2/af/mbox.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/marvell/octeontx2/af/mbox.c b/drivers/net/ethernet/marvell/octeontx2/af/mbox.c
index 9690ac01f02c..b92264d0a77e 100644
--- a/drivers/net/ethernet/marvell/octeontx2/af/mbox.c
+++ b/drivers/net/ethernet/marvell/octeontx2/af/mbox.c
@@ -413,4 +413,5 @@ const char *otx2_mbox_id2name(u16 id)
 EXPORT_SYMBOL(otx2_mbox_id2name);
 
 MODULE_AUTHOR("Marvell.");
+MODULE_DESCRIPTION("Marvell RVU NIC Mbox helpers");
 MODULE_LICENSE("GPL v2");
-- 
2.39.3

[PATCH net-next 13/22] net: fill in MODULE_DESCRIPTION()s for encx24j600

[Breno Leitao]

W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to the Microchip ENCX24J600 helpers driver.

Signed-off-by: Breno Leitao <leitao@debian.org>
---
 drivers/net/ethernet/microchip/encx24j600-regmap.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/microchip/encx24j600-regmap.c b/drivers/net/ethernet/microchip/encx24j600-regmap.c
index 5693784eec5b..2e0fe16a4082 100644
--- a/drivers/net/ethernet/microchip/encx24j600-regmap.c
+++ b/drivers/net/ethernet/microchip/encx24j600-regmap.c
@@ -513,4 +513,5 @@ int devm_regmap_init_encx24j600(struct device *dev,
 }
 EXPORT_SYMBOL_GPL(devm_regmap_init_encx24j600);
 
+MODULE_DESCRIPTION("Microchip ENCX24J600 helpers");
 MODULE_LICENSE("GPL");
-- 
2.39.3

[PATCH net-next 14/22] net: fill in MODULE_DESCRIPTION()s for ocelot

[Breno Leitao]

W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to the Ocelot SoCs (VSC7514) helpers driver.

Signed-off-by: Breno Leitao <leitao@debian.org>
---
 drivers/net/ethernet/mscc/ocelot.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/mscc/ocelot.c b/drivers/net/ethernet/mscc/ocelot.c
index 56ccbd4c37fe..12999d9be3af 100644
--- a/drivers/net/ethernet/mscc/ocelot.c
+++ b/drivers/net/ethernet/mscc/ocelot.c
@@ -3078,4 +3078,5 @@ void ocelot_deinit_port(struct ocelot *ocelot, int port)
 }
 EXPORT_SYMBOL(ocelot_deinit_port);
 
+MODULE_DESCRIPTION("Ocelot SoCs (VSC7514) helpers");
 MODULE_LICENSE("Dual MIT/GPL");
-- 
2.39.3

Re: [PATCH net-next 14/22] net: fill in MODULE_DESCRIPTION()s for ocelot

[Horatiu Vultur]

The 01/22/2024 10:45, Breno Leitao wrote:
> W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> Add descriptions to the Ocelot SoCs (VSC7514) helpers driver.
> 
> Signed-off-by: Breno Leitao <leitao@debian.org>

Reviewed-by: Horatiu Vultur <horatiu.vultur@microchip.com>

> ---
>  drivers/net/ethernet/mscc/ocelot.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/mscc/ocelot.c b/drivers/net/ethernet/mscc/ocelot.c
> index 56ccbd4c37fe..12999d9be3af 100644
> --- a/drivers/net/ethernet/mscc/ocelot.c
> +++ b/drivers/net/ethernet/mscc/ocelot.c
> @@ -3078,4 +3078,5 @@ void ocelot_deinit_port(struct ocelot *ocelot, int port)
>  }
>  EXPORT_SYMBOL(ocelot_deinit_port);
> 
> +MODULE_DESCRIPTION("Ocelot SoCs (VSC7514) helpers");
>  MODULE_LICENSE("Dual MIT/GPL");
> --
> 2.39.3
> 

-- 
/Horatiu

Re: [PATCH net-next 14/22] net: fill in MODULE_DESCRIPTION()s for ocelot

[Alexandre Belloni]

Hello,

On 22/01/2024 10:45:35-0800, Breno Leitao wrote:
> W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> Add descriptions to the Ocelot SoCs (VSC7514) helpers driver.
> 
> Signed-off-by: Breno Leitao <leitao@debian.org>
> ---
>  drivers/net/ethernet/mscc/ocelot.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/mscc/ocelot.c b/drivers/net/ethernet/mscc/ocelot.c
> index 56ccbd4c37fe..12999d9be3af 100644
> --- a/drivers/net/ethernet/mscc/ocelot.c
> +++ b/drivers/net/ethernet/mscc/ocelot.c
> @@ -3078,4 +3078,5 @@ void ocelot_deinit_port(struct ocelot *ocelot, int port)
>  }
>  EXPORT_SYMBOL(ocelot_deinit_port);
>  
> +MODULE_DESCRIPTION("Ocelot SoCs (VSC7514) helpers");

Shouldn't that mention that this is related to the Ethernet switch?

>  MODULE_LICENSE("Dual MIT/GPL");
> -- 
> 2.39.3
> 

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [PATCH net-next 14/22] net: fill in MODULE_DESCRIPTION()s for ocelot

[Breno Leitao]

On Tue, Jan 23, 2024 at 08:48:26AM +0100, Alexandre Belloni wrote:
> Hello,
> 
> On 22/01/2024 10:45:35-0800, Breno Leitao wrote:
> > W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> > Add descriptions to the Ocelot SoCs (VSC7514) helpers driver.
> > 
> > Signed-off-by: Breno Leitao <leitao@debian.org>
> > ---
> >  drivers/net/ethernet/mscc/ocelot.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/net/ethernet/mscc/ocelot.c b/drivers/net/ethernet/mscc/ocelot.c
> > index 56ccbd4c37fe..12999d9be3af 100644
> > --- a/drivers/net/ethernet/mscc/ocelot.c
> > +++ b/drivers/net/ethernet/mscc/ocelot.c
> > @@ -3078,4 +3078,5 @@ void ocelot_deinit_port(struct ocelot *ocelot, int port)
> >  }
> >  EXPORT_SYMBOL(ocelot_deinit_port);
> >  
> > +MODULE_DESCRIPTION("Ocelot SoCs (VSC7514) helpers");
> 
> Shouldn't that mention that this is related to the Ethernet switch?

sure. let me update it.

[PATCH net-next 15/22] net: fill in MODULE_DESCRIPTION()s for SMSC drivers

[Breno Leitao]

W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to the SMSC 91x/911x/9420 Ethernet drivers.

Signed-off-by: Breno Leitao <leitao@debian.org>
Please enter the commit message for your changes. Lines starting
---
 drivers/net/ethernet/smsc/smc91x.c   | 1 +
 drivers/net/ethernet/smsc/smsc911x.c | 1 +
 drivers/net/ethernet/smsc/smsc9420.c | 1 +
 3 files changed, 3 insertions(+)

diff --git a/drivers/net/ethernet/smsc/smc91x.c b/drivers/net/ethernet/smsc/smc91x.c
index 758347616535..56836b75d894 100644
--- a/drivers/net/ethernet/smsc/smc91x.c
+++ b/drivers/net/ethernet/smsc/smc91x.c
@@ -98,6 +98,7 @@ static int watchdog = 1000;
 module_param(watchdog, int, 0400);
 MODULE_PARM_DESC(watchdog, "transmit timeout in milliseconds");
 
+MODULE_DESCRIPTION("SMSC LAN911x/LAN921x Ethernet driver");
 MODULE_LICENSE("GPL");
 MODULE_ALIAS("platform:smc91x");
 
diff --git a/drivers/net/ethernet/smsc/smsc911x.c b/drivers/net/ethernet/smsc/smsc911x.c
index 31cb7d0166f0..cb04746bc0dd 100644
--- a/drivers/net/ethernet/smsc/smsc911x.c
+++ b/drivers/net/ethernet/smsc/smsc911x.c
@@ -56,6 +56,7 @@
 #define SMSC_MDIONAME		"smsc911x-mdio"
 #define SMSC_DRV_VERSION	"2008-10-21"
 
+MODULE_DESCRIPTION("SMSC LAN9420 Ethernet driver");
 MODULE_LICENSE("GPL");
 MODULE_VERSION(SMSC_DRV_VERSION);
 MODULE_ALIAS("platform:smsc911x");
diff --git a/drivers/net/ethernet/smsc/smsc9420.c b/drivers/net/ethernet/smsc/smsc9420.c
index e1c4a11c1f18..15cb96c2506d 100644
--- a/drivers/net/ethernet/smsc/smsc9420.c
+++ b/drivers/net/ethernet/smsc/smsc9420.c
@@ -26,6 +26,7 @@
 #define DRV_DESCRIPTION		"SMSC LAN9420 driver"
 #define DRV_VERSION		"1.01"
 
+MODULE_DESCRIPTION("SMSC LAN9420 Ethernet driver");
 MODULE_LICENSE("GPL");
 MODULE_VERSION(DRV_VERSION);
 
-- 
2.39.3

Re: [PATCH net-next 15/22] net: fill in MODULE_DESCRIPTION()s for SMSC drivers

[Andy Shevchenko]

On Mon, Jan 22, 2024 at 10:45:36AM -0800, Breno Leitao wrote:
> W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> Add descriptions to the SMSC 91x/911x/9420 Ethernet drivers.
> 
> Signed-off-by: Breno Leitao <leitao@debian.org>

> Please enter the commit message for your changes. Lines starting

Misplaced line.

-- 
With Best Regards,
Andy Shevchenko

[PATCH net-next 16/22] net: fill in MODULE_DESCRIPTION()s for Qualcom drivers

[Breno Leitao]

W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to the Qualcom rmnet and emac drivers.

Signed-off-by: Breno Leitao <leitao@debian.org>
---
 drivers/net/ethernet/qualcomm/emac/emac.c          | 1 +
 drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c | 1 +
 2 files changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/qualcomm/emac/emac.c b/drivers/net/ethernet/qualcomm/emac/emac.c
index 3270df72541b..4c06f55878de 100644
--- a/drivers/net/ethernet/qualcomm/emac/emac.c
+++ b/drivers/net/ethernet/qualcomm/emac/emac.c
@@ -771,5 +771,6 @@ static struct platform_driver emac_platform_driver = {
 
 module_platform_driver(emac_platform_driver);
 
+MODULE_DESCRIPTION("Qualcomm EMAC Gigabit Ethernet driver");
 MODULE_LICENSE("GPL v2");
 MODULE_ALIAS("platform:qcom-emac");
diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c b/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c
index 5b69b9268c75..f3bea196a8f9 100644
--- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c
+++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c
@@ -520,4 +520,5 @@ static void __exit rmnet_exit(void)
 module_init(rmnet_init)
 module_exit(rmnet_exit)
 MODULE_ALIAS_RTNL_LINK("rmnet");
+MODULE_DESCRIPTION("Qualcomm RmNet MAP driver");
 MODULE_LICENSE("GPL v2");
-- 
2.39.3

Re: [PATCH net-next 16/22] net: fill in MODULE_DESCRIPTION()s for Qualcom drivers

[Subash Abhinov Kasiviswanathan (KS)]

On 1/22/2024 11:45 AM, Breno Leitao wrote:
> W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> Add descriptions to the Qualcom rmnet and emac drivers.
> 
> Signed-off-by: Breno Leitao <leitao@debian.org>
> ---
>   drivers/net/ethernet/qualcomm/emac/emac.c          | 1 +
>   drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c | 1 +
>   2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ethernet/qualcomm/emac/emac.c b/drivers/net/ethernet/qualcomm/emac/emac.c
> index 3270df72541b..4c06f55878de 100644
> --- a/drivers/net/ethernet/qualcomm/emac/emac.c
> +++ b/drivers/net/ethernet/qualcomm/emac/emac.c
> @@ -771,5 +771,6 @@ static struct platform_driver emac_platform_driver = {
>   
>   module_platform_driver(emac_platform_driver);
>   
> +MODULE_DESCRIPTION("Qualcomm EMAC Gigabit Ethernet driver");
>   MODULE_LICENSE("GPL v2");
>   MODULE_ALIAS("platform:qcom-emac");
> diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c b/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c
> index 5b69b9268c75..f3bea196a8f9 100644
> --- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c
> +++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c
> @@ -520,4 +520,5 @@ static void __exit rmnet_exit(void)
>   module_init(rmnet_init)
>   module_exit(rmnet_exit)
>   MODULE_ALIAS_RTNL_LINK("rmnet");
> +MODULE_DESCRIPTION("Qualcomm RmNet MAP driver");
>   MODULE_LICENSE("GPL v2");

For rmnet

Reviewed-by: Subash Abhinov Kasiviswanathan <quic_subashab@quicinc.com>

[PATCH net-next 20/22] net: fill in MODULE_DESCRIPTION()s for dwmac-socfpga

[Breno Leitao]

W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to the STMicro DWMAC for Altera SOCs.

Signed-off-by: Breno Leitao <leitao@debian.org>
---
 drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
index ba2ce776bd4d..68f85e4605cb 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
@@ -585,4 +585,5 @@ static struct platform_driver socfpga_dwmac_driver = {
 };
 module_platform_driver(socfpga_dwmac_driver);
 
+MODULE_DESCRIPTION("Altera SOC DWMAC Specific Glue layer");
 MODULE_LICENSE("GPL v2");
-- 
2.39.3

[PATCH net-next 21/22] net: fill in MODULE_DESCRIPTION()s for cpsw-common

[Breno Leitao]

W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to the TI CPSW switch module.

Signed-off-by: Breno Leitao <leitao@debian.org>
---
 drivers/net/ethernet/ti/cpsw-common.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/ti/cpsw-common.c b/drivers/net/ethernet/ti/cpsw-common.c
index 26dc906eae90..57fe936bb177 100644
--- a/drivers/net/ethernet/ti/cpsw-common.c
+++ b/drivers/net/ethernet/ti/cpsw-common.c
@@ -90,4 +90,5 @@ int ti_cm_get_macid(struct device *dev, int slave, u8 *mac_addr)
 }
 EXPORT_SYMBOL_GPL(ti_cm_get_macid);
 
+MODULE_DESCRIPTION("TI CPSW Switch common module");
 MODULE_LICENSE("GPL");
-- 
2.39.3

Re: [PATCH net-next 21/22] net: fill in MODULE_DESCRIPTION()s for cpsw-common

[Roger Quadros]

On 22/01/2024 20:45, Breno Leitao wrote:
> W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> Add descriptions to the TI CPSW switch module.
> 
> Signed-off-by: Breno Leitao <leitao@debian.org>
> ---
>  drivers/net/ethernet/ti/cpsw-common.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/ti/cpsw-common.c b/drivers/net/ethernet/ti/cpsw-common.c
> index 26dc906eae90..57fe936bb177 100644
> --- a/drivers/net/ethernet/ti/cpsw-common.c
> +++ b/drivers/net/ethernet/ti/cpsw-common.c
> @@ -90,4 +90,5 @@ int ti_cm_get_macid(struct device *dev, int slave, u8 *mac_addr)
>  }
>  EXPORT_SYMBOL_GPL(ti_cm_get_macid);
>  
> +MODULE_DESCRIPTION("TI CPSW Switch common module");
>  MODULE_LICENSE("GPL");

Reviewed-by: Roger Quadros <rogerq@kernel.org>

-- 
cheers,
-roger

[PATCH net-next 22/22] net: fill in MODULE_DESCRIPTION()s for ec_bhf

[Breno Leitao]

W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to the Beckhoff CX5020 EtherCAT Ethernet driver.

Signed-off-by: Breno Leitao <leitao@debian.org>
---
 drivers/net/ethernet/ec_bhf.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/ec_bhf.c b/drivers/net/ethernet/ec_bhf.c
index c2c5c589a5e3..44af1d13d931 100644
--- a/drivers/net/ethernet/ec_bhf.c
+++ b/drivers/net/ethernet/ec_bhf.c
@@ -590,5 +590,6 @@ module_pci_driver(pci_driver);
 module_param(polling_frequency, long, 0444);
 MODULE_PARM_DESC(polling_frequency, "Polling timer frequency in ns");
 
+MODULE_DESCRIPTION("Beckhoff CX5020 EtherCAT Ethernet driver");
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Dariusz Marcinkiewicz <reksio@newterm.pl>");
-- 
2.39.3

Re: [PATCH net-next 00/22] Fix MODULE_DESCRIPTION() for net (p2)

[Jakub Kicinski]

On Mon, 22 Jan 2024 10:45:21 -0800 Breno Leitao wrote:
>   net: fill in MODULE_DESCRIPTION()s for Broadcom WLAN
>   net: fill in MODULE_DESCRIPTION()s for wlcore
>   net: fill in MODULE_DESCRIPTION()s for wl1251 and wl12xx

Thanks for making progress on these!

When you repost:
 - please send these 3 to linux-wireless as a separate series
 - make sure mailing lists are CCed on the cover letter
   (yes, get_maintainer is embarrassingly bad at its job)
 - please send 10 at-a-time, it's probably a good tradeoff
   between series size and reposting risk
 - please target net, I hope I convinced Paolo that it's okay :)

Re: [PATCH net-next 00/22] Fix MODULE_DESCRIPTION() for net (p2)

[Breno Leitao]

On Mon, Jan 22, 2024 at 10:57:08AM -0800, Jakub Kicinski wrote:
> On Mon, 22 Jan 2024 10:45:21 -0800 Breno Leitao wrote:
> >   net: fill in MODULE_DESCRIPTION()s for Broadcom WLAN
> >   net: fill in MODULE_DESCRIPTION()s for wlcore
> >   net: fill in MODULE_DESCRIPTION()s for wl1251 and wl12xx
> 
> Thanks for making progress on these!
> 
> When you repost:
>  - please send these 3 to linux-wireless as a separate series
>  - make sure mailing lists are CCed on the cover letter
>    (yes, get_maintainer is embarrassingly bad at its job)
>  - please send 10 at-a-time, it's probably a good tradeoff
>    between series size and reposting risk
>  - please target net, I hope I convinced Paolo that it's okay :)

Sure. I will split this series in 3 and target `net`.

I suppose it is OK to send the patchsets in parallel, instead of waiting
for the first patchset to be reviewed/accepted before sending the second
part. Is this correct?

Thanks!

Re: [PATCH net-next 00/22] Fix MODULE_DESCRIPTION() for net (p2)

[Jakub Kicinski]

On Tue, 23 Jan 2024 08:25:28 -0800 Breno Leitao wrote:
> > When you repost:
> >  - please send these 3 to linux-wireless as a separate series
> >  - make sure mailing lists are CCed on the cover letter
> >    (yes, get_maintainer is embarrassingly bad at its job)
> >  - please send 10 at-a-time, it's probably a good tradeoff
> >    between series size and reposting risk
> >  - please target net, I hope I convinced Paolo that it's okay :)  
> 
> Sure. I will split this series in 3 and target `net`.

The wireless ones need to target wireless, just to be clear.
The rest should fit into 2 series.

> I suppose it is OK to send the patchsets in parallel, instead of waiting
> for the first patchset to be reviewed/accepted before sending the second
> part. Is this correct?

The rate limit is to avoid having to give the same feedback to multiple
series, among other things. it'd be better to send one part at a time..
it won't take that long :)

Re: [PATCH net-next 00/22] Fix MODULE_DESCRIPTION() for net (p2)

[Breno Leitao]

On Tue, Jan 23, 2024 at 08:35:17AM -0800, Jakub Kicinski wrote:
> On Tue, 23 Jan 2024 08:25:28 -0800 Breno Leitao wrote:
> > > When you repost:
> > >  - please send these 3 to linux-wireless as a separate series
> > >  - make sure mailing lists are CCed on the cover letter
> > >    (yes, get_maintainer is embarrassingly bad at its job)
> > >  - please send 10 at-a-time, it's probably a good tradeoff
> > >    between series size and reposting risk
> > >  - please target net, I hope I convinced Paolo that it's okay :)  
> > 
> > Sure. I will split this series in 3 and target `net`.
> 
> The wireless ones need to target wireless, just to be clear.
> The rest should fit into 2 series.
> 
> > I suppose it is OK to send the patchsets in parallel, instead of waiting
> > for the first patchset to be reviewed/accepted before sending the second
> > part. Is this correct?
> 
> The rate limit is to avoid having to give the same feedback to multiple
> series, among other things. it'd be better to send one part at a time..
> it won't take that long :)

Sure. Thanks for the clarifications!