netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hangbin Liu <liuhangbin@gmail.com>
To: Jay Vosburgh <jay.vosburgh@canonical.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
	Benjamin Poirier <bpoirier@nvidia.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [TEST] bond_options.sh looks flaky
Date: Tue, 23 Jan 2024 15:17:58 +0800	[thread overview]
Message-ID: <Za9oJmof6QYVHw52@Laptop-X1> (raw)
In-Reply-To: <Za8439kp8oPxwb7M@Laptop-X1>

On Tue, Jan 23, 2024 at 11:56:15AM +0800, Hangbin Liu wrote:
> > 3) I'm not sure why this test fails, but the prior test that claims to
> > be active-backup does not, even though both appear to be actually
> > testing active-backup.  The log entries for the actual "prio
> > (active-backup arp_ip_target primary_reselect 1)" test start at time
> > 281.913374, and differ from the failing test starting at 715.597039.
> 
> From the passed log
> 
> [  505.516927] br0: port 2(s1) entered disabled state
> [  505.773009] bond0: (slave eth1): link status definitely down, disabling slave
> [  505.773593] bond0: (slave eth2): making interface the new active one
> 
> While the failed log
> [  723.603062] br0: port 4(s2) entered disabled state
> [  723.868750] bond0: (slave eth2): link status definitely down, disabling slave
> [  723.869104] bond0: (slave eth1): making interface the new active one
> 
> It looks the wrong active link was set. It should be eth1 but set to eth2.
> So the later link operation set eth2 link down. Not sure why eth2 was set to
> active interface. I need to print log immediately if check_err failed.

Ah, the log did print the error message:

# TEST: prio (balance-alb arp_ip_target primary_reselect 1)           [FAIL]
# Current active slave is eth2 but not eth1

From the log, not sure why eth0/eth1 down and thus the eth2 become the active
one.

[  716.115869] bond0: (slave eth1): making interface the new active one
[  716.116914] bond0: (slave eth1): Enslaving as an active interface with an up link
[  716.117792] br0: port 2(s1) entered blocking state
[  716.118022] br0: port 2(s1) entered forwarding state
[  716.234644] bond0: (slave eth2): Enslaving as a backup interface with an up link
[  716.235716] br0: port 4(s2) entered blocking state
[  716.235926] br0: port 4(s2) entered forwarding state
[  716.373537] bond0: (slave eth0): link status definitely down, disabling slave
[  716.374651] bond0: (slave eth1): link status definitely down, disabling slave
[  716.374920] bond0: (slave eth2): making interface the new active one
[  716.484168] bond0: (slave eth0): link status definitely up
[  716.484909] bond0: (slave eth1): link status definitely up


For other passed test you can see the eth0/eth1 was not set to down. So eth1
keep as the active one.

[  498.558083] bond0: (slave eth1): making interface the new active one
[  498.558973] bond0: (slave eth1): Enslaving as an active interface with an up link
[  498.559724] br0: port 2(s1) entered blocking state
[  498.559962] br0: port 2(s1) entered forwarding state
[  498.632107] bond0: (slave eth2): Enslaving as a backup interface with an up link
[  498.636366] br0: port 4(s2) entered blocking state
[  498.636684] br0: port 4(s2) entered forwarding state

Thanks
Hangbin

      reply	other threads:[~2024-01-23  7:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-22 21:55 [TEST] bond_options.sh looks flaky Jakub Kicinski
2024-01-22 23:25 ` Jay Vosburgh
2024-01-23  3:56   ` Hangbin Liu
2024-01-23  7:17     ` Hangbin Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Za9oJmof6QYVHw52@Laptop-X1 \
    --to=liuhangbin@gmail.com \
    --cc=bpoirier@nvidia.com \
    --cc=jay.vosburgh@canonical.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).