From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Jiawen Wu <jiawenwu@trustnetic.com>,
Mengyuan Lou <mengyuanlou@net-swift.com>,
Jakub Kicinski <kuba@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Andrew Lunn <andrew@lunn.ch>,
Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wangxunx: select CONFIG_PHYLINK where needed
Date: Thu, 11 Jan 2024 15:49:43 +0000 [thread overview]
Message-ID: <ZaAOF/esan+HnufM@shell.armlinux.org.uk> (raw)
In-Reply-To: <ZZ0TdiIDE2lqHE+8@shell.armlinux.org.uk>
On Tue, Jan 09, 2024 at 09:35:50AM +0000, Russell King (Oracle) wrote:
> On Tue, Jan 09, 2024 at 08:56:21AM +0100, Arnd Bergmann wrote:
> > diff --git a/drivers/net/ethernet/wangxun/Kconfig b/drivers/net/ethernet/wangxun/Kconfig
> > index 23cd610bd376..46630f05d8dd 100644
> > --- a/drivers/net/ethernet/wangxun/Kconfig
> > +++ b/drivers/net/ethernet/wangxun/Kconfig
> > @@ -26,6 +26,7 @@ config NGBE
> > tristate "Wangxun(R) GbE PCI Express adapters support"
> > depends on PCI
> > select LIBWX
> > + select PHYLINK
> > select PHYLIB
>
> You can drop PHYLIB when adding PHYLINK.
Arnd,
There are repeated complaints from the kernel build bot about this, and
it would be good to get it solved. Could we have an updated patch
submitted to netdev please? This is in net-next only at the moment,
so I think that means it needs to be submitted with:
[PATCH net-next ...]
and please make it clear that it is a fix for code only in net-next.
(However, netdev folk may request it to be referred until net-next is
merged and then against the net tree...)
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2024-01-11 15:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-09 7:56 [PATCH] wangxunx: select CONFIG_PHYLINK where needed Arnd Bergmann
2024-01-09 8:38 ` Jiawen Wu
2024-01-09 9:35 ` Russell King (Oracle)
2024-01-11 15:49 ` Russell King (Oracle) [this message]
2024-01-11 16:29 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZaAOF/esan+HnufM@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiawenwu@trustnetic.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).