From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05B824CDE9; Thu, 11 Jan 2024 15:50:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="p8TWB1u4" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=SXSMgPvMG1CFS/vVmNC+AEGMC+mPoePNedwOvprq5p4=; b=p8TWB1u4BW/lAVnu4oUzzYpbM6 +aSgn62SfVcrxtWrnRiH1ZBBIYTxVpREw2RrtEUsrYKEIsi/RvOU+ErhrhEH7Z9yUljXDS/e5ZX4n nm5edQpJTeUukcYcvt/8fTCOUlH+KUAImWdnjmriYOaQ31etZENvjMSItVpt62HAFV9jE40K/2B8y VnEJ1X76NkH8oixaGE2kGB04MNbSxqVcFPt2OMBJtvGLaTUlRc+Y/z3kw0MlGj4q/suNyK9gOnv+r Tap60Wah3r675cvaQKJhXJbKUsV2SygULeIqwjOpUlbBqo/NB1SH6ImsDbAOlsjw019g/ktd4loWG nT3CfRlw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:56152) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rNxJS-0006iZ-32; Thu, 11 Jan 2024 15:49:46 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1rNxJP-0006Ts-R5; Thu, 11 Jan 2024 15:49:44 +0000 Date: Thu, 11 Jan 2024 15:49:43 +0000 From: "Russell King (Oracle)" To: Arnd Bergmann Cc: Jiawen Wu , Mengyuan Lou , Jakub Kicinski , Arnd Bergmann , "David S. Miller" , Eric Dumazet , Paolo Abeni , Andrew Lunn , Maciej Fijalkowski , Andy Shevchenko , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] wangxunx: select CONFIG_PHYLINK where needed Message-ID: References: <20240109075656.2656359-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Russell King (Oracle) On Tue, Jan 09, 2024 at 09:35:50AM +0000, Russell King (Oracle) wrote: > On Tue, Jan 09, 2024 at 08:56:21AM +0100, Arnd Bergmann wrote: > > diff --git a/drivers/net/ethernet/wangxun/Kconfig b/drivers/net/ethernet/wangxun/Kconfig > > index 23cd610bd376..46630f05d8dd 100644 > > --- a/drivers/net/ethernet/wangxun/Kconfig > > +++ b/drivers/net/ethernet/wangxun/Kconfig > > @@ -26,6 +26,7 @@ config NGBE > > tristate "Wangxun(R) GbE PCI Express adapters support" > > depends on PCI > > select LIBWX > > + select PHYLINK > > select PHYLIB > > You can drop PHYLIB when adding PHYLINK. Arnd, There are repeated complaints from the kernel build bot about this, and it would be good to get it solved. Could we have an updated patch submitted to netdev please? This is in net-next only at the moment, so I think that means it needs to be submitted with: [PATCH net-next ...] and please make it clear that it is a fix for code only in net-next. (However, netdev folk may request it to be referred until net-next is merged and then against the net tree...) Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!