From: Hangbin Liu <liuhangbin@gmail.com>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>, Phil Sutter <phil@nwl.cc>,
David Ahern <dsahern@kernel.org>, Jiri Pirko <jiri@resnulli.us>,
netdev@vger.kernel.org
Subject: Re: [PATCH net v4 2/2] selftests: rtnetlink: check enslaving iface in a bond
Date: Fri, 12 Jan 2024 09:15:14 +0800 [thread overview]
Message-ID: <ZaCSog00Bj8GmOZ4@Laptop-X1> (raw)
In-Reply-To: <20240108094103.2001224-3-nicolas.dichtel@6wind.com>
On Mon, Jan 08, 2024 at 10:41:03AM +0100, Nicolas Dichtel wrote:
> The goal is to check the following two sequences:
> > ip link set dummy0 up
> > ip link set dummy0 master bond0 down
>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> ---
> tools/testing/selftests/net/rtnetlink.sh | 28 ++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> diff --git a/tools/testing/selftests/net/rtnetlink.sh b/tools/testing/selftests/net/rtnetlink.sh
> index 26827ea4e3e5..bbf9d2bd3d7b 100755
> --- a/tools/testing/selftests/net/rtnetlink.sh
> +++ b/tools/testing/selftests/net/rtnetlink.sh
> @@ -28,6 +28,7 @@ ALL_TESTS="
> kci_test_neigh_get
> kci_test_bridge_parent_id
> kci_test_address_proto
> + kci_test_enslave_bonding
> "
>
> devdummy="test-dummy0"
> @@ -1239,6 +1240,33 @@ kci_test_address_proto()
> return $ret
> }
>
> +kci_test_enslave_bonding()
> +{
> + local testns="testns"
> + local bond="bond123"
> + local dummy="dummy123"
> + local ret=0
> +
> + run_cmd ip netns add "$testns"
> + if [ $ret -ne 0 ]; then
> + end_test "SKIP bonding tests: cannot add net namespace $testns"
> + return $ksft_skip
> + fi
> +
> + run_cmd ip -netns $testns link add dev $bond type bond mode balance-rr
Hi Nicolas,
FYI, the selftests/net/lib.sh has been merged to net tree. Please remember
send a following up update to create the netns with setup_ns.
Thanks
Hangbin
next prev parent reply other threads:[~2024-01-12 1:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-08 9:41 [PATCH net v4 0/2] rtnetlink: allow to enslave with one msg an up interface Nicolas Dichtel
2024-01-08 9:41 ` [PATCH net v4 1/2] Revert "net: rtnetlink: Enslave device before bringing it up" Nicolas Dichtel
2024-01-08 10:29 ` Jiri Pirko
2024-01-09 3:38 ` Hangbin Liu
2024-01-08 9:41 ` [PATCH net v4 2/2] selftests: rtnetlink: check enslaving iface in a bond Nicolas Dichtel
2024-01-08 10:31 ` Jiri Pirko
2024-01-12 1:15 ` Hangbin Liu [this message]
2024-01-12 8:06 ` Nicolas Dichtel
2024-01-12 9:38 ` Hangbin Liu
2024-01-12 1:00 ` [PATCH net v4 0/2] rtnetlink: allow to enslave with one msg an up interface patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZaCSog00Bj8GmOZ4@Laptop-X1 \
--to=liuhangbin@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pabeni@redhat.com \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).