From: Jiri Pirko <jiri@resnulli.us>
To: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
Cc: netdev@vger.kernel.org, vadim.fedorenko@linux.dev,
davem@davemloft.net, milena.olech@intel.com,
linux-kernel@vger.kernel.org, pabeni@redhat.com, kuba@kernel.org,
mschmidt@redhat.com, Jan Glaza <jan.glaza@intel.com>
Subject: Re: [PATCH net v3 3/3] dpll: fix userspace availability of pins
Date: Tue, 16 Jan 2024 08:46:52 +0100 [thread overview]
Message-ID: <ZaY0bL73kDYgqh2R@nanopsycho> (raw)
In-Reply-To: <20240115085241.312144-4-arkadiusz.kubalewski@intel.com>
Mon, Jan 15, 2024 at 09:52:41AM CET, arkadiusz.kubalewski@intel.com wrote:
>If parent pin was unregistered but child pin was not, the userspace
>would see the "zombie" pins - the ones that were registered with
>a parent pin (dpll_pin_on_pin_register(..)).
>Technically those are not available - as there is no dpll device in the
>system. Do not dump those pins and prevent userspace from any
>interaction with them. Provide a unified function to determine if the
>pin is available and use it before acting/responding for user requests.
>
>Fixes: 9431063ad323 ("dpll: core: Add DPLL framework base functions")
>Fixes: 9d71b54b65b1 ("dpll: netlink: Add DPLL framework base functions")
>Reviewed-by: Jan Glaza <jan.glaza@intel.com>
>Signed-off-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
The patch looks fine, but it should come before the previous one.
pw-bot: cr
Feel free to attach the review tag to the next version you send:
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
next prev parent reply other threads:[~2024-01-16 7:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-15 8:52 [PATCH net v3 0/3] dpll: fix unordered unbind/bind registerer issues Arkadiusz Kubalewski
2024-01-15 8:52 ` [PATCH net v3 1/3] dpll: fix pin dump crash for rebound module Arkadiusz Kubalewski
2024-01-15 19:23 ` Jiri Pirko
2024-01-17 9:22 ` Kubalewski, Arkadiusz
2024-01-15 8:52 ` [PATCH net v3 2/3] dpll: fix register pin with unregistered parent pin Arkadiusz Kubalewski
2024-01-16 7:42 ` Jiri Pirko
2024-01-17 9:19 ` Kubalewski, Arkadiusz
2024-01-15 8:52 ` [PATCH net v3 3/3] dpll: fix userspace availability of pins Arkadiusz Kubalewski
2024-01-16 7:46 ` Jiri Pirko [this message]
2024-01-17 9:18 ` Kubalewski, Arkadiusz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZaY0bL73kDYgqh2R@nanopsycho \
--to=jiri@resnulli.us \
--cc=arkadiusz.kubalewski@intel.com \
--cc=davem@davemloft.net \
--cc=jan.glaza@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=milena.olech@intel.com \
--cc=mschmidt@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox