From: Benjamin Poirier <bpoirier@nvidia.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Jay Vosburgh <jay.vosburgh@canonical.com>,
Hangbin Liu <liuhangbin@gmail.com>,
netdev@vger.kernel.org, Andy Gospodarek <andy@greyhouse.net>,
Shuah Khan <shuah@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Jonathan Toppins <jon.toppins+linux@gmail.com>,
Nikolay Aleksandrov <razor@blackwall.org>,
Michal Kubiak <michal.kubiak@intel.com>,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net] selftests: bonding: Add more missing config options
Date: Tue, 16 Jan 2024 14:47:46 -0500 [thread overview]
Message-ID: <ZabdYhBRHiNt-jGy@d3> (raw)
In-Reply-To: <20240116112926.541e0651@kernel.org>
On 2024-01-16 11:29 -0800, Jakub Kicinski wrote:
> On Tue, 16 Jan 2024 14:21:51 -0500 Benjamin Poirier wrote:
> > real 13m35.065s
> > user 0m1.657s
> > sys 0m27.918s
> >
> > The test is not cpu bound; as Jay pointed out, it spends most of its
> > time sleeping.
>
> Ugh, so it does multiple iterations of 118 sec?
There are other test functions in the script which include a lot of
sleeping.
> Could you send a patch to bump the timeout to 900 or 1200 in this case?
Sure but I'd like to give a chance for Hangbin to reply first. Would the
test be just as good if it was shortened by removing some cases or
reducing the time intervals? Or is increasing the timeout the best
approach?
next prev parent reply other threads:[~2024-01-16 19:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 15:49 [PATCH net] selftests: bonding: Add more missing config options Benjamin Poirier
2024-01-16 18:44 ` Jakub Kicinski
2024-01-16 19:03 ` Jay Vosburgh
2024-01-16 19:20 ` Jakub Kicinski
2024-01-16 19:21 ` Benjamin Poirier
2024-01-16 19:29 ` Jakub Kicinski
2024-01-16 19:43 ` Jay Vosburgh
2024-01-16 19:47 ` Benjamin Poirier [this message]
2024-01-17 3:15 ` Hangbin Liu
2024-01-18 0:16 ` Benjamin Poirier
2024-01-18 11:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZabdYhBRHiNt-jGy@d3 \
--to=bpoirier@nvidia.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=jay.vosburgh@canonical.com \
--cc=jon.toppins+linux@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=michal.kubiak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=razor@blackwall.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).