From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Andre Werner <andre.werner@systec-electronic.com>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: phy: adin1100: Fix nullptr exception for phy interrupts
Date: Thu, 18 Jan 2024 23:34:05 +0000 [thread overview]
Message-ID: <Zam1bWV+yZqq07FR@shell.armlinux.org.uk> (raw)
In-Reply-To: <70a4f7de-6032-4247-a484-56d1fdcee7f8@gmail.com>
On Thu, Jan 18, 2024 at 10:24:03PM +0100, Heiner Kallweit wrote:
> This would save us here, but can't prevent that phydev->irq may be set
> even later. I think, ideally nobody should ever access phydev->irq directly.
> There should be a setter which performs the needed checks.
> But it may be a longer journey to make parts of struct phy_device private
> to phylib.
Yes, I have been thinking over the last couple of days through reading
these emails that's a path that's needed to go down to stop drivers
poking around in stuff that should be private to phylib. So it's
something I would support.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2024-01-18 23:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 10:43 [PATCH] net: phy: adin1100: Fix nullptr exception for phy interrupts Andre Werner
2024-01-18 16:53 ` Andrew Lunn
2024-01-18 17:36 ` Heiner Kallweit
2024-01-18 20:09 ` Andrew Lunn
2024-01-18 21:24 ` Heiner Kallweit
2024-01-18 23:34 ` Russell King (Oracle) [this message]
2024-01-19 6:30 ` Andre Werner
2024-01-18 17:20 ` Russell King (Oracle)
2024-01-19 3:05 ` Andre Werner
2024-01-19 9:56 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zam1bWV+yZqq07FR@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andre.werner@systec-electronic.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).