netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
	pabeni@redhat.com, "Марк Коренберг" <socketpair@gmail.com>,
	daniel@iogearbox.net, lucien.xin@gmail.com,
	johannes.berg@intel.com
Subject: Re: [PATCH net] net: fix removing a namespace with conflicting altnames
Date: Fri, 19 Jan 2024 16:15:49 +0100	[thread overview]
Message-ID: <ZaqSJU1FzvNAKBiH@nanopsycho> (raw)
In-Reply-To: <20240119005859.3274782-1-kuba@kernel.org>

Fri, Jan 19, 2024 at 01:58:59AM CET, kuba@kernel.org wrote:
>Mark reports a BUG() when a net namespace is removed.
>
>    kernel BUG at net/core/dev.c:11520!
>
>Physical interfaces moved outside of init_net get "refunded"
>to init_net when that namespace disappears. The main interface
>name may get overwritten in the process if it would have
>conflicted. We need to also discard all conflicting altnames.
>Recent fixes addressed ensuring that altnames get moved
>with the main interface, which surfaced this problem.
>
>Reported-by: Марк Коренберг <socketpair@gmail.com>
>Link: https://lore.kernel.org/all/CAEmTpZFZ4Sv3KwqFOY2WKDHeZYdi0O7N5H1nTvcGp=SAEavtDg@mail.gmail.com/
>Fixes: 7663d522099e ("net: check for altname conflicts when changing netdev's netns")
>Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Reviewed-by: Jiri Pirko <jiri@nvidia.com>

  parent reply	other threads:[~2024-01-19 15:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-19  0:58 [PATCH net] net: fix removing a namespace with conflicting altnames Jakub Kicinski
2024-01-19 13:23 ` Eric Dumazet
2024-01-19 15:15 ` Jiri Pirko [this message]
2024-01-19 16:18 ` Xin Long
2024-01-22  1:34 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZaqSJU1FzvNAKBiH@nanopsycho \
    --to=jiri@resnulli.us \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=johannes.berg@intel.com \
    --cc=kuba@kernel.org \
    --cc=lucien.xin@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=socketpair@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).