From: Sabrina Dubroca <sd@queasysnail.net>
To: Rahul Rameshbabu <rrameshbabu@nvidia.com>
Cc: netdev@vger.kernel.org, Gal Pressman <gal@nvidia.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
Radu Pirea <radu-nicolae.pirea@oss.nxp.com>,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH net v2 2/2] net: macsec: Only require headroom/tailroom from offload implementer if .mdo_insert_tx_tag is implemented
Date: Sun, 21 Jan 2024 10:29:08 +0100 [thread overview]
Message-ID: <Zazj5KI7BZPnLoc2@hog> (raw)
In-Reply-To: <20240118191811.50271-2-rrameshbabu@nvidia.com>
2024-01-18, 11:18:07 -0800, Rahul Rameshbabu wrote:
> A number of MACsec offload implementers do not implement
> .mdo_insert_tx_tag. These implementers also do not specify the needed
> headroom/tailroom and depend on the default in the core MACsec stack.
FWIW, I had the same concern when Radu submitted these changes, and he
answered that the extra room was only needed for SW, not for offload:
https://lore.kernel.org/all/a5ef22bc-2457-5eef-7cff-529711c5c242@oss.nxp.com/
I'm not really objecting to this patch, but is it fixing a bug? If so,
it would be useful to describe the problem you're seeing in the commit
message for this change.
Does your driver require the default headroom/tailroom?
> Fixes: a73d8779d61a ("net: macsec: introduce mdo_insert_tx_tag")
> Cc: Radu Pirea (NXP OSS) <radu-nicolae.pirea@oss.nxp.com>
> Cc: David S. Miller <davem@davemloft.net>
> Cc: Sabrina Dubroca <sd@queasysnail.net>
> Signed-off-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
--
Sabrina
next prev parent reply other threads:[~2024-01-21 9:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 19:18 [PATCH net v2 1/2] Revert "net: macsec: use skb_ensure_writable_head_tail to expand the skb" Rahul Rameshbabu
2024-01-18 19:18 ` [PATCH net v2 2/2] net: macsec: Only require headroom/tailroom from offload implementer if .mdo_insert_tx_tag is implemented Rahul Rameshbabu
2024-01-21 9:29 ` Sabrina Dubroca [this message]
2024-01-22 18:06 ` Rahul Rameshbabu
2024-01-21 9:32 ` [PATCH net v2 1/2] Revert "net: macsec: use skb_ensure_writable_head_tail to expand the skb" Sabrina Dubroca
2024-01-23 9:19 ` Paolo Abeni
2024-01-23 16:27 ` Rahul Rameshbabu
2024-01-24 1:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zazj5KI7BZPnLoc2@hog \
--to=sd@queasysnail.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=radu-nicolae.pirea@oss.nxp.com \
--cc=rrameshbabu@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).