From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-44.mimecast.com (us-smtp-delivery-44.mimecast.com [205.139.111.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B48EF1368 for ; Sun, 21 Jan 2024 09:32:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.139.111.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705829533; cv=none; b=o8uazUNzIm/6+42lUAOPDe+KE9ghfe2z1qdiG5mHMXrVv3+lP/Np5ClWXotDfQbMgGo1Xs4fFlncLcucNMHq9LOHHZBV7lY0zy640aJqfM8XIPkwcLtSc0rRH3+wCFIoRl21flOLRpWL2x4B0wITxmaTqBYiA1rJpH1Czum5yyw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705829533; c=relaxed/simple; bh=KNn/uBDa3sKbPtyuVUoJVxKNsQfOdkf5N6Ufcc0JdHo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: In-Reply-To:Content-Type:Content-Disposition; b=YqqLQUhVwuRjLjdXU7XcbsZ0GOYfYrHa1fC0zDynGfKXyII6h99L/fs9HeIpHLDYUoknqgI5w1HBKHHhZ88reH45DPYP1pqSj3gMa+k9HK5ja+Lj3v/YZ/lYe2MWSMK+aP/X0z317SymUoj3iP6c+l/IAHi09vXhtLyq6BvU7/U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net; spf=none smtp.mailfrom=queasysnail.net; arc=none smtp.client-ip=205.139.111.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=queasysnail.net Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-356-SCN7Z-GyPnKEKci58kq5lA-1; Sun, 21 Jan 2024 04:32:07 -0500 X-MC-Unique: SCN7Z-GyPnKEKci58kq5lA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4924C85A588; Sun, 21 Jan 2024 09:32:07 +0000 (UTC) Received: from hog (unknown [10.39.192.65]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BCABF1C05E0E; Sun, 21 Jan 2024 09:32:05 +0000 (UTC) Date: Sun, 21 Jan 2024 10:32:04 +0100 From: Sabrina Dubroca To: Rahul Rameshbabu Cc: netdev@vger.kernel.org, Gal Pressman , Jakub Kicinski , Paolo Abeni , Eric Dumazet , Radu Pirea , "David S . Miller" Subject: Re: [PATCH net v2 1/2] Revert "net: macsec: use skb_ensure_writable_head_tail to expand the skb" Message-ID: References: <20240118191811.50271-1-rrameshbabu@nvidia.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20240118191811.50271-1-rrameshbabu@nvidia.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: queasysnail.net Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable 2024-01-18, 11:18:06 -0800, Rahul Rameshbabu wrote: > This reverts commit b34ab3527b9622ca4910df24ff5beed5aa66c6b5. >=20 > Using skb_ensure_writable_head_tail without a call to skb_unshare causes > the MACsec stack to operate on the original skb rather than a copy in the > macsec_encrypt path. This causes the buffer to be exceeded in space, and > leads to warnings generated by skb_put operations. Opting to revert this > change since skb_copy_expand is more efficient than > skb_ensure_writable_head_tail followed by a call to skb_unshare. Paolo, are you ok with this commit message? I agree it's a bit confusing but I can't think of anything clearer :( Other than those details on the commit message (the stack trace could also have been trimmed a bit), a revert sounds good to me. --=20 Sabrina