From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFAF72AF16 for ; Sat, 3 Feb 2024 13:18:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706966330; cv=none; b=XSZ2NVkVdzqJg3m49HYBt33yzLJbXKIJ1oW1gXTxiEjPTYQ5TuvKwmR961ZbGJ17YzDJErv+qruES33wJEyjBr4d4uceJgzgnRuYpzh6DMI6NYJ1i8AAtdFlzmanuGovfFzurY3DLEWnYq2TXRUoEDhjOQOW+UFM9pxMGXq5Iqk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706966330; c=relaxed/simple; bh=ebWJCjT30yIAAIxmF96XqYeAeD4KseJ+IIABQegktLw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IT0De9kHJRh+AckMEbcPTRqgm7ZYgPu3IDX86c5geUyYiXLT5uKen76SRhEqZlCQ+ssJBoG6Bhww/vK7xk6yFc9QWx45nN8aOg+sPuMjt+Tm3mp4g2YThQEA55cq4Z4MyJHCBB8evzu/Wto/Rskh5iMpUOHBF4kZVFqjeZWe/pc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us; spf=none smtp.mailfrom=resnulli.us; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b=pmdAF86Q; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=resnulli.us Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b="pmdAF86Q" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-40fc654a718so12707815e9.2 for ; Sat, 03 Feb 2024 05:18:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1706966327; x=1707571127; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=DWfHGvyLS9Vdj8BUW4SV7fQsQn/7GRDVDPI4v8u0+as=; b=pmdAF86QQnmX1X3mniABw89pNEUSCB6jA5BOP7aRYZnbKDyOE8AJNrpsPn88JOd3V0 ku+OyIdCTK1TAe+GpgyJ5DWBjZIapGdbwRbjhJdB4bHlfU6w5SUplHyE0A8ZgtDoWeE6 EkGXuhGZlzPyEKMpNSJwqVTeRtuFGCuNWjriYkq/FbQh5pS/kJbTBNzbq20go0Ie08Cy 7gfI6G0pGneyEtew4vnnC2ADIACIT9Ae6vK/WQRnOmuUhcpATsTVERno7g4yNJxODPjJ sAkPL8VXAv5XEuTUgDir5RHwG88MuKAXjWKBbdXkuzYp4Ks8HbeweHW+SpPEi0RZ5CQV FXbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706966327; x=1707571127; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DWfHGvyLS9Vdj8BUW4SV7fQsQn/7GRDVDPI4v8u0+as=; b=mV7VvWXtgCzZssPvLlsl/Ps34aIh4E5RBm9YnpaSXiSiA87f1rl/+b4fDGXiBAieio F456hJguakbPOER+YjXvqfSWJ90aLV9CiRcq2Dt+fe41OqXnbHDC1nHLowrgxHZo1YOg Fi33LgV13e/Kf+NS5thSj8Zg85EzVaQwwZ+fgIYLqL3j8ownMzwLypyPm/3ZJ9U4f/yd BNo16tyaRflMH2nrP/0ZRDXfLr7hFfG/oRZ67F4QhRCWm8o5mbjrmt9aWdbBQShvHsjV 0r1TYCQx6qifwo+kTiGDt3R9Q33PZFjrgTX+J+DNPybu4KMh6wPvbinCfHtSu6gtD/g8 YjFA== X-Gm-Message-State: AOJu0YyQ4aRtrQDXs96jbMVfSv5rMUGm4PBQtHMhfUJElP12nb7CbqIW V+mc5r3InrxSq8g0AXEJbEkUtm/2Rs9CgeQiMqTz9YW4+trh/pjOM8V8zDXoatw= X-Google-Smtp-Source: AGHT+IHbhiTWLBl6YahL3JztbgGYK6YB780/wlpqRr77AzqPbB4zWyVEyfXchL5cgCYGdII6nMrG2w== X-Received: by 2002:adf:fd45:0:b0:33a:e56f:1ddb with SMTP id h5-20020adffd45000000b0033ae56f1ddbmr3178428wrs.46.1706966326943; Sat, 03 Feb 2024 05:18:46 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCX8boruPRGCZlECRQFcP7XDgA7uXo0XyWVGVmXTuh79Q8jTdX7LTleA+Kmy8ecCa7gYnyawFJUfOGf7YK4k0mXE9M0sARfiyGnPPXQplpXIfF3PumEU7SNPYCLOnpvAiDwylGD2nvgqJA7odDPvgNY2XcYbigJx7JsdXGMo6/fNe7fmEI92Qn/M3FEBfMHgoMMEQK4gkSDxXz213p4Jf7WGlwY2aJWz4elfy+2MYDVb+vLDpira3eEBq7dgeMDsXQClnsaCgJEvd668GohgqIsWKU6zshmBGvOLTNxAsCa+ONdEEu71kfrwfinkI4ZoT3hnE0GeOim2oXmtYDs+B3mNYMyz0w57NkRwKC9CvyWh77yFKFdXYhj99/ZIU4Mnb6fT4r8H3Gr8Wm/TTzh1VY9MM1W+lZIAstMUREHZfOWiMrLDjv9ILLWxdyZcs3lL1sbRIaG3f/nv4V3aweMSBgXb4ksqXuu82PUIU8StcD8oEqPaSGVopkrptkmFtuO5wE7SCsjNzOu4aLpYMzsiSX+FM7gZCLfV6GSILppQhIvkJWiYIFHJ8OkW/+JJ1Fy9zEk= Received: from localhost ([193.47.165.251]) by smtp.gmail.com with ESMTPSA id s2-20020a056402164200b0055f2af9b01bsm1729280edx.17.2024.02.03.05.18.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Feb 2024 05:18:46 -0800 (PST) Date: Sat, 3 Feb 2024 14:18:43 +0100 From: Jiri Pirko To: Furong Xu <0x1207@gmail.com> Cc: "David S. Miller" , Alexandre Torgue , Jose Abreu , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Joao Pinto , Simon Horman , Serge Semin , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, xfr@outlook.com, rock.xu@nio.com Subject: Re: [PATCH net] net: stmmac: xgmac: fix a typo of register name in DPP safety handling Message-ID: References: <20240203053133.1129236-1-0x1207@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240203053133.1129236-1-0x1207@gmail.com> Sat, Feb 03, 2024 at 06:31:33AM CET, 0x1207@gmail.com wrote: >DDPP is copied from Synopsys Data book: > >DDPP: Disable Data path Parity Protection. > When it is 0x0, Data path Parity Protection is enabled. > When it is 0x1, Data path Parity Protection is disabled. > >The macro name should be XGMAC_DPP_DISABLE. > >Fixes: 46eba193d04f ("net: stmmac: xgmac: fix handling of DPP safety error for DMA channels") >Signed-off-by: Furong Xu <0x1207@gmail.com> Looks okay, but this is net-next material. >--- > drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h | 2 +- > drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h >index 5c67a3f89f08..6a2c7d22df1e 100644 >--- a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h >+++ b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h >@@ -304,7 +304,7 @@ > #define XGMAC_TXCEIE BIT(0) > #define XGMAC_MTL_ECC_INT_STATUS 0x000010cc > #define XGMAC_MTL_DPP_CONTROL 0x000010e0 >-#define XGMAC_DDPP_DISABLE BIT(0) >+#define XGMAC_DPP_DISABLE BIT(0) > #define XGMAC_MTL_TXQ_OPMODE(x) (0x00001100 + (0x80 * (x))) > #define XGMAC_TQS GENMASK(25, 16) > #define XGMAC_TQS_SHIFT 16 >diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c >index 04d7c4dc2e35..323c57f03c93 100644 >--- a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c >+++ b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c >@@ -928,7 +928,7 @@ dwxgmac3_safety_feat_config(void __iomem *ioaddr, unsigned int asp, > /* 5. Enable Data Path Parity Protection */ > value = readl(ioaddr + XGMAC_MTL_DPP_CONTROL); > /* already enabled by default, explicit enable it again */ >- value &= ~XGMAC_DDPP_DISABLE; >+ value &= ~XGMAC_DPP_DISABLE; > writel(value, ioaddr + XGMAC_MTL_DPP_CONTROL); > > return 0; >-- >2.34.1 > >