From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Christian Marangi <ansuelsmth@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Michal Simek <michal.simek@amd.com>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next] net: phy: constify phydev->drv
Date: Sat, 3 Feb 2024 17:23:56 +0000 [thread overview]
Message-ID: <Zb52rPnYmkmqTTr4@shell.armlinux.org.uk> (raw)
In-Reply-To: <7f4f7fc2-6bf3-4ecb-9c13-763e2d4f176f@lunn.ch>
On Sat, Feb 03, 2024 at 05:56:19PM +0100, Andrew Lunn wrote:
> On Fri, Feb 02, 2024 at 05:41:45PM +0000, Russell King (Oracle) wrote:
> > Device driver structures are shared between all devices that they
> > match, and thus nothing should never write to the device driver
>
> nothing should never ???
>
> I guess the never should be ever?
Yes, thanks for spotting that.
> > struct gmii2rgmii {
> > struct phy_device *phy_dev;
> > - struct phy_driver *phy_drv;
> > + const struct phy_driver *phy_drv;
> > struct phy_driver conv_phy_drv;
> > struct mdio_device *mdio;
> > };
>
> Did you build testing include xilinx_gmii2rgmii.c ? It does funky
> things with phy_driver structures.
CONFIG_XILINX_GMII2RGMII=m
So yes.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2024-02-03 17:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-02 17:41 [PATCH net-next] net: phy: constify phydev->drv Russell King (Oracle)
2024-02-03 16:56 ` Andrew Lunn
2024-02-03 17:04 ` Christian Marangi
2024-02-03 17:23 ` Russell King (Oracle) [this message]
2024-02-06 12:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zb52rPnYmkmqTTr4@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=michal.simek@amd.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).