From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06D935F842 for ; Sat, 3 Feb 2024 17:24:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706981056; cv=none; b=hhw2xFIPE+Y+a3IvdDZmweUJBPFuDEWHPMeLpvtdFDtghfUtzKSashnGAoda4nsIDxAMUWBLFEbga6sg+LsBFakHGc4HVlSNfG9rChwaO7IWR1flNQQDSlCbDYKER/PmBwKzgHVwUorFc8L+1LWei5cgINKbn/b83+bEPIQNm0o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706981056; c=relaxed/simple; bh=mKvRz8sYukpiYVgwK4ElPJLe/EGCHIBlSjLXDNwsqyo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sUmpkamiI9XsxPXfZ00RuYLUoHszeDVU3HVrdoB5mJnWKXJ0R5g3EHtyLXZw4tG8IjFGFPLiC1TcuYYsU+IIKGw8OS/gVmbH9Dzse5RBGi/l4Zp5BlvJdYzJVGJ8Ia0nTBv4KwrwPx0lNYxDJU33VxRisbxKWx7kSIbjGDqvwuw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=NJnGev0H; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="NJnGev0H" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=5o3Xvx1PmTQzS2Sezw6yImp07a9AspKSvTzW4LzSUPU=; b=NJnGev0HwXBjm/0WS37JZ4cuBm Gvh1GJ4twuun3xWKFsJLhOYQ/Hq4Uj9g2V8GiMwI1/NcbKgdcZOFdW7UNdiHSmmnXM5JZCDWtxOR0 +KoFcfJlpeFGeqLkMwqMqt21odlH/5gml3HM0e/8ENA7HVa5liRzD14EhJkDsCqTMbrd+V80PZOF6 pVO5n4u6rNbPEXOXzhxOuYRcEtbuRtIohSsUtPx7Mfmy9wPrqc+BgZQNLO2e9Qa7Tx/l67+mK2POv HXm6dmd4lJlIbO8NOu6Ae40IP1daeOYXTYZ6ZmTaAOoUSnroAx3wNP0mfy2QAKhEBMabyjgOJBoqc wKxuca5A==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:59486) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rWJkH-0007Hw-13; Sat, 03 Feb 2024 17:24:01 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1rWJkC-0000zS-LJ; Sat, 03 Feb 2024 17:23:56 +0000 Date: Sat, 3 Feb 2024 17:23:56 +0000 From: "Russell King (Oracle)" To: Andrew Lunn Cc: Heiner Kallweit , Christian Marangi , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Michal Simek , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net-next] net: phy: constify phydev->drv Message-ID: References: <7f4f7fc2-6bf3-4ecb-9c13-763e2d4f176f@lunn.ch> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7f4f7fc2-6bf3-4ecb-9c13-763e2d4f176f@lunn.ch> Sender: Russell King (Oracle) On Sat, Feb 03, 2024 at 05:56:19PM +0100, Andrew Lunn wrote: > On Fri, Feb 02, 2024 at 05:41:45PM +0000, Russell King (Oracle) wrote: > > Device driver structures are shared between all devices that they > > match, and thus nothing should never write to the device driver > > nothing should never ??? > > I guess the never should be ever? Yes, thanks for spotting that. > > struct gmii2rgmii { > > struct phy_device *phy_dev; > > - struct phy_driver *phy_drv; > > + const struct phy_driver *phy_drv; > > struct phy_driver conv_phy_drv; > > struct mdio_device *mdio; > > }; > > Did you build testing include xilinx_gmii2rgmii.c ? It does funky > things with phy_driver structures. CONFIG_XILINX_GMII2RGMII=m So yes. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!