From: Hangbin Liu <liuhangbin@gmail.com>
To: Kui-Feng Lee <sinquersw@gmail.com>
Cc: thinker.li@gmail.com, netdev@vger.kernel.org, ast@kernel.org,
martin.lau@linux.dev, kernel-team@meta.com, davem@davemloft.net,
dsahern@kernel.org, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, kuifeng@meta.com
Subject: Re: [PATCH net-next v3 4/5] net/ipv6: set expires in modify_prefix_route() if RTF_EXPIRES is set.
Date: Sun, 4 Feb 2024 18:17:42 +0800 [thread overview]
Message-ID: <Zb9kRrG_7LRl1i2W@Laptop-X1> (raw)
In-Reply-To: <536038f7-cc33-46c7-a3e9-2c9f27bc9c81@gmail.com>
On Fri, Feb 02, 2024 at 09:57:46AM -0800, Kui-Feng Lee wrote:
> > Hi Kui-Feng,
> >
> > I may missed something. But I still could not get why we shouldn't use
> > expires for checking? If expires == 0, but RTF_EXPIRES is on,
> > shouldn't we call fib6_clean_expires()?
>
>
> The case that expires == 0 and RTF_EXPIES is on never happens since
> inet6_addr_modify() rejects valid_lft == 0 at the beginning. This
> patch doesn't make difference logically, but make inet6_addr_modify()
> and modify_prefix_route() consistent.
>
> Does that make sense to you?
Thanks, this does make sense to me. If there will be a new version. It would
be good to add the following sentence in the description.
"""
This patch doesn't make difference logically, but make inet6_addr_modify()
and modify_prefix_route() consistent.
"""
Reviewed-by: Hangbin Liu <liuhangbin@gmail.com>
Regards
Hangbin
next prev parent reply other threads:[~2024-02-04 10:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-02 8:21 [PATCH net-next v3 0/5] Remove expired routes with a separated list of routes thinker.li
2024-02-02 8:21 ` [PATCH net-next v3 1/5] net/ipv6: set expires in rt6_add_dflt_router() thinker.li
2024-02-02 11:52 ` Hangbin Liu
2024-02-05 4:42 ` David Ahern
2024-02-02 8:21 ` [PATCH net-next v3 2/5] net/ipv6: Remove unnecessary clean thinker.li
2024-02-05 4:42 ` David Ahern
2024-02-02 8:21 ` [PATCH net-next v3 3/5] net/ipv6: Remove expired routes with a separated list of routes thinker.li
2024-02-04 10:29 ` Hangbin Liu
2024-02-04 16:10 ` David Ahern
2024-02-05 4:45 ` David Ahern
2024-02-05 15:24 ` David Ahern
2024-02-02 8:21 ` [PATCH net-next v3 4/5] net/ipv6: set expires in modify_prefix_route() if RTF_EXPIRES is set thinker.li
2024-02-02 12:16 ` Hangbin Liu
2024-02-02 17:57 ` Kui-Feng Lee
2024-02-04 10:17 ` Hangbin Liu [this message]
2024-02-05 18:59 ` Kui-Feng Lee
2024-02-02 8:22 ` [PATCH net-next v3 5/5] selftests/net: Adding test cases of replacing routes and route advertisements thinker.li
2024-02-02 12:37 ` Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zb9kRrG_7LRl1i2W@Laptop-X1 \
--to=liuhangbin@gmail.com \
--cc=ast@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=kuifeng@meta.com \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sinquersw@gmail.com \
--cc=thinker.li@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).